Improve and simplify integration with ORM internals #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 8, 2024
mpdude
added a commit
that referenced
this pull request
Jan 9, 2024
…. objects (#30) To avoid side effects during Doctrine ORM PHP-value-to-database-value conversion, this PR in part reverts design changes from #28: On the `preFlush` event, remove all `PersistentTranslatable` instances from managed entities and replace them with their plain (primary) values. On `postFlush`, but the `PersistentTranslatable`s back in place. That way, the default (plain) values are in place when the ORM does its change detection. Previously, in fact `PersistentTranslatables` were casted to string when the ORM gathered the values to insert into the database. That does not work when the column type is `object`, since it would try to serialize the `PersistentTranslatable` itself.
This was referenced Mar 22, 2024
Closed
mpdude
added a commit
that referenced
this pull request
Apr 25, 2024
It may be useful to use the `#[Polyglot\Translatable]` attribute (or the corresponding annotation) on properties that are not configured as mapped Doctrine ORM fields. For example, the property value might be set by entity lifecycle callbacks or Doctrine listeners. It was possible to do so until #28 changed `\Webfactory\Bundle\PolyglotBundle\Doctrine\TranslatableClassMetadata::findTranslatedProperties` to work based on Doctrine ORM `ClassMetadata` information and fields. This was done to simplify detection of whether a particular property belongs to a given class or needs to be mapped through base class translations. Obviously, `ClassMetadata` does not know about unmapped properties. This PR changes the code to work on PHP reflection data instead, restoring functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following improvements:
PolyglotListenerinjectsTranslatableinto entities when they are loaded and/or updates are flushed to the database. IMHO it's less interference with ORM lifecycle methods. We can avoid keeping a list of all entities with translations inPolyglotListener, which helps with garbage collection.@TranslationsCollectionand its own translations class. The translations class should only contain fields present in the corresponding class in the inheritance tree. The@Localeannotation will be searched for on parent classes as well.