Test that Translatables can be used for values beyond strings, e. g. objects
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n preFlush, and re-inject them in postFlush This way we can be sure to get the default Doctrine change tracking and column conversion logic. This allows us to use e. g. object type columns as well. When the change detection runs, no PersistentTranslatable proxies are in the way.
mpdude
changed the title
Translatables can in fact be used for values beyond strings, e. g. objects
mpdude
changed the title
Translatables can in fact be used for values beyond strings, e. g. objectsTranslatables can be used for values beyond strings, e. g. objects
This was referenced Mar 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid side effects during Doctrine ORM PHP-value-to-database-value conversion, this PR in part reverts design changes from #28:
On the
preFlushevent, remove allPersistentTranslatableinstances from managed entities and replace them with their plain (primary) values. OnpostFlush, but thePersistentTranslatables back in place.That way, the default (plain) values are in place when the ORM does its change detection.
Previously, in fact
PersistentTranslatableswere casted to string when the ORM gathered the values to insert into the database. That does not work when the column type isobject, since it would try to serialize thePersistentTranslatableitself.