Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] CSS hints report wrong position for CSS inline in HTML [3.5] #1956

Closed
antross opened this issue Feb 22, 2019 · 0 comments · Fixed by #2062
Closed

[Bug] CSS hints report wrong position for CSS inline in HTML [3.5] #1956

antross opened this issue Feb 22, 2019 · 0 comments · Fixed by #2062
Assignees
@antross
Labels
type:bug
Milestone
1903-2

Comments

@antross
Copy link
Member

antross commented Feb 22, 2019

🐛 Bug report

Description

Save and open the following HTML document in VS Code with the webhint extension:

<!DOCTYPE html>
<html>
    <head>
        <style>            
            .example {
                appearance: none;
                -webkit-appearance: none;
                -moz-appearance: none;
            }
        </style>
    </head>
</html>

Expected: Error reported at appearance: none.

Actual: Error reported at <html>

Affects both hint-compat-api and hint-css-prefix-order. Should be able to be fixed using additional event data from PR #1953.
@molant molant added this to the 1903-1 milestone Feb 25, 2019
@antross antross self-assigned this Mar 8, 2019
@antross antross modified the milestones: 1903-1, 1903-2 Mar 8, 2019
@antross antross mentioned this issue Mar 12, 2019
Merged
3 tasks
@antross antross changed the title [Bug] CSS hints report wrong position for CSS inline in HTML [Bug] CSS hints report wrong position for CSS inline in HTML [2] Mar 13, 2019
antross added a commit to antross/hint that referenced this issue Mar 13, 2019
@antross
Fix: Report correct position for CSS-in-HTML
416639a 
Fix webhintio#1956
@antross antross mentioned this issue Mar 13, 2019
Merged
4 tasks
@antross antross changed the title [Bug] CSS hints report wrong position for CSS inline in HTML [2] [Bug] CSS hints report wrong position for CSS inline in HTML [3] Mar 13, 2019
antross added a commit to antross/hint that referenced this issue Mar 14, 2019
@antross
Fix: Report correct position for CSS-in-HTML
5d7562d 
Fix webhintio#1956
@antross antross changed the title [Bug] CSS hints report wrong position for CSS inline in HTML [3] [Bug] CSS hints report wrong position for CSS inline in HTML [3.5] Mar 14, 2019
antross added a commit to antross/hint that referenced this issue Mar 14, 2019
@antross
Fix: Report correct position for CSS-in-HTML
7651c2a 
Fix webhintio#1956
antross added a commit that referenced this issue Mar 15, 2019
@antross
Fix: Report correct position for CSS-in-HTML
cbfa444 
Fix #1956
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antross antross

Labels
type:bug
Projects
None yet
Milestone
1903-2
Development

Successfully merging a pull request may close this issue.

Fix position in reports for CSS and JS in HTML antross/hint
2 participants
@molant @antross