Fix position in reports for CSS and JS in HTML #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarvaje
reviewed
Mar 13, 2019
antross
force-pushed
the
fix/css-in-html-location
branch
2 times, most recently
from
b6751f8 to
1a3f93a
Compare
antross
force-pushed
the
fix/css-in-html-location
branch
from
1a3f93a to
fe28d6b
Compare
Also update docs to explain how `report` can be used with both `element` and `location` to specify an offset into an element's content.
Align with browser behavior to make these easier to consume.
Also refactor to use `innerHTML` instead of a regex against `outerHTML`.
antross
force-pushed
the
fix/css-in-html-location
branch
from
fe28d6b to
ffd74c8
Compare
|
@sarvaje @molant @utsavized This is ready for review if you have some time. I'd like to get it in so I can rebase #1924 and #1966 on it. |
Also enhance find-original-element to aid in getting location data and fix passing `ignoredUrls` to `hint-runner` in `utils-test-helpers`.
antross
force-pushed
the
fix/css-in-html-location
branch
from
ffd74c8 to
a13073c
Compare
sarvaje
suggested changes
Mar 14, 2019
molant
approved these changes
Mar 15, 2019
|
@sarvaje Any other feedback? Or am I good to merge this? |
sarvaje
approved these changes
Mar 15, 2019
|
@antross LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Short description of the change(s)
Fix #1956
Includes a number of improvements across packages already split into dedicated commits.