Remove unused dependency find-cache-dir #170
Conversation
| @@ -100,8 +100,7 @@ some issues cannot be fixed properly.** | |||
| This option will enable caching of the linting results into a file. | |||
| This is particularly useful in reducing linting time when doing a full build. | |||
|
|
|||
| The cache file is written to the `./node_modules/.cache` directory, thanks to the usage | |||
| of the [find-cache-dir](https://www.npmjs.com/package/find-cache-dir) module. | |||
| The cache file is written to the `./node_modules/.cache` directory. | |||
There was a problem hiding this comment.
Maybe we should just remove this, since the module we use might change something?
There was a problem hiding this comment.
I feel it is kind of important to mention where the cache is stored. In our case we persist this folder between 2 CI run and have some clean up script to prevent it to grow too much.
There was a problem hiding this comment.
So at least we should say "The cache file is probably written to"... (Because if the module change the path, this doc will be irrelevant).
There was a problem hiding this comment.
isn't node_modules/.cache the standard location for caching? We also fallback to os temp dir if it fails to write to ./node_modules/.cache
There was a problem hiding this comment.
My idea is: since we use a module that handle this, we don't really know what the deps will rely on, so maybe we should say "we use X" with a link so people can have an up to date link? I am just afraid this doc become out of date someday :)
PR #159 replace the experimental implementation by something more robust.
So in order to keep things accurate, find-cache-dir should be removed.
The yarn.lock file did not change because find-cache-dir is used behind the scene by other modules.