Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

build(travis): update minimum node v4.3.0...4.8.0 #204

Closed
wants to merge 1 commit into from
Closed

build(travis): update minimum node v4.3.0...4.8.0 #204

wants to merge 1 commit into from

Conversation

brianhelba
Copy link

As described in npm/npm#18395 , npm 5.4 is incompatible with Node.js 4.3. Furthermore, per https://github.com/nodejs/Release , Node.js 4.3 is no longer supported, only the latest 4.x release (currently 4.8) is still in LTS.

This change will ensure that all file-loader tests will start passing again, while keeping support for the broadest possible range of Node.js versions.

As described in npm/npm#18395 , npm 5.4 is
incompatible with Node.js 4.3. Furthermore, per
https://github.com/nodejs/Release , Node.js 4.3 is no longer supported,
only the latest 4.x release (currently 4.8) is still in LTS.

This change will ensure that all file-loader tests will start passing
again, while keeping support for the broadest possible range of Node.js
versions.
@jsf-clabot
Copy link

jsf-clabot commented Sep 29, 2017

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Sep 29, 2017

Codecov Report

Merging #204 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   96.96%   96.96%           
=======================================
  Files           2        2           
  Lines          33       33           
  Branches       16       16           
=======================================
  Hits           32       32           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abe91a8...c88f437. Read the comment docs.

@brianhelba
Copy link
Author

@d3viant0ne PTAL. This will fix tests for file-loader, which are currently broken in master.

After this is (hopefully) merged, can we get this update into #183 , and look into merging that too?

@@ -5,7 +5,7 @@
{
"useBuiltIns": true,
"targets": {
"node": "4.3"
"node": "4.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just node: '4' ?

@brianhelba
Copy link
Author

@michael-ciniawsky So, I think the path forward on this PR is to wait for webpack-contrib/webpack-defaults#82 to be merged, then pull downstream just the changes (updating Travis, ignoring the others) to this repo?

@michael-ciniawsky
Copy link
Member

Yep, if webpack-contrib/webpack-defaults#82 lands, it's just update the webpack-defaults dependency and npm run webpack-defaults to update all affected files (travis.yml etc) and commit the changes

@brianhelba
Copy link
Author

@michael-ciniawsky Got it, thanks.

@brianhelba
Copy link
Author

Closing this, to wait for webpack-contrib/webpack-defaults#82 and an associated release of webpack-defaults. At that point, I'll open a new PR to upgrade webpack-defaults in this repo.

@brianhelba brianhelba closed this Sep 29, 2017
@michael-ciniawsky michael-ciniawsky changed the title Update minimum required Node.js version to 4.8 build(travis): update minimum node v4.3.0...4.8.0 Sep 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants