feat: update minimum required node.js version to 4.8 for travis CI
#82
Conversation
alexander-akait
requested review from
sapegin,
michael-ciniawsky,
mattlewis92 and
joshwiens
.babelrc
Outdated
| @@ -5,7 +5,7 @@ | |||
| { | |||
| "useBuiltIns": true, | |||
| "targets": { | |||
| "node": "4.3" | |||
| "node": "4.8" | |||
There was a problem hiding this comment.
>= 4 (if babel-preset-env (browserslist) supports it) ?
There was a problem hiding this comment.
Something to keep in mind here. I still think the minimum needs to be a static value as opposed to >= 4 ( for both preset-env & all the engines objects in the pacakge.json ).
Thinking being you will have an ever increasing minimum node version which would have a less than optimal UX.
It's also probably worth considering finding the lowest viable version number to set as the minimum. i.e. 4.6 as opposed to the latest NodeJS minor version. I'm sure there are plenty of people that aren't on 4.8 yet ( for reasons I will never comprehend )
There was a problem hiding this comment.
According to the comment on that thread by the npm staff, the earliest supported npm node version is 4.7.
Would webpack packages using this change technically require a major version bump if we're no longer testing / supporting older node 4.x versions?
There was a problem hiding this comment.
I’m afraid people who aren’t on 4.8 aren’t on 4.6 either ;-| But I don’t know how to prove either of these points.
There was a problem hiding this comment.
Given that Node 8 is about to go LTS, I don't know if I feel terribly bad about pushing up the minimum 4.x version.
To @mattlewis92's point, following the strictest letter of the lay, yes it should be a major as it is breaking based on what is currently supported.
Give Webpack follows the LTS schedule of NodeJS & v8 goes LTS this October, the least disruptive path for the community may be to just drop 4.x when v8 officially takes over as the latest LTS.
In the mean time, the Travis config can be modified to accomodate the issue with 4.3 & npm@5
There was a problem hiding this comment.
@d3viant0ne just change only travis configuration?
There was a problem hiding this comment.
The Buffer related backports landed in v4.5.0, no idea about the if and when V8 semver minor update(s) happend in the node v4+ line. Normally within a major range it is mandatory to update to the latest minor/patch whenever possible (security etc pp). If for any corporate reasons this isn't possible, imho at some point it's just their problem and getting webpack to run is one of the smaller ones they have then 😛
alexander-akait
force-pushed
the
update-nodejs-version
branch
from
a8478bf
to
2055d57
Compare
|
@sapegin @michael-ciniawsky @mattlewis92 @d3viant0ne let's update only travis configuration for avoid problem with |
alexander-akait
changed the title
node.js version to 4.8node.js version to 4.8 for travis CI
|
@evilebottnawi @mattlewis92 Can this be merged? I'd like to pull it downstream to fix failing tests in https://github.com/webpack-contrib/file-loader . See webpack-contrib/file-loader#204 |
|
@d3viant0ne Can you please publish a new release of this repo, so we can pull the changes downstream to other projects? |
|
Just did |
|
|
|
Awesome, thanks so much! |
Based on webpack-contrib/file-loader#183 (comment).
Issue around
npm- npm/npm#18395.From
slack:sokra [12:29 PM] we are no longer chained to 4.3. You can use that lastest 4.x (node.js version currently in maintenance mode. 4.3 was because of AWS, but they upgraded to node 6.x so this is no longer an issue.