Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(loader): v1.0.0 #155

Closed
wants to merge 20 commits into from
Closed

refactor(loader): v1.0.0 #155

wants to merge 20 commits into from

Conversation

joshwiens
Copy link
Member

@joshwiens joshwiens commented Dec 5, 2017 •
edited
Loading

Compatibility issues
  • JSDom e2e test failures
Commit message body
- Fixes for Webpack 4.x
- Drops support for NodeJS 4.x
- Drops support for Webpack 2.x

BREAKING CHANGE: Sets `engines` to `"node": ">= 6.9.0 || >= 8.9.0"`
BREAKING CHANGE: Drops support for Webpack `v2.x`

@joshwiens joshwiens self-assigned this Dec 5, 2017
@joshwiens joshwiens changed the title [WIP] refactor: Zoplfi Plugin Webpack 4.x compatibility [WIP] refactor: HTML Plugin Webpack 4.x compatibility Dec 5, 2017
@joshwiens
Copy link
Member Author

For reference, the test suite needs work before this can go anywhere

@joshwiens joshwiens mentioned this pull request Dec 14, 2017
Merged
@joshwiens joshwiens changed the title [WIP] refactor: HTML Plugin Webpack 4.x compatibility refactor: Webpack 4.x compatibility Dec 22, 2017
@webpack-contrib webpack-contrib deleted a comment from codecov bot Dec 22, 2017
@michael-ciniawsky michael-ciniawsky changed the title refactor: Webpack 4.x compatibility refactor(loader): v1.0.0 Jan 4, 2018
@michael-ciniawsky michael-ciniawsky force-pushed the next branch 2 times, most recently from 03f1d6f to 33d00c2 Compare January 8, 2018 07:20
@michael-ciniawsky
Copy link
Member

Noteable Changes

Features

url (options.url)

file.html

<body>
 <img src="path/to/file.png">
</body>

module.js

import HTML__URL__0 from 'path/to/file.png';

export default `<body>
  <img src="${HTML__URL__0}">
</body>
`

import (options.import)

file.html

<body>
  <import src="path/to/import.html">
</body>

module.js

import HTML__IMPORT__0 from 'path/to/import.html';

export default `<body>
  ${HTML__IMPORT__0}
</body>
`

template (options.template)

file.html

<body>
  <h1>${ _.hello }</h1>
</body>

entry.js

import template from './file.html';

const html = template({ hello: 'Hello World' });

document.body.innerHTML = `${html}`;

minimize (options.minimize)

BREAKING CHANGES

root (options.root)

  • Removed

attrs (options.attrs)

  • Removed (will be handled by the url plugin)

interpolate (options.interpolate)

  • Removed in favor of options.template

exportAsDefault && exportAsEs6Default (options.exportAsDefault|options.exportAsEs6Default)

  • Removed in favor of just exporting an ES2015 Module :)

Issues

  • All 😛

TODO

  • tag:attrs matchers for URL's (options.url)

Status

Name Status
Default ✅
HTML URLs ✅
HMTL Imports ✅
HMTL Templates ✅
HTML Minification ⚠️

@michael-ciniawsky michael-ciniawsky added this to the 1.0.0 milestone Jan 8, 2018
@edmorley
Copy link

edmorley commented Jan 23, 2018 •
edited
Loading

Hi! I was about to about to open a PR to change the default value for attrs to ['img:src', 'link:href'] (ie add link:href) so that favicons amongst other things are picked up by default (#17).

Is this a change that you'd be open to folding into the work here? (Seeing as it would conflict with this PR and it's a breaking change that would need a 1.0.0 release anyway?)

michael-ciniawsky and others added 12 commits February 6, 2018 04:15
@edmorley
Copy link

Hi! What work is left before this is ready to be released as a beta/1.0 final? :-)

@alexander-akait alexander-akait deleted the next branch March 19, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshwiens joshwiens

Labels
branch: Next pr_action: Discuss priority: 3 (required) semver: Major status: Pending type: Refactor
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@joshwiens @michael-ciniawsky @edmorley @alexander-akait