Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

ES6 support broken again #362

Closed
bskydive opened this issue Oct 1, 2018 · 1 comment
Closed

ES6 support broken again #362

bskydive opened this issue Oct 1, 2018 · 1 comment

Comments

@bskydive
Copy link

bskydive commented Oct 1, 2018

npm i uglifyjs-webpack-plugin@1
solve problems in angular es6 : ERROR in main....bundle.js from UglifyJs Unexpected token: keyword (const) ...
In the most popular webpack+angular config used @1 version, not @2: https://github.com/gdi2290/angular-starter/blob/master/package.json

Originally posted by @bskydive in #104 (comment)

@alexander-akait
Copy link
Member

@bskydive Please:

  1. Use issue template in future
  2. Read CHANGELOG before post issue (https://github.com/webpack-contrib/uglifyjs-webpack-plugin/releases/tag/v2.0.0)
  1. Use https://github.com/webpack-contrib/terser-webpack-plugin for ES6 (webpack@5 will be use this plugin for uglification)

jasiekmarc pushed a commit to iiuni/projektzapisy that referenced this issue Dec 16, 2018
* upgrade Typescript do najnowszej wersji 3.2.2
* przechodzimy z UglifyJS na Terser. W skrócie: do tej pory `uglifyjs-webpack-plugin` korzystał z `uglify-es`, które radzi sobie z optymalizacją es6, ale zostało porzucone. Nowe wersje `uglifyjs-webpack-plugin` (> 2.0.0) przerzuciły się na `UglifyJS`, ale on nie potrafi pracować z ES6+. Rozwiązaniem jest utrzymywany fork `uglify-es` o nazwie Terser, z którego panowie z Webpacka planują korzystać w kolejnej wersji (webpack-contrib/uglifyjs-webpack-plugin#362), więc powinien być bezpiecznym wyborem.
* wyrzucenie opcji progress z opcji `build` w package.json; dodanie jej tam było błędem, bo konsola w CircleCI i podobnych serwisach nie obsługuje powrotu/czyszczenia linii, wobec czego log z kompilacji wygląda tak: https://gyazo.com/a4df70d2e1e94a5663e9c23b7faacd0b
* wyrzucenie nieużywanego speed-measure-plugina
shopwareBot pushed a commit to shopware/shopware that referenced this issue Jan 7, 2019
shopwareBot pushed a commit to shopware/shopware that referenced this issue Jan 7, 2019
…-admin-dependencies to master

* commit '87bc316e639a58ae4d85e58bdb1f42e4bb1ecb89':
  NEXT-1386 Remove call to remove symfony toolbar
  NEXT-1386 Removed selenium-server
  NEXT-1386 Fixed e2e test after nightwatch update
  NEXT-1386 Removed nsp and extract-text-webpack-plugin
  NEXT-1386 Split selenium config and use different configs for the different test environments
  NEXT-1386 Updated custom launcher for karma unit tests
  NEXT-1386 Updated e2e dependencies
  NEXT-1386 Fixed karma tests
  NEXT-1386 Removed uglifyjs-webpack-plugin in favor for terser-webpack-plugin for proper ES6 support. See: webpack-contrib/uglifyjs-webpack-plugin#362
  NEXT-1386 Refactored feature flag generator and modify the structure of existing feature flags to match the new convention
  NEXT-1386 Updated babel to version 7
shopwareBot pushed a commit to shopware/administration that referenced this issue Jan 7, 2019
floriandejonckheere added a commit to OpenWebslides/openwebslides-frontend that referenced this issue Apr 8, 2019
UglifyJS ES6 support is broken and results in an
'Unexpected token: keyword (const)' message on build.
See webpack-contrib/uglifyjs-webpack-plugin#362
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants