[WIP] Drop node 10 and webpack 4 #2834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| process.env.NODE_ENV === "none") | ||
| ) { | ||
| configOptions.mode = process.env.NODE_ENV; | ||
| } |
There was a problem hiding this comment.
We should keep these logic, for procee.env.NODE_ENV
|
I will update 👍🏻 |
|
Let's rebase after #2833 |
|
Done here #2879, also we need simplify our logic in many method, I will do it, anyway thanks for PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
removed tests for v4.
If relevant, did you update the documentation?
Not yet
Summary
Drop node 10 and webpack 4
Does this PR introduce a breaking change?
YES
Other information
No