Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next #2879

Closed
wants to merge 8 commits into from
Closed

Next #2879

wants to merge 8 commits into from

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Aug 5, 2021

What kind of change does this PR introduce?

refactoring + bugfix + features + other

Did you add tests for your changes?

Yes

If relevant, did you update the documentation?

Yes

Summary

It is the next branch

Does this PR introduce a breaking change?

Yes, list of breaking changes will be here in future

Other information

TODO:

  • drop node v10
  • drop webpack v4 + aliases for watch (i.e. w), devtool. i.e. d, target is t, output-path is o were removed
  • remove prefetch
  • update all deps to the latest
  • --entry require --entry-reset before (need add test(s))
  • --target require --target-reset before (need add test(s))
  • refactor build tests - avoid using scripts/prepareSuite.js and put all deps in top package.json + rename tests
  • node-env should be renamed?
  • simplify logic for getBuiltInOptions and remove extra map/reduce/etc and avoid using builtInOptionsCache
  • make stable CLI API for public usage
  • avoid unnecessary process.exit()
  • resolve TODO where it possible
  • remove webpack version in favor webpack info

BRAKING CHANGE:  the `--hot` option was removed for `webpack build` and `webpack watch` commands in favor directly usage `HotModuleReplacement` plugin
BREAKING CHANGE: the `migrate` command was removed without replacement, please use migration guide
@alexander-akait alexander-akait requested a review from a team as a code owner August 5, 2021 17:19
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #2879 (b8e834a) into master (82b1fb7) will decrease coverage by 1.93%.
The diff coverage is 95.31%.

❗ Current head b8e834a differs from pull request most recent head e0cf5e5. Consider uploading reports for the commit e0cf5e5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2879      +/-   ##
==========================================
- Coverage   94.95%   93.01%   -1.94%     
==========================================
  Files          31       30       -1     
  Lines        1704     1647      -57     
  Branches      484      448      -36     
==========================================
- Hits         1618     1532      -86     
- Misses         86      115      +29     
Impacted Files Coverage Δ
packages/webpack-cli/lib/plugins/CLIPlugin.js 100.00% <ø> (ø)
packages/webpack-cli/lib/webpack-cli.js 96.06% <95.16%> (-0.71%) ⬇️
packages/serve/src/index.ts 69.81% <100.00%> (-14.57%) ⬇️
packages/configtest/src/index.ts 92.30% <0.00%> (-3.85%) ⬇️
packages/webpack-cli/lib/index.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82b1fb7...e0cf5e5. Read the comment docs.

@@ -8,7 +8,7 @@
"url": "https://github.com/webpack/webpack-cli.git"
},
"engines": {
"node": ">=10.13.0"
"node": ">=12.13.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the min for ESM support. Same needed for other subpackages

Suggested change
"node": ">=12.13.0"
"node": ">=12.22.0"

@@ -1 +0,0 @@
_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because husky adds it's install time scripts in this folder that aren't supposed to be tracked

"internal-ip": "^6.2.0",
"jest": "^27.0.3",
"jest-watch-typeahead": "^0.6.1",
"lerna": "^4.0.0",
"lint-staged": "^10.5.0",
"lint-staged": "^11.1.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, this is up to 12 now

@alexander-akait alexander-akait deleted the next branch May 18, 2022 16:54
@snitin315 snitin315 mentioned this pull request Oct 28, 2022
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants