Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix serve errors on windows #3784

Merged
merged 12 commits into from
May 11, 2023
Merged

test: fix serve errors on windows #3784

merged 12 commits into from
May 11, 2023

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented May 10, 2023

What kind of change does this PR introduce?
tests

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
no
Summary
Fix tests on master.

Follow up #3783

Does this PR introduce a breaking change?
No

Other information
No

@snitin315 snitin315 changed the title ci: debug errors on windows test: fix serve errors on windows May 10, 2023
@snitin315 snitin315 marked this pull request as ready for review May 10, 2023 11:49
@snitin315 snitin315 requested a review from a team as a code owner May 10, 2023 11:49
Comment on lines +382 to -385
const { stdout, stderr } = await runWatch(__dirname, ["serve", "-w", "--port", port]);

expect(exitCode).toBe(0);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't test on the exit code for the serve because we exit forcefully and the exit code is different on Linux/windows.

const processKill = (process) => {
if (isWindows) {
exec("taskkill /pid " + process.pid + " /T /F");
} else {
process.kill();
}
};

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #3784 (1806e89) into master (eaca5d2) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3784   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files          22       22           
  Lines        1624     1624           
  Branches      462      462           
=======================================
  Hits         1488     1488           
  Misses        136      136           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaca5d2...1806e89. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants