Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix serve errors on windows #3784

Merged
merged 12 commits into from
May 11, 2023
Merged

test: fix serve errors on windows #3784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
40b76e4
ci: debug errors on windows
snitin315 May 10, 2023
951e1e8
ci: debug errors on windows
snitin315 May 10, 2023
a75236b
ci: debug errors on windows
snitin315 May 10, 2023
2cc8a00
ci: debug
snitin315 May 10, 2023
0b9b1c9
ci: debug
snitin315 May 10, 2023
44d645c
ci: debug
snitin315 May 10, 2023
b582d60
ci: debug
snitin315 May 10, 2023
cd227d2
ci: fix
snitin315 May 10, 2023
9bbb299
ci: fix
snitin315 May 10, 2023
8a1accd
fix: serve tests
snitin315 May 10, 2023
f4f812f
chore: fix everything
snitin315 May 10, 2023
1806e89
chore: fix everything
snitin315 May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/serve/basic/__snapshots__/serve-basic.test.js.snap.devServer4.webpack5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ exports[`basic serve usage should throw error when same ports in multicompiler:

exports[`basic serve usage should throw error when same ports in multicompiler: stdout 1`] = `""`;

exports[`basic serve usage should work and log warning on the \`watch option in a configuration: stderr 1`] = `
exports[`basic serve usage should work and log warning on the 'watch' option in a configuration: stderr 1`] = `
"[webpack-cli] No need to use the 'serve' command together with '{ watch: true | false }' or '--watch'/'--no-watch' configuration, it does not make sense.
<i> [webpack-dev-server] Project is running at:
<i> [webpack-dev-server] Loopback: http://localhost:<port>/
Expand Down
8 changes: 3 additions & 5 deletions test/serve/basic/serve-basic.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ describe("basic serve usage", () => {
expect(stdout).toContain("development");
});

it("should work and log warning on the `watch option in a configuration", async () => {
it("should work and log warning on the 'watch' option in a configuration", async () => {
const { stderr, stdout } = await runWatch(__dirname, [
"serve",
"--config",
Expand All @@ -371,18 +371,16 @@ describe("basic serve usage", () => {
});

it("should log error on using '--watch' flag with serve", async () => {
const { exitCode, stdout, stderr } = await runWatch(testPath, ["serve", "--watch"]);
const { stdout, stderr } = await runWatch(__dirname, ["serve", "--watch", "--port", port]);

expect(exitCode).toBe(0);
expect(normalizeStderr(stderr)).toMatchSnapshot("stderr");
expect(stdout).toContain("HotModuleReplacementPlugin");
expect(stdout).toContain("main.js");
});

it("should log warning on using '-w' alias with serve", async () => {
const { exitCode, stdout, stderr } = await runWatch(testPath, ["serve", "-w"]);
const { stdout, stderr } = await runWatch(__dirname, ["serve", "-w", "--port", port]);

expect(exitCode).toBe(0);
Comment on lines +382 to -385
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't test on the exit code for the serve because we exit forcefully and the exit code is different on Linux/windows.

webpack-cli/test/utils/test-utils.js

Lines 31 to 37 in eaca5d2

const processKill = (process) => {
if (isWindows) {
exec("taskkill /pid " + process.pid + " /T /F");
} else {
process.kill();
}
};

expect(normalizeStderr(stderr)).toMatchSnapshot("stderr");
expect(stdout).toContain("HotModuleReplacementPlugin");
expect(stdout).toContain("main.js");
Expand Down