-
-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: webpack-cli v3 #448
Merged
Merged
Changes from all commits
Commits
Show all changes
75 commits
Select commit
Hold shift + click to select a range
ec6cc38
chore(monorepo): move to lerna
sendilkumarn bdafce0
chore(monorepo): use commands as normal instead of package
sendilkumarn 3dd244b
fix(revert): packagejson
sendilkumarn 059d6f9
chore(monorepo): prune files and update eslint rules
sendilkumarn 8ef1804
chore(monorepo): fix the no-missing-require error
sendilkumarn a1d5406
chore(monorepo): fix typo
sendilkumarn a6a2715
chore(monorepo): fix typo
sendilkumarn e9bc6eb
Merge branch 'master' into lerna-workspace
sendilkumarn 64cfef7
chore(monorepo): prune package json
sendilkumarn 2738a1e
Merge branch 'next' into lerna-workspace
sendilkumarn d4c7c5d
chore(monorepo): merge package lock json
sendilkumarn ff6c371
chore(monorepo): updated package.json
sendilkumarn 3c822cf
chore(monorepo): fix plugin package.json
sendilkumarn bdf7e5a
Merge pull request #353 from sendilkumarn/lerna-workspace
sendilkumarn fa452a0
chore(cli): move to lerna and scoped packages (#434)
evenstensberg b1a8398
chore(rebase): merge master branch
evenstensberg 1db677e
chore(linting): resolve linter errors
evenstensberg a76c46f
chore(linting): fix linting errors
evenstensberg 8f6f1db
chore(linting): resolve linting
evenstensberg 80c9e9a
chore(linting): resolve linting
evenstensberg b2a7470
chore(scaffold): move addons to scaffold
evenstensberg df8287d
chore(scaffold): fix linting errors
evenstensberg f8a71c0
cli(prompt): initial comment for prompt file
evenstensberg 5f357c9
cli(prompt): wip
evenstensberg 74fb759
fix(monorepo): fix lint errors
sendilkumarn 0fcc5b3
fix(monorepo): fix cross spawn versions
sendilkumarn ca8f5c1
fix(monorepo): update lock files
sendilkumarn 2b3035c
fix(monorepo): fix versions in pacakges
sendilkumarn b02070d
chore(rebase): refactor stuff
evenstensberg b2c2bbd
cli(pkgs): re-add entries
evenstensberg ab38a3a
chore(v): revise pkg
evenstensberg faae7aa
v0.0.1
evenstensberg c36f3e8
chore(v): revise some deps
evenstensberg 91be3fd
v0.0.2
evenstensberg b51e66d
v0.0.3
evenstensberg 3ed29c6
chore(v): back to v1
evenstensberg 6489b10
v0.0.2
evenstensberg 01cef3f
v0.0.3
evenstensberg e29a173
v0.0.4
evenstensberg 58a437d
chore(deps): update deps
evenstensberg bccc56e
chore(prompt): revise prompt cmd
evenstensberg 062fa28
v0.0.5
evenstensberg 7fca948
cli(path): resolve better
evenstensberg f544578
v0.0.6
evenstensberg ebe5c6b
chore(v.6): update init
evenstensberg 3a82b7d
chore(pkg): v.6 on next
evenstensberg 17c2c88
chore(monorepo): add bootstrap to run
sendilkumarn 42468d3
chore(monorepo): fix appveyor build
sendilkumarn a08b899
chore(monorepo): fix appveyor build
sendilkumarn ae55183
chore(monorepo): add eslint-plugin-prettier
sendilkumarn 206749b
chore(monorepo): fix appveyor build
sendilkumarn 7de58ea
chore(monorepo): fix versions and use clean bootstrap
sendilkumarn 7c0e245
chore(monorepo): add rimraf globally
sendilkumarn 2be0bce
Merge branch 'next' of https://github.com/webpack/webpack-cli into next
evenstensberg 8c58d24
chore(monorepo): fix windows build
sendilkumarn e87fd7d
cli(color): don't use color on non-tty (#452)
evenstensberg 0989b1d
Added yarn lock file to gitignore (#455)
nveenjain 78b48a6
chore(next): dev version bump
evenstensberg 0310fd3
chore(monorepo): fix windows build
sendilkumarn 217670f
cli(symlinks): Fix paths (#453)
evenstensberg 8e48e37
cli(init): Better defaults (#451)
evenstensberg 92816e1
fix(vulnerabilities): vulnerabilities patch for v3 (#460)
dhruvdutt 3dc8458
tests(parser): fix recursive-tests signature (#470)
dhruvdutt 0c9b942
chore(rebase): rebase against master
evenstensberg 4153395
Merge branch 'master' of https://github.com/webpack/webpack-cli into …
evenstensberg a7d8085
chore(deps): add lerna
evenstensberg 49ec223
tests(coverage): fix coverage (#473)
evenstensberg 3aa96ce
tests(cov): use regular nyc on tests
evenstensberg 467c217
Merge branch 'master' into next
evenstensberg 0b024bf
chore(lockfile): update pkglock
evenstensberg 372a90e
chore(semantic): configure plugins (#475)
evenstensberg 9475b17
fix(cli): show help flag when defaults fail (#466)
sumit-gupta91 7be10d8
tests(no-options): refactor tests
evenstensberg 7490caa
ast(parser): add (#456)
dhruvdutt bf78411
cli(add): re-add add command
evenstensberg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,16 +8,16 @@ Before writing a `webpack-cli` scaffold, think about what you're trying to achie | |
|
||
`webpack-cli` offers an experience that is interactive and you can prompt users for questions (like, "What is your entry point?") to help customize the output accordingly. | ||
|
||
## webpack-addons | ||
## webpack-scaffold | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't have Have you got one already? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's scoped, so it's ours, right? |
||
|
||
[`webpack-addons`](https://github.com/webpack-contrib/webpack-addons) is a utility suite for creating addons. It contains functions that could be of use for creating an addon yourself. | ||
`webpack-scaffold` is a utility suite for creating addons. It contains functions that could be of use for creating an addon yourself. | ||
|
||
## webpack-addons-yourpackage | ||
## webpack-scaffold-yourpackage | ||
|
||
In order for `webpack-cli` to compile your package, it must be available on npm or on your local filesystem. If you are curious about how you can create your very own `addon`, please read [How do I compose a | ||
webpack-addon?](https://github.com/ev1stensberg/webpack-addons-demo). | ||
In order for `webpack-cli` to compile your package, it must be available on npm or on your local filesystem. If you are curious about how you can create your very own `scaffold`, please read [How do I compose a | ||
webpack-addon?](https://github.com/ev1stensberg/webpack-scaffold-demo). | ||
|
||
If the package is on npm, its name must have a prefix of `webpack-addons`. | ||
If the package is on npm, its name must have a prefix of `webpack-scaffold`. | ||
|
||
If the package is on your local filesystem, it can be named whatever you want. Pass the path to the package. | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we facing issues with
npm ci
? Also, if we're doingnpm i
then we probably don't need to runnpm ci
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just people not updating package-locks, it's a safeguard.