Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: webpack-cli v3 #448

Merged
merged 75 commits into from
Jun 2, 2018
Merged

BREAKING: webpack-cli v3 #448

merged 75 commits into from
Jun 2, 2018

Conversation

evenstensberg
Copy link
Member

@evenstensberg evenstensberg commented May 14, 2018

No description provided.

sendilkumarn and others added 15 commits March 18, 2018 21:53
* fix(loader,plugin): fix generators path bug

* cli(refactor): improve folder structure (#371)

* cli(refactor): improve folder structure

* chore(linting): fix linter errors

* cli(filepath): use local import instead

* cli(migrate): refactor error handling

* chore(review): fix review comments

* chore(review): fix review comments

* chore(review): fix review comments

* chore(version): v.2.0.14

* Add break as commit type and listed the type of commit in the documentation (#379)

* docs(commits): listed the list of type of commits available

* cli(init): mode support to config (#364)

* cli(init): mode support to config

* cli(bugfix): Allow mode "none" in CLI (#381)

* cli(init): use extractMiniCSSPlugin (#363)

* cli(init): skip redundant question

* cli(init): use mini-css-extract-plugin

* Retrieve information for CLI option from webpack schema options file (#392)

* cli(refactor): fetch available modes directly from webpack options schema

* cli(refactor): Retrieve information from webpackOptionSchema

* cli(add): write configuration to yeoman file (#348)

* misc(add): variable parity, prettify

* cli(add): write config to yeoman-rc

* misc(add): improve generator questions

* fix(init): output file name for single output (#403)

improved output filename

* cli(migrate): Update migration question (#402)

* cli(init): webpack4 ready (#356)

* cli(init): webpack4 ready

* cli(init): remove unused variable, still @next on etwp

* cli(init): Allow to use default entry in `init`

* cli(init): Fix typo in comment

* cli(init): Optimization transform and tests

* cli(init): Fix non-optimized option for splitChunks

* cli(init): Add cachingGroup per entry, don't show name in prod

* cli(init): Add cachingGroup's defaults, fix entry

* cli(init): Add a link to where the defaults live

* cli(init): Remove default caching group definition from example

* Add NoEmitOnErrorsPlugin transformation (#399)

* ast(migrate): handle no emit on error

* ast(migrate): handle module concatenation and named modules

* ast(migrate): handle module concatenation and named modules

* fix(ast): checks validity of an identifier (#360)

added test cases for validate identifier

* cli(entry): quotes sanitization (#337)

* chore: minor doc fixes

* cli(entry): quotes sanitization

* tests(entry): add test case for double quotes

* tests(entry): update snapshots

* misc(utils): entry - variable parity

* misc(prop-types): sort

* cli(entry): multiple entries quotes sanitization

* chore(versioning): v 2.0.15

* chore(versioning): push new package version

* cli(fix): remove reference to specific version during migration (#410)

* fix: remove reference to specific version during migration

* fix: rephrase update message

* chore(docs): updated old references to the extract text plugin (#412)

* chore(dev): added break to the list of type of commit

* init(fix): removed references to extract text plugin

* fix(commit): rollback

* cli(migration): update UglifyJS transformation (#416)

* cli(migration): Update UglifyJS migration file to fit webpack4 configuration

* cli(migration): Add cases where require variable does not need to exist

* cli(migration): Add transformation for usage of webpack.otimization.UglifyPlugin

* cli(tests): Update test snapshots after updating transformation

* cli(fix): fix expressionContent being null

* cli(refactor): remove plugins array if empty

Created function on ast-utils so every other transformation can use this.

* tests: add tests for new ast-utils method

* fix: fix test names and jsdoc

* fix: update maxSize for utils folder

* ast(cli): Recursively parse AST (#341)

* ast(refactor): wip refactor

* ast(refactor): wip refactor

* ast(init): refactor

* test(refactor): refactor test suite

* tests(define): swap args

* ast(parsing): refactor stuff

* ast(init): refactor

* ast(init): refactor tests

* chore(tests): remove some unneeded tests

* chore(pkg): update package.json

* chore(project): clear up project structure

* chore(cli): remove unneded files

* chore(git): add gitignore to yeoman file

* chore(deps): update pkg.json

* tests(snapshots): update snapshots

* tests(jest): use empty module for snapshots

* tests(snap): only test one prop

* chore(publishing): add semantic-release (#415)

* chore(release): [WIP] add semantic-release

* test(ci): wip

* test(ci): add node versions

* test(ci): remove extra test

* tests(ci): revise

* tests(ci): only push to npm on master

* tests(ci): use matrix on jobs

* tests(ci): revise

* tests(ci): update

* tests(ci): test

* tests(ci): test

* tests(ci): p

* tests(ci): update travis.yml

* chore(release): revise travis

* misc(yeoman): update yeoman

* chore(travis): revise travis

* misc(travis): revise travis.yml

* chore(travis): remove redundant code

* chore(pkg): add keywords

* 2.1.1

* 2.1.2

* cli(cmds): revise yargs command (#422)

* use yargs.command instead of yargs.option for sub-commands

* cli(node): Add node flags to CLI (#377)

* feat: add support for node flags

* tests: Fix node-flags test

* misc: Fix test failing due to not-found webpack-cli

* misc: remove comment

* misc: refactor removing unecessary args

* tests: add more tests to prevent argument collision

* cli(cmds): remove strict

* fix(node): remove node option for now

* chore(lerna): refactor

* chore(lerna): refactor

* chore(refactor): refactor stuff

* chore(package): update pkg.lock

* chore(templates): Update issue templates (#432)

Adds fancy templates

* ast(init): add topScope prop

* ast(merge): re-add merge prop

* cli(lerna): refactor

* chore(lerna): refactor

* chore(lerna): update

* chore(lint): revise

* chore(refactor): refactor

* chore(tests): use lerna for tests

* chore(travis): don't cache me outside

* chore(pkg): remove prefer global

* chore(release): v.2.1.3

* chore(package.lock): update pkg.lock

* fix(loader,plugin): fix generators path bug

* chore(version): v.2.0.14

* Add break as commit type and listed the type of commit in the documentation (#379)

* docs(commits): listed the list of type of commits available

* cli(bugfix): Allow mode "none" in CLI (#381)

* cli(init): use extractMiniCSSPlugin (#363)

* cli(init): skip redundant question

* cli(init): use mini-css-extract-plugin

* Retrieve information for CLI option from webpack schema options file (#392)

* cli(refactor): fetch available modes directly from webpack options schema

* cli(refactor): Retrieve information from webpackOptionSchema

* cli(add): write configuration to yeoman file (#348)

* misc(add): variable parity, prettify

* cli(add): write config to yeoman-rc

* misc(add): improve generator questions

* fix(init): output file name for single output (#403)

improved output filename

* cli(migrate): Update migration question (#402)

* fix(ast): checks validity of an identifier (#360)

added test cases for validate identifier

* chore(versioning): v 2.0.15

* chore(versioning): push new package version

* cli(fix): remove reference to specific version during migration (#410)

* fix: remove reference to specific version during migration

* fix: rephrase update message

* chore(docs): updated old references to the extract text plugin (#412)

* chore(dev): added break to the list of type of commit

* init(fix): removed references to extract text plugin

* fix(commit): rollback

* misc(yeoman): update yeoman

* cli(cmds): revise yargs command (#422)

* use yargs.command instead of yargs.option for sub-commands

* cli(node): Add node flags to CLI (#377)

* feat: add support for node flags

* tests: Fix node-flags test

* misc: Fix test failing due to not-found webpack-cli

* misc: remove comment

* misc: refactor removing unecessary args

* tests: add more tests to prevent argument collision

* cli(cmds): remove strict

* fix(node): remove node option for now

* chore(templates): Update issue templates (#432)

Adds fancy templates

* cli(lerna): refactor

* chore(lerna): refactor

* chore(pkg): remove prefer global

* chore(travis): Add encrypted private ssh key

* fix(pkg): test auto setup

* cli(init): revise installation steps (#441)

* cli(init): revise installation steps

* chore(formatting): format code

* cli(tests): refactor tests

* chore(travis): run lockfile cmds on tests (#444)

* Update dependencies to enable Greenkeeper 🌴 (#443)

chore(greenkeeper): Update dependencies to enable Greenkeeper 🌴

* chore(docs): update readme

* chore(travis): add Node.js 10 (#425)

* chore(travis): move npm ci to install task (#424)

* chore(travis): move npm ci to install task

* chore: trigger new build

* chore: upgrade Node.js for Appveyor to 8

* chore: remove redundanct npm install command
@ematipico ematipico added the Semver: major 💣 When delivering a new feature that breaks or a complete revamp of the internals label May 15, 2018
evenstensberg and others added 17 commits May 19, 2018 19:49
* cli(symlinks): fix symlinks

* chore(linting): resolve linting errors

* chore(rebase): remove old file
* cli(init): set default generator name

* cli(init): better defaults

* chore(rebase): remove old commit

* cli(init): fix broken ast and merge scaffolds

* chore(docs): better defaults

* chore(lint): fix linting errors

* chore(deps): remove path from dep installation

* chore(resolve): resolve conflicts
* chore(dependencies): fix vulnerabilities

* misc(scripts): update clean:all script

* chore(dependencies): fix vulnerabilities
* test(coverage): fix coverage

* test(binTestCases): run bintestcases on upper-repo

* tests(travis): add node 10
@evenstensberg
Copy link
Member Author

@sendilkumarn how's that Addon looking?

@@ -13,6 +13,7 @@ build: off
install:
- ps: Install-Product node $env:nodejs_version $env:platform
- npm i -g npm
- npm i
- npm ci
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we facing issues with npm ci? Also, if we're doing npm i then we probably don't need to run npm ci.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just people not updating package-locks, it's a safeguard.

evenstensberg and others added 5 commits June 2, 2018 02:02
* fixed test cases

* remove unwanted console

* fix(254) - addressed PR comments

* fix(254) - added requested changes at right place

* fix(254) - exit after error

exit webpack if defaults are not found
fix test cases for no options

* fix: require chalk

* refactor - addressed PR comments

* refactor - addressed PR comments

* refactor : remove unwanted keywords

* chore(review): format
* ast(parser): add, update, remove - literal node support

* ast(parser): add command

* ast(util): update property, early exit

* tests(add): resursive add ast

* tests(add): update recursive parser snaps

* misc(conflicts): resolve conflicts

* tests(parser): update tests, inputs

* chore(review): fix some things

* ast(utils): add ast-path safe traverse and type support

* ast(utils): merge update property with add property

* tests(ast): add tests for safe traversals

* misc(fixes): review comments

* tests(ast): add tests for addProperty

* misc(fixes): review comments

* misc(fixes): review comments

* misc(fixes): review comments
@evenstensberg evenstensberg changed the title chore(versioning): webpack-cli v3 BREAKING: webpack-cli v3 Jun 2, 2018
@evenstensberg evenstensberg merged commit 138adfd into master Jun 2, 2018
@xPaw
Copy link

xPaw commented Jun 3, 2018

Where is the changelog for v3? You just released 3.0.0 and 3.0.1 without any changelog. Title of this PR has BREAKING, but what is it breaking?

@evenstensberg
Copy link
Member Author

https://medium.com/webpack/were-rolling-out-webpack-cli-v-3-996e1ca48069
Seems like our auto release didn't make a changelog, since we squashed the PR for v3. There's no breaking changes if you're using webpack without any features like init migrate etc.

v2.1.5...v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: unreviewed Semver: major 💣 When delivering a new feature that breaks or a complete revamp of the internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants