fix: checks validity of an identifier #360

anu-007 · 2018-03-20T23:33:10Z

What kind of change does this PR introduce?
bugfix - adds a check for validity of an identifier

Did you add tests for your changes?
No
If relevant, did you update the documentation?
generateIdentifierRegex is based on this article. A similar implementation can be seen in esprima link.
Summary
generateIdentifierRegex generates a long regex for invalid keywords which is then checked in ast-util.js.

Does this PR introduce a breaking change?
No

Other information
No

evenstensberg

Thank you so much! Could you remove yarn.lock ?

anu-007 · 2018-03-21T08:18:30Z

@ev1stensberg sorry, I accidentally commit yarn.lock. By using this method i.e. generating a regex every time a related test run takes a huge amount of time (see Travis logs) that is why builds are failing. can you guide me what should I do here, to make build pass successfully? Thanks !!

evenstensberg · 2018-03-21T08:54:48Z

Hm, this is weird. Checking in on this later!

ematipico · 2018-03-21T12:48:10Z

package.json

@@ -93,11 +93,13 @@
    "listr": "^0.13.0",
    "loader-utils": "^1.1.0",
    "lodash": "^4.17.5",
+    "lodash.template": "^4.4.0",


We already have lodash installed, so there's no need install lodash.template
You could do (just a suggestion, there are tons of way)

const template = require('lodash/template');

ematipico · 2018-03-21T12:49:53Z

lib/utils/generate-identifier-regex.js

+const template = require("lodash.template");
+
+// Which Unicode version should be used?
+const version = "10.0.0";


version => UNICODE_VERSION
The name version is too generic

ematipico · 2018-03-21T12:50:49Z

lib/utils/generate-identifier-regex.js

+};
+
+// Get the Unicode properties needed to construct the ES6 regex.
+const ID_Start = get("Binary_Property/ID_Start");


We use camelCase as naming convention, could rename please?

ooflorent · 2018-03-21T13:11:41Z

lib/utils/generate-identifier-regex.js

@@ -0,0 +1,55 @@
+const regenerate = require("regenerate");
+const template = require("lodash.template");


The following would be better:

const template = require("lodash/template")

ooflorent · 2018-03-21T13:13:08Z

lib/utils/ast-utils.js

@@ -149,8 +150,8 @@ function createIdentifierOrLiteral(j, val) {
 			return createExternalRegExp(j, val);
 		} else {
 			// Use identifier instead
-			// TODO: Check if literalVal is a valid Identifier!
-			return j.identifier(literalVal);
+			if (!literalVal.match(generateIdentifierRegex()))


The regex will be generated each time this branch is visited. Maybe we could generate it upfront?

@ooflorent the generated regex is 14971 characters long and it is not a good practice to use such a huge regex directly also esprima, Acorn etc. validates identifier this way hence I thought it will be right to do not use it directly as it will be difficult to debug and modify codinghorror blog mentioned it. Apart from this, I have replaced match with test to increase the performance but still, it takes too much time and the build fails.Thanks !!

ooflorent · 2018-03-21T13:13:31Z

lib/utils/generate-identifier-regex.js

+const compileRegex = template("/^(?!(?:<%= reservedWords %>)$)" +
+	"(?:<%= identifierStart %>)(?:<%= identifierPart %>)*$/");
+
+module.exports = function generateES6Regex() {


Could you rename this to generateIdentifierRegex please?

webpack-bot · 2018-04-08T00:52:39Z

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

anu-007 · 2018-04-08T01:02:14Z

@ev1stensberg I modified the script and drop the use of regexp which cause the slowing down of validation (due to its large size) I have tried to optimize it but still, it takes too much time. The new implementation is based on the way esprima, acorn, babel do it.Thanks !!

ematipico

I wonder if there's a chance to have some unit test for the utility functions that you added? It would also helpful to show a simple usage to people

evenstensberg · 2018-04-10T13:08:27Z

@ematipico PTAL

anu-007 · 2018-04-10T17:02:21Z

sorry for the delay @ev1stensberg but before merging this PR let me add some unit tests as @ematipico suggested. I will add them ASAP. Thanks !!

evenstensberg · 2018-04-11T08:22:55Z

Yh that would be good :')

added test cases for validate identifier

webpack-bot · 2018-04-11T12:51:44Z

@anu-007 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@dhruvdutt Please review the new changes.

anu-007 · 2018-04-11T13:02:27Z

@ev1stensberg @ematipico I have added few unit tests, please let me know if more tests are required.Thanks !!

evenstensberg · 2018-04-13T08:36:46Z

@ematipico PTAL

ematipico

Amazing job! Thanks!

added test cases for validate identifier

* fix(loader,plugin): fix generators path bug * cli(refactor): improve folder structure (#371) * cli(refactor): improve folder structure * chore(linting): fix linter errors * cli(filepath): use local import instead * cli(migrate): refactor error handling * chore(review): fix review comments * chore(review): fix review comments * chore(review): fix review comments * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(init): mode support to config (#364) * cli(init): mode support to config * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * cli(init): webpack4 ready (#356) * cli(init): webpack4 ready * cli(init): remove unused variable, still @next on etwp * cli(init): Allow to use default entry in `init` * cli(init): Fix typo in comment * cli(init): Optimization transform and tests * cli(init): Fix non-optimized option for splitChunks * cli(init): Add cachingGroup per entry, don't show name in prod * cli(init): Add cachingGroup's defaults, fix entry * cli(init): Add a link to where the defaults live * cli(init): Remove default caching group definition from example * Add NoEmitOnErrorsPlugin transformation (#399) * ast(migrate): handle no emit on error * ast(migrate): handle module concatenation and named modules * ast(migrate): handle module concatenation and named modules * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * cli(entry): quotes sanitization (#337) * chore: minor doc fixes * cli(entry): quotes sanitization * tests(entry): add test case for double quotes * tests(entry): update snapshots * misc(utils): entry - variable parity * misc(prop-types): sort * cli(entry): multiple entries quotes sanitization * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * cli(migration): update UglifyJS transformation (#416) * cli(migration): Update UglifyJS migration file to fit webpack4 configuration * cli(migration): Add cases where require variable does not need to exist * cli(migration): Add transformation for usage of webpack.otimization.UglifyPlugin * cli(tests): Update test snapshots after updating transformation * cli(fix): fix expressionContent being null * cli(refactor): remove plugins array if empty Created function on ast-utils so every other transformation can use this. * tests: add tests for new ast-utils method * fix: fix test names and jsdoc * fix: update maxSize for utils folder * ast(cli): Recursively parse AST (#341) * ast(refactor): wip refactor * ast(refactor): wip refactor * ast(init): refactor * test(refactor): refactor test suite * tests(define): swap args * ast(parsing): refactor stuff * ast(init): refactor * ast(init): refactor tests * chore(tests): remove some unneeded tests * chore(pkg): update package.json * chore(project): clear up project structure * chore(cli): remove unneded files * chore(git): add gitignore to yeoman file * chore(deps): update pkg.json * tests(snapshots): update snapshots * tests(jest): use empty module for snapshots * tests(snap): only test one prop * chore(publishing): add semantic-release (#415) * chore(release): [WIP] add semantic-release * test(ci): wip * test(ci): add node versions * test(ci): remove extra test * tests(ci): revise * tests(ci): only push to npm on master * tests(ci): use matrix on jobs * tests(ci): revise * tests(ci): update * tests(ci): test * tests(ci): test * tests(ci): p * tests(ci): update travis.yml * chore(release): revise travis * misc(yeoman): update yeoman * chore(travis): revise travis * misc(travis): revise travis.yml * chore(travis): remove redundant code * chore(pkg): add keywords * 2.1.1 * 2.1.2 * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(lerna): refactor * chore(lerna): refactor * chore(refactor): refactor stuff * chore(package): update pkg.lock * chore(templates): Update issue templates (#432) Adds fancy templates * ast(init): add topScope prop * ast(merge): re-add merge prop * cli(lerna): refactor * chore(lerna): refactor * chore(lerna): update * chore(lint): revise * chore(refactor): refactor * chore(tests): use lerna for tests * chore(travis): don't cache me outside * chore(pkg): remove prefer global * chore(release): v.2.1.3 * chore(package.lock): update pkg.lock * fix(loader,plugin): fix generators path bug * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * misc(yeoman): update yeoman * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(templates): Update issue templates (#432) Adds fancy templates * cli(lerna): refactor * chore(lerna): refactor * chore(pkg): remove prefer global * chore(travis): Add encrypted private ssh key * fix(pkg): test auto setup * cli(init): revise installation steps (#441) * cli(init): revise installation steps * chore(formatting): format code * cli(tests): refactor tests * chore(travis): run lockfile cmds on tests (#444) * Update dependencies to enable Greenkeeper 🌴 (#443) chore(greenkeeper): Update dependencies to enable Greenkeeper 🌴 * chore(docs): update readme * chore(travis): add Node.js 10 (#425) * chore(travis): move npm ci to install task (#424) * chore(travis): move npm ci to install task * chore: trigger new build * chore: upgrade Node.js for Appveyor to 8 * chore: remove redundanct npm install command

* chore(monorepo): move to lerna * chore(monorepo): use commands as normal instead of package * fix(revert): packagejson * chore(monorepo): prune files and update eslint rules * chore(monorepo): fix the no-missing-require error * chore(monorepo): fix typo * chore(monorepo): fix typo * chore(monorepo): prune package json * chore(monorepo): merge package lock json * chore(monorepo): updated package.json * chore(monorepo): fix plugin package.json * chore(cli): move to lerna and scoped packages (#434) * fix(loader,plugin): fix generators path bug * cli(refactor): improve folder structure (#371) * cli(refactor): improve folder structure * chore(linting): fix linter errors * cli(filepath): use local import instead * cli(migrate): refactor error handling * chore(review): fix review comments * chore(review): fix review comments * chore(review): fix review comments * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(init): mode support to config (#364) * cli(init): mode support to config * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * cli(init): webpack4 ready (#356) * cli(init): webpack4 ready * cli(init): remove unused variable, still @next on etwp * cli(init): Allow to use default entry in `init` * cli(init): Fix typo in comment * cli(init): Optimization transform and tests * cli(init): Fix non-optimized option for splitChunks * cli(init): Add cachingGroup per entry, don't show name in prod * cli(init): Add cachingGroup's defaults, fix entry * cli(init): Add a link to where the defaults live * cli(init): Remove default caching group definition from example * Add NoEmitOnErrorsPlugin transformation (#399) * ast(migrate): handle no emit on error * ast(migrate): handle module concatenation and named modules * ast(migrate): handle module concatenation and named modules * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * cli(entry): quotes sanitization (#337) * chore: minor doc fixes * cli(entry): quotes sanitization * tests(entry): add test case for double quotes * tests(entry): update snapshots * misc(utils): entry - variable parity * misc(prop-types): sort * cli(entry): multiple entries quotes sanitization * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * cli(migration): update UglifyJS transformation (#416) * cli(migration): Update UglifyJS migration file to fit webpack4 configuration * cli(migration): Add cases where require variable does not need to exist * cli(migration): Add transformation for usage of webpack.otimization.UglifyPlugin * cli(tests): Update test snapshots after updating transformation * cli(fix): fix expressionContent being null * cli(refactor): remove plugins array if empty Created function on ast-utils so every other transformation can use this. * tests: add tests for new ast-utils method * fix: fix test names and jsdoc * fix: update maxSize for utils folder * ast(cli): Recursively parse AST (#341) * ast(refactor): wip refactor * ast(refactor): wip refactor * ast(init): refactor * test(refactor): refactor test suite * tests(define): swap args * ast(parsing): refactor stuff * ast(init): refactor * ast(init): refactor tests * chore(tests): remove some unneeded tests * chore(pkg): update package.json * chore(project): clear up project structure * chore(cli): remove unneded files * chore(git): add gitignore to yeoman file * chore(deps): update pkg.json * tests(snapshots): update snapshots * tests(jest): use empty module for snapshots * tests(snap): only test one prop * chore(publishing): add semantic-release (#415) * chore(release): [WIP] add semantic-release * test(ci): wip * test(ci): add node versions * test(ci): remove extra test * tests(ci): revise * tests(ci): only push to npm on master * tests(ci): use matrix on jobs * tests(ci): revise * tests(ci): update * tests(ci): test * tests(ci): test * tests(ci): p * tests(ci): update travis.yml * chore(release): revise travis * misc(yeoman): update yeoman * chore(travis): revise travis * misc(travis): revise travis.yml * chore(travis): remove redundant code * chore(pkg): add keywords * 2.1.1 * 2.1.2 * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(lerna): refactor * chore(lerna): refactor * chore(refactor): refactor stuff * chore(package): update pkg.lock * chore(templates): Update issue templates (#432) Adds fancy templates * ast(init): add topScope prop * ast(merge): re-add merge prop * cli(lerna): refactor * chore(lerna): refactor * chore(lerna): update * chore(lint): revise * chore(refactor): refactor * chore(tests): use lerna for tests * chore(travis): don't cache me outside * chore(pkg): remove prefer global * chore(release): v.2.1.3 * chore(package.lock): update pkg.lock * fix(loader,plugin): fix generators path bug * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * misc(yeoman): update yeoman * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(templates): Update issue templates (#432) Adds fancy templates * cli(lerna): refactor * chore(lerna): refactor * chore(pkg): remove prefer global * chore(travis): Add encrypted private ssh key * fix(pkg): test auto setup * cli(init): revise installation steps (#441) * cli(init): revise installation steps * chore(formatting): format code * cli(tests): refactor tests * chore(travis): run lockfile cmds on tests (#444) * Update dependencies to enable Greenkeeper 🌴 (#443) chore(greenkeeper): Update dependencies to enable Greenkeeper 🌴 * chore(docs): update readme * chore(travis): add Node.js 10 (#425) * chore(travis): move npm ci to install task (#424) * chore(travis): move npm ci to install task * chore: trigger new build * chore: upgrade Node.js for Appveyor to 8 * chore: remove redundanct npm install command * chore(linting): resolve linter errors * chore(linting): fix linting errors * chore(linting): resolve linting * chore(linting): resolve linting * chore(scaffold): move addons to scaffold * chore(scaffold): fix linting errors * cli(prompt): initial comment for prompt file * cli(prompt): wip * fix(monorepo): fix lint errors * fix(monorepo): fix cross spawn versions * fix(monorepo): update lock files * fix(monorepo): fix versions in pacakges * chore(rebase): refactor stuff * cli(pkgs): re-add entries * chore(v): revise pkg * v0.0.1 * chore(v): revise some deps * v0.0.2 * v0.0.3 * chore(v): back to v1 * v0.0.2 * v0.0.3 * v0.0.4 * chore(deps): update deps * chore(prompt): revise prompt cmd * v0.0.5 * cli(path): resolve better * v0.0.6 * chore(v.6): update init * chore(pkg): v.6 on next * chore(monorepo): add bootstrap to run chore(monorepo): add bootstrap to ci * chore(monorepo): fix appveyor build * chore(monorepo): fix appveyor build * chore(monorepo): add eslint-plugin-prettier * chore(monorepo): fix appveyor build chore(monorepo): fix appveyor build chore(monorepo): add eslint-plugin-prettier chore(monorepo): use nohoist * chore(monorepo): fix versions and use clean bootstrap * chore(monorepo): add rimraf globally chore(monorepo): revert back * chore(monorepo): fix windows build * cli(color): don't use color on non-tty (#452) * Added yarn lock file to gitignore (#455) * chore(next): dev version bump * chore(monorepo): fix windows build * cli(symlinks): Fix paths (#453) * cli(symlinks): fix symlinks * chore(linting): resolve linting errors * chore(rebase): remove old file * cli(init): Better defaults (#451) * cli(init): set default generator name * cli(init): better defaults * chore(rebase): remove old commit * cli(init): fix broken ast and merge scaffolds * chore(docs): better defaults * chore(lint): fix linting errors * chore(deps): remove path from dep installation * chore(resolve): resolve conflicts * fix(vulnerabilities): vulnerabilities patch for v3 (#460) * chore(dependencies): fix vulnerabilities * misc(scripts): update clean:all script * chore(dependencies): fix vulnerabilities * tests(parser): fix recursive-tests signature (#470) * chore(deps): add lerna * tests(coverage): fix coverage (#473) * test(coverage): fix coverage * test(binTestCases): run bintestcases on upper-repo * tests(travis): add node 10 * tests(cov): use regular nyc on tests * chore(lockfile): update pkglock * chore(semantic): configure plugins (#475) * fix(cli): show help flag when defaults fail (#466) * fixed test cases * remove unwanted console * fix(254) - addressed PR comments * fix(254) - added requested changes at right place * fix(254) - exit after error exit webpack if defaults are not found fix test cases for no options * fix: require chalk * refactor - addressed PR comments * refactor - addressed PR comments * refactor : remove unwanted keywords * chore(review): format * tests(no-options): refactor tests * ast(parser): add (#456) * ast(parser): add, update, remove - literal node support * ast(parser): add command * ast(util): update property, early exit * tests(add): resursive add ast * tests(add): update recursive parser snaps * misc(conflicts): resolve conflicts * tests(parser): update tests, inputs * chore(review): fix some things * ast(utils): add ast-path safe traverse and type support * ast(utils): merge update property with add property * tests(ast): add tests for safe traversals * misc(fixes): review comments * tests(ast): add tests for addProperty * misc(fixes): review comments * misc(fixes): review comments * misc(fixes): review comments * cli(add): re-add add command

webpack-bot added PR: unreviewed PR: CI-not-ok labels Mar 20, 2018

evenstensberg requested changes Mar 21, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Mar 21, 2018

anu-007 force-pushed the rgx branch from 05accf8 to cfc581e Compare March 21, 2018 08:06

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Mar 21, 2018

ematipico suggested changes Mar 21, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: review-outdated labels Mar 21, 2018

ooflorent reviewed Mar 21, 2018

View reviewed changes

webpack-bot added PR: conflict and removed PR: CI-not-ok labels Mar 23, 2018

anu-007 force-pushed the rgx branch from cfc581e to 65a00e5 Compare March 28, 2018 20:39

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels Mar 28, 2018

anu-007 force-pushed the rgx branch from 65a00e5 to 39261d0 Compare March 28, 2018 21:18

webpack-bot added PR: CI-not-ok and removed PR: conflict labels Mar 28, 2018

anu-007 force-pushed the rgx branch from 39261d0 to 6ff2ad2 Compare March 31, 2018 11:57

anu-007 force-pushed the rgx branch 2 times, most recently from 486eff4 to 9d44f38 Compare April 8, 2018 00:44

webpack-bot added PR: CI-ok and removed PR: CI-not-ok labels Apr 8, 2018

ematipico approved these changes Apr 9, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Apr 9, 2018

ematipico suggested changes Apr 9, 2018

View reviewed changes

webpack-bot added the PR: reviewed-changes-requested label Apr 9, 2018

ematipico added the Semver: patch 🔧 Usually for bugfixes label Apr 9, 2018

evenstensberg approved these changes Apr 10, 2018

View reviewed changes

dhruvdutt approved these changes Apr 10, 2018

View reviewed changes

fix: checks validity of an identifier

12e07fb

added test cases for validate identifier

anu-007 force-pushed the rgx branch from 9d44f38 to 12e07fb Compare April 11, 2018 12:51

webpack-bot added PR: review-outdated and removed PR: reviewed-approved PR: reviewed-changes-requested labels Apr 11, 2018

ematipico approved these changes Apr 15, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Apr 15, 2018

ematipico merged commit f42bdbd into webpack:master Apr 15, 2018

evenstensberg pushed a commit that referenced this pull request May 7, 2018

fix(ast): checks validity of an identifier (#360)

cbee92c

added test cases for validate identifier

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: checks validity of an identifier #360

fix: checks validity of an identifier #360

anu-007 commented Mar 20, 2018

evenstensberg left a comment

anu-007 commented Mar 21, 2018

evenstensberg commented Mar 21, 2018

ematipico Mar 21, 2018

ematipico Mar 21, 2018

ematipico Mar 21, 2018

ooflorent Mar 21, 2018

ooflorent Mar 21, 2018

anu-007 Mar 31, 2018

ooflorent Mar 21, 2018

webpack-bot commented Apr 8, 2018

anu-007 commented Apr 8, 2018 •

edited

Loading

ematipico left a comment •

edited

Loading

evenstensberg commented Apr 10, 2018

anu-007 commented Apr 10, 2018 •

edited

Loading

evenstensberg commented Apr 11, 2018

webpack-bot commented Apr 11, 2018

anu-007 commented Apr 11, 2018

evenstensberg commented Apr 13, 2018

ematipico left a comment

		@@ -0,0 +1,55 @@
		const regenerate = require("regenerate");
		const template = require("lodash.template");

fix: checks validity of an identifier #360

fix: checks validity of an identifier #360

Conversation

anu-007 commented Mar 20, 2018

evenstensberg left a comment

Choose a reason for hiding this comment

anu-007 commented Mar 21, 2018

evenstensberg commented Mar 21, 2018

ematipico Mar 21, 2018

Choose a reason for hiding this comment

ematipico Mar 21, 2018

Choose a reason for hiding this comment

ematipico Mar 21, 2018

Choose a reason for hiding this comment

ooflorent Mar 21, 2018

Choose a reason for hiding this comment

ooflorent Mar 21, 2018

Choose a reason for hiding this comment

anu-007 Mar 31, 2018

Choose a reason for hiding this comment

ooflorent Mar 21, 2018

Choose a reason for hiding this comment

webpack-bot commented Apr 8, 2018

anu-007 commented Apr 8, 2018 • edited Loading

ematipico left a comment • edited Loading

Choose a reason for hiding this comment

evenstensberg commented Apr 10, 2018

anu-007 commented Apr 10, 2018 • edited Loading

evenstensberg commented Apr 11, 2018

webpack-bot commented Apr 11, 2018

anu-007 commented Apr 11, 2018

evenstensberg commented Apr 13, 2018

ematipico left a comment

Choose a reason for hiding this comment

anu-007 commented Apr 8, 2018 •

edited

Loading

ematipico left a comment •

edited

Loading

anu-007 commented Apr 10, 2018 •

edited

Loading