fix(cli): show help flag when defaults fail #466

sumit-gupta91 · 2018-05-26T18:08:53Z

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?

Summary

#124

Does this PR introduce a breaking change?
No

Other information

exit webpack if defaults are not found fix test cases for no options

evenstensberg · 2018-05-28T13:09:04Z

bin/cli.js

@@ -4,6 +4,7 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
+const chalk = require("chalk");


We can't have chalk here. Leave it unstyled for now

evenstensberg · 2018-05-28T13:09:30Z

bin/cli.js

-								"\n" + " ERROR Insufficient number of arguments provided " +
-								"\n" + " INFO Alternatively, run `webpack(-cli) --help` for usage info." +
+								"\n" + chalk.blue("ERROR ") + "Insufficient number of arguments provided " +
+								"\n" + chalk.blue("INFO ") + "Alternatively, run `webpack(-cli) --help` for usage info." +
 								"\n\n"
 							);
 							process.exit(0);


I don't think we should exit the process now as we've got no styling

sumit-gupta91 · 2018-05-30T08:21:11Z

@ev1stensberg have addressed the PR comments

evenstensberg

Thanks @sumit-gupta91 ! Left some comments!

evenstensberg · 2018-05-30T14:32:53Z

bin/cli.js

@@ -4,7 +4,6 @@
 	MIT License http://www.opensource.org/licenses/mit-license.php
 	Author Tobias Koppers @sokra
 */
-


No need to trim here

evenstensberg · 2018-05-30T14:33:08Z

bin/cli.js

+								"\n\n"
+							);
+						}
+					} else {


no need for an else statement here

evenstensberg · 2018-05-30T14:33:26Z

test/binCases/watch/single-config-watch-opt/stdin.js

@@ -4,7 +4,6 @@ module.exports = function testAssertions(stdout, stderr, done) {
 	expect(stdout).toEqual(expect.anything());
 	expect(stdout[0]).toContain("");
 	expect(stdout[1]).toContain("Webpack is watching the files…");
-


no need for trim here

webpack-bot · 2018-05-31T05:15:53Z

@sumit-gupta91 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ev1stensberg Please review the new changes.

evenstensberg · 2018-05-31T15:03:26Z

bin/cli.js

+						if (errors[0].name === "EntryModuleNotFoundError") {
+							stdout.write("\n" + errors[0].error.toString() + "\n");
+							stdout.write(
+								"\n" + "ERROR Insufficient number of arguments provided " +


Remove error and info. Let's have this format:

Can't resolve.... Insufficient args. alternatively run webpack...

evenstensberg · 2018-05-31T17:17:03Z

bin/cli.js

@@ -501,8 +501,8 @@ For more information, see https://webpack.js.org/api/cli/.`);
 						if (errors[0].name === "EntryModuleNotFoundError") {
 							stdout.write("\n" + errors[0].error.toString() + "\n");
 							stdout.write(
-								"\n" + "ERROR Insufficient number of arguments provided " +
-								"\n" + "INFO Alternatively, run `webpack(-cli) --help` for usage info." +
+								"\n" + "Insufficient number of arguments provided " +


You'll need to pad start and end block as well correctly

* chore(monorepo): move to lerna * chore(monorepo): use commands as normal instead of package * fix(revert): packagejson * chore(monorepo): prune files and update eslint rules * chore(monorepo): fix the no-missing-require error * chore(monorepo): fix typo * chore(monorepo): fix typo * chore(monorepo): prune package json * chore(monorepo): merge package lock json * chore(monorepo): updated package.json * chore(monorepo): fix plugin package.json * chore(cli): move to lerna and scoped packages (#434) * fix(loader,plugin): fix generators path bug * cli(refactor): improve folder structure (#371) * cli(refactor): improve folder structure * chore(linting): fix linter errors * cli(filepath): use local import instead * cli(migrate): refactor error handling * chore(review): fix review comments * chore(review): fix review comments * chore(review): fix review comments * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(init): mode support to config (#364) * cli(init): mode support to config * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * cli(init): webpack4 ready (#356) * cli(init): webpack4 ready * cli(init): remove unused variable, still @next on etwp * cli(init): Allow to use default entry in `init` * cli(init): Fix typo in comment * cli(init): Optimization transform and tests * cli(init): Fix non-optimized option for splitChunks * cli(init): Add cachingGroup per entry, don't show name in prod * cli(init): Add cachingGroup's defaults, fix entry * cli(init): Add a link to where the defaults live * cli(init): Remove default caching group definition from example * Add NoEmitOnErrorsPlugin transformation (#399) * ast(migrate): handle no emit on error * ast(migrate): handle module concatenation and named modules * ast(migrate): handle module concatenation and named modules * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * cli(entry): quotes sanitization (#337) * chore: minor doc fixes * cli(entry): quotes sanitization * tests(entry): add test case for double quotes * tests(entry): update snapshots * misc(utils): entry - variable parity * misc(prop-types): sort * cli(entry): multiple entries quotes sanitization * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * cli(migration): update UglifyJS transformation (#416) * cli(migration): Update UglifyJS migration file to fit webpack4 configuration * cli(migration): Add cases where require variable does not need to exist * cli(migration): Add transformation for usage of webpack.otimization.UglifyPlugin * cli(tests): Update test snapshots after updating transformation * cli(fix): fix expressionContent being null * cli(refactor): remove plugins array if empty Created function on ast-utils so every other transformation can use this. * tests: add tests for new ast-utils method * fix: fix test names and jsdoc * fix: update maxSize for utils folder * ast(cli): Recursively parse AST (#341) * ast(refactor): wip refactor * ast(refactor): wip refactor * ast(init): refactor * test(refactor): refactor test suite * tests(define): swap args * ast(parsing): refactor stuff * ast(init): refactor * ast(init): refactor tests * chore(tests): remove some unneeded tests * chore(pkg): update package.json * chore(project): clear up project structure * chore(cli): remove unneded files * chore(git): add gitignore to yeoman file * chore(deps): update pkg.json * tests(snapshots): update snapshots * tests(jest): use empty module for snapshots * tests(snap): only test one prop * chore(publishing): add semantic-release (#415) * chore(release): [WIP] add semantic-release * test(ci): wip * test(ci): add node versions * test(ci): remove extra test * tests(ci): revise * tests(ci): only push to npm on master * tests(ci): use matrix on jobs * tests(ci): revise * tests(ci): update * tests(ci): test * tests(ci): test * tests(ci): p * tests(ci): update travis.yml * chore(release): revise travis * misc(yeoman): update yeoman * chore(travis): revise travis * misc(travis): revise travis.yml * chore(travis): remove redundant code * chore(pkg): add keywords * 2.1.1 * 2.1.2 * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(lerna): refactor * chore(lerna): refactor * chore(refactor): refactor stuff * chore(package): update pkg.lock * chore(templates): Update issue templates (#432) Adds fancy templates * ast(init): add topScope prop * ast(merge): re-add merge prop * cli(lerna): refactor * chore(lerna): refactor * chore(lerna): update * chore(lint): revise * chore(refactor): refactor * chore(tests): use lerna for tests * chore(travis): don't cache me outside * chore(pkg): remove prefer global * chore(release): v.2.1.3 * chore(package.lock): update pkg.lock * fix(loader,plugin): fix generators path bug * chore(version): v.2.0.14 * Add break as commit type and listed the type of commit in the documentation (#379) * docs(commits): listed the list of type of commits available * cli(bugfix): Allow mode "none" in CLI (#381) * cli(init): use extractMiniCSSPlugin (#363) * cli(init): skip redundant question * cli(init): use mini-css-extract-plugin * Retrieve information for CLI option from webpack schema options file (#392) * cli(refactor): fetch available modes directly from webpack options schema * cli(refactor): Retrieve information from webpackOptionSchema * cli(add): write configuration to yeoman file (#348) * misc(add): variable parity, prettify * cli(add): write config to yeoman-rc * misc(add): improve generator questions * fix(init): output file name for single output (#403) improved output filename * cli(migrate): Update migration question (#402) * fix(ast): checks validity of an identifier (#360) added test cases for validate identifier * chore(versioning): v 2.0.15 * chore(versioning): push new package version * cli(fix): remove reference to specific version during migration (#410) * fix: remove reference to specific version during migration * fix: rephrase update message * chore(docs): updated old references to the extract text plugin (#412) * chore(dev): added break to the list of type of commit * init(fix): removed references to extract text plugin * fix(commit): rollback * misc(yeoman): update yeoman * cli(cmds): revise yargs command (#422) * use yargs.command instead of yargs.option for sub-commands * cli(node): Add node flags to CLI (#377) * feat: add support for node flags * tests: Fix node-flags test * misc: Fix test failing due to not-found webpack-cli * misc: remove comment * misc: refactor removing unecessary args * tests: add more tests to prevent argument collision * cli(cmds): remove strict * fix(node): remove node option for now * chore(templates): Update issue templates (#432) Adds fancy templates * cli(lerna): refactor * chore(lerna): refactor * chore(pkg): remove prefer global * chore(travis): Add encrypted private ssh key * fix(pkg): test auto setup * cli(init): revise installation steps (#441) * cli(init): revise installation steps * chore(formatting): format code * cli(tests): refactor tests * chore(travis): run lockfile cmds on tests (#444) * Update dependencies to enable Greenkeeper 🌴 (#443) chore(greenkeeper): Update dependencies to enable Greenkeeper 🌴 * chore(docs): update readme * chore(travis): add Node.js 10 (#425) * chore(travis): move npm ci to install task (#424) * chore(travis): move npm ci to install task * chore: trigger new build * chore: upgrade Node.js for Appveyor to 8 * chore: remove redundanct npm install command * chore(linting): resolve linter errors * chore(linting): fix linting errors * chore(linting): resolve linting * chore(linting): resolve linting * chore(scaffold): move addons to scaffold * chore(scaffold): fix linting errors * cli(prompt): initial comment for prompt file * cli(prompt): wip * fix(monorepo): fix lint errors * fix(monorepo): fix cross spawn versions * fix(monorepo): update lock files * fix(monorepo): fix versions in pacakges * chore(rebase): refactor stuff * cli(pkgs): re-add entries * chore(v): revise pkg * v0.0.1 * chore(v): revise some deps * v0.0.2 * v0.0.3 * chore(v): back to v1 * v0.0.2 * v0.0.3 * v0.0.4 * chore(deps): update deps * chore(prompt): revise prompt cmd * v0.0.5 * cli(path): resolve better * v0.0.6 * chore(v.6): update init * chore(pkg): v.6 on next * chore(monorepo): add bootstrap to run chore(monorepo): add bootstrap to ci * chore(monorepo): fix appveyor build * chore(monorepo): fix appveyor build * chore(monorepo): add eslint-plugin-prettier * chore(monorepo): fix appveyor build chore(monorepo): fix appveyor build chore(monorepo): add eslint-plugin-prettier chore(monorepo): use nohoist * chore(monorepo): fix versions and use clean bootstrap * chore(monorepo): add rimraf globally chore(monorepo): revert back * chore(monorepo): fix windows build * cli(color): don't use color on non-tty (#452) * Added yarn lock file to gitignore (#455) * chore(next): dev version bump * chore(monorepo): fix windows build * cli(symlinks): Fix paths (#453) * cli(symlinks): fix symlinks * chore(linting): resolve linting errors * chore(rebase): remove old file * cli(init): Better defaults (#451) * cli(init): set default generator name * cli(init): better defaults * chore(rebase): remove old commit * cli(init): fix broken ast and merge scaffolds * chore(docs): better defaults * chore(lint): fix linting errors * chore(deps): remove path from dep installation * chore(resolve): resolve conflicts * fix(vulnerabilities): vulnerabilities patch for v3 (#460) * chore(dependencies): fix vulnerabilities * misc(scripts): update clean:all script * chore(dependencies): fix vulnerabilities * tests(parser): fix recursive-tests signature (#470) * chore(deps): add lerna * tests(coverage): fix coverage (#473) * test(coverage): fix coverage * test(binTestCases): run bintestcases on upper-repo * tests(travis): add node 10 * tests(cov): use regular nyc on tests * chore(lockfile): update pkglock * chore(semantic): configure plugins (#475) * fix(cli): show help flag when defaults fail (#466) * fixed test cases * remove unwanted console * fix(254) - addressed PR comments * fix(254) - added requested changes at right place * fix(254) - exit after error exit webpack if defaults are not found fix test cases for no options * fix: require chalk * refactor - addressed PR comments * refactor - addressed PR comments * refactor : remove unwanted keywords * chore(review): format * tests(no-options): refactor tests * ast(parser): add (#456) * ast(parser): add, update, remove - literal node support * ast(parser): add command * ast(util): update property, early exit * tests(add): resursive add ast * tests(add): update recursive parser snaps * misc(conflicts): resolve conflicts * tests(parser): update tests, inputs * chore(review): fix some things * ast(utils): add ast-path safe traverse and type support * ast(utils): merge update property with add property * tests(ast): add tests for safe traversals * misc(fixes): review comments * tests(ast): add tests for addProperty * misc(fixes): review comments * misc(fixes): review comments * misc(fixes): review comments * cli(add): re-add add command

* fixed test cases * remove unwanted console * fix(254) - addressed PR comments * fix(254) - added requested changes at right place * fix(254) - exit after error exit webpack if defaults are not found fix test cases for no options * fix: require chalk * refactor - addressed PR comments * refactor - addressed PR comments * refactor : remove unwanted keywords * chore(review): format

sumit-gupta91 added 5 commits May 26, 2018 23:32

fixed test cases

2c9db31

remove unwanted console

4b50c34

fix(254) - addressed PR comments

3c6a631

fix(254) - added requested changes at right place

0a89eb6

fix(254) - exit after error

904e527

exit webpack if defaults are not found fix test cases for no options

webpack-bot added the PR: unreviewed label May 26, 2018

fix: require chalk

5c9fe7c

sumit-gupta91 mentioned this pull request May 27, 2018

fix(help): display error message if no option provided on startup #254

Closed

evenstensberg reviewed May 28, 2018

View reviewed changes

evenstensberg changed the title ~~Bugfix/error message~~ fix(cli): show help flag when defaults fail May 29, 2018

refactor - addressed PR comments

bac9c01

evenstensberg requested changes May 30, 2018

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels May 30, 2018

refactor - addressed PR comments

c604d3e

webpack-bot added PR: review-outdated and removed PR: reviewed-changes-requested labels May 31, 2018

evenstensberg reviewed May 31, 2018

View reviewed changes

refactor : remove unwanted keywords

1bc3318

evenstensberg reviewed May 31, 2018

View reviewed changes

chore(review): format

94579b7

webpack-bot added the PR: conflict label Jun 2, 2018

evenstensberg approved these changes Jun 2, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Jun 2, 2018

Merge branch 'next' into bugfix/error-message

26d7f8c

webpack-bot removed the PR: conflict label Jun 2, 2018

evenstensberg merged commit 9475b17 into webpack:next Jun 2, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(cli): show help flag when defaults fail #466

fix(cli): show help flag when defaults fail #466

sumit-gupta91 commented May 26, 2018 •

edited

Loading

evenstensberg May 28, 2018

evenstensberg May 28, 2018

sumit-gupta91 commented May 30, 2018

evenstensberg left a comment

evenstensberg May 30, 2018

evenstensberg May 30, 2018

evenstensberg May 30, 2018

webpack-bot commented May 31, 2018

evenstensberg May 31, 2018

evenstensberg May 31, 2018

fix(cli): show help flag when defaults fail #466

fix(cli): show help flag when defaults fail #466

Conversation

sumit-gupta91 commented May 26, 2018 • edited Loading

evenstensberg May 28, 2018

Choose a reason for hiding this comment

evenstensberg May 28, 2018

Choose a reason for hiding this comment

sumit-gupta91 commented May 30, 2018

evenstensberg left a comment

Choose a reason for hiding this comment

evenstensberg May 30, 2018

Choose a reason for hiding this comment

evenstensberg May 30, 2018

Choose a reason for hiding this comment

evenstensberg May 30, 2018

Choose a reason for hiding this comment

webpack-bot commented May 31, 2018

evenstensberg May 31, 2018

Choose a reason for hiding this comment

evenstensberg May 31, 2018

Choose a reason for hiding this comment

sumit-gupta91 commented May 26, 2018 •

edited

Loading