Feature/fix commitlint #592
Conversation
|
I am going to fix the CI in this PR EDIT: no idea why on travis it is trying to lint all the commit messages |
| "type-empty": [2, "never"] | ||
| // The scope-enum : defined in the cz-config | ||
| // The 'type-enum': defined in the cz-config | ||
| // turn it on once CLI will be inside its own package, so the scope will be the name of the pacakged |
There was a problem hiding this comment.
what do you mean with cli in it's own package?
There was a problem hiding this comment.
The plungin commitlint for lerna forces to have a commit message where inside the parentheses you have to write down the name of the package. Please read what that package does.
It wasn't working before because the commitlint was half broken.
For now I turned off the rule meanwhile we decide what to do
| @@ -38,6 +38,7 @@ | |||
| "lint:codeOnly": "eslint \"{bin}/**/!(__testfixtures__)/*.js\" \"{bin}/**.js\"", | |||
| "lint": "eslint \"./bin/*.js\" \"./test/**/*.js\" \"packages/**/!(node_modules)/*.test.js\"", | |||
| "precommit": "lint-staged", | |||
| "commitmsg": "commitlint -E GIT_PARAMS", | |||
There was a problem hiding this comment.
Can we keep this simply as commit?
There was a problem hiding this comment.
This is the configuration I got from commitlint
https://marionebl.github.io/commitlint/#/guides-local-setup?id=install-husky
|
@ematipico The most important CI builds failed. This way your PR can't be merged. Please take a look at the CI results from travis (failure) and fix these issues. |
What kind of change does this PR introduce?
Fixed commitlint
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
Commitlint was not working properly. It now works perfectly while trying to commit a messge.
Does this PR introduce a breaking change?
No
Other information