Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scripts): add commit script, cz-customizable #612

Merged
merged 2 commits into from
Sep 27, 2018

Conversation

dhruvdutt
Copy link
Member

What kind of change does this PR introduce?
Chore/Utility

Did you add tests for your changes?

If relevant, did you update the documentation?

Summary
Add support to use git cz or npm run commit

Does this PR introduce a breaking change?
No

Other information
@ematipico, did we remove cz-customizable in past? git cz was broken.
Could it be introduced after #592?

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@evenstensberg evenstensberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving for @ematipico as he was the latest one touching this.

@ematipico
Copy link
Contributor

Could you please update the contribution section by adding a couple of lines about this command?

@ematipico ematipico merged commit 2570218 into webpack:master Sep 27, 2018
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All good

@dhruvdutt
Copy link
Member Author

Also, made a PR to add usage example (similar to our usage) in husky docs. #361 :)

@ematipico
Copy link
Contributor

Amazing stuff dude! 🔝🔝🔝🔝🔝🔝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants