Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added the cacheImmutable option to cache immutable assets (as… #1924

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

alexander-akait
Copy link
Member

…sets with a hash in file name like image.e12ab567.jpg)

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • documentation update
  • typo fix
  • metadata update

Motivation / Use-Case

Allow to cache immutable assets (webpack store immutable flag in assets info).

Breaking Changes

No

Additional Info

Will be great to enable it by default in the next major release.

…sets with a hash in file name like `image.e12ab567.jpg`)
@alexander-akait alexander-akait merged commit 5ed629d into master Aug 15, 2024
12 checks passed
@alexander-akait alexander-akait deleted the feat-cache-immutable-assets branch August 15, 2024 18:52
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 36.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 58.25%. Comparing base (f7529c3) to head (c4f9e51).
Report is 2 commits behind head on master.

Files Patch % Lines
src/middleware.js 23.80% 11 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1924      +/-   ##
==========================================
- Coverage   60.09%   58.25%   -1.84%     
==========================================
  Files          13       13              
  Lines         857      860       +3     
  Branches      244      247       +3     
==========================================
- Hits          515      501      -14     
- Misses        284      296      +12     
- Partials       58       63       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inottn inottn mentioned this pull request Aug 20, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant