fix: assetsInfo may be undefined #1927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inottn
requested review from
alexander-akait,
hiroppy and
snitin315
as code owners
alexander-akait
previously approved these changes
Aug 20, 2024
|
@inottn Can you add a small comment about this fix for |
done |
alexander-akait
approved these changes
Aug 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1927 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 13 13
Lines 860 861 +1
Branches 247 248 +1
=======================================
+ Hits 827 828 +1
Misses 33 33 ☔ View full report in Codecov by Sentry. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
Rspack does not yet support assetsInfo, so we may need to check if assetsInfo exists.
related pr: #1924
related issues: web-infra-dev/rspack#7614 web-infra-dev/rspack#7618
Breaking Changes
Additional Info