fix: clean 'close' event listeners on socket server after generating …

…new proxy config. (#5001)
webpack · Jan 22, 2024 · 26aae7e · 26aae7e
1 parent 5ec6a39
commit 26aae7e
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/lib/Server.js b/lib/Server.js
@@ -2087,6 +2087,12 @@ class Server {
 
             if (newProxyConfig !== proxyConfig) {
               proxyConfig = newProxyConfig;
+              const socket = req.socket != null ? req.socket : req.connection;
+              // @ts-ignore
+              const server = socket != null ? socket.server : null;
+              if (server) {
+                server.removeAllListeners("close");
+              }
               proxyMiddleware =
                 /** @type {RequestHandler} */
                 (getProxyMiddleware(proxyConfig));

diff --git a/test/server/proxy-option.test.js b/test/server/proxy-option.test.js
@@ -75,9 +75,21 @@ const proxyOption = [
   },
 ];
 
+let maxServerListeners = 0;
 const proxyOptionOfArray = [
   { context: "/proxy1", target: `http://localhost:${port1}` },
   function proxy(req, res, next) {
+    if (req != null) {
+      const socket = req.socket != null ? req.socket : req.connection;
+      // @ts-ignore
+      const server = socket != null ? socket.server : null;
+      if (server) {
+        maxServerListeners = Math.max(
+          maxServerListeners,
+          server.listeners("close").length
+        );
+      }
+    }
     return {
       context: "/api/proxy2",
       target: `http://localhost:${port2}`,
@@ -463,6 +475,10 @@ describe("proxy option", () => {
       expect(response.statusCode).toEqual(200);
       expect(response.text).toEqual("foo+next+function");
     });
+
+    it("should not exist multiple close events registered", async () => {
+      expect(maxServerListeners).toBeLessThanOrEqual(1);
+    });
   });
 
   describe("as an array without the `route` option", () => {