fix: clean 'close' event listeners on socket server after generating new proxy config. #5001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwj0417
requested review from
alexander-akait,
hiroppy,
snitin315 and
anshumanv
as code owners
alexander-akait
previously approved these changes
Dec 20, 2023
|
Thank you |
|
/easycla |
|
Ignore failed CI, we will fix it soon |
thank you for your reminder, please mention me when something need to be fixed. |
|
I removed optional chaining and nullish coalescing operator to make code compatible with lower node versions. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #5001 +/- ##
==========================================
+ Coverage 90.38% 90.52% +0.13%
==========================================
Files 16 16
Lines 1706 1710 +4
Branches 649 652 +3
==========================================
+ Hits 1542 1548 +6
+ Misses 150 148 -2
Partials 14 14 ☔ View full report in Codecov by Sentry. |
|
@snitin315 I want to merge it (you can do it too), will be it hard to rebase the next? |
|
No rebase won't be hard. But we can directly merge it in the next branch too |
alexander-akait
pushed a commit
that referenced
this pull request
Jan 22, 2024
…new proxy config. (#5001)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
yes, test cases added.
Motivation / Use-Case
when pass a function to proxy config. every time firing
handlerfunction, a new proxyServer were set, and events on old proxyServer has not been cleared.Breaking Changes
no
Additional Info