Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev - Title Missing on Voting Page #720

Closed
johnstew opened this issue Jan 24, 2017 · 14 comments · Fixed by #980
Closed

Dev - Title Missing on Voting Page #720

johnstew opened this issue Jan 24, 2017 · 14 comments · Fixed by #980
Assignees
@bebraw
Labels
Bug Site Structure

Comments

@johnstew
Copy link

johnstew commented Jan 24, 2017 •
edited
Loading

The title is missing on the vote page.

Small issue but good for SEO.
@pllearns
Copy link

Hey @johnstew, I can take this PR. What should the title be? Influence or Vote? I agree that this is good for SEO.

@pllearns pllearns mentioned this issue Jan 28, 2017
Closed
@simon04
Copy link
Collaborator

simon04 commented Jan 29, 2017

Why does this change not set the HTML title in build/vote/index.html?

diff --git a/antwar.config.js b/antwar.config.js
index aa174f68..1cb9c884 100644
--- a/antwar.config.js
+++ b/antwar.config.js
@@ -150,24 +150,28 @@ module.exports = {
     ),

     vote: {
+      title: 'Vote',
       path() {
         return require('./components/vote/list.jsx').default
       }
     },

     'vote/feedback': {
+      title: 'Vote',
       path() {
         return require('./components/vote/list.jsx').default
       }
     },

     'vote/moneyDistribution': {
+      title: 'Vote',
       path() {
         return require('./components/vote/list.jsx').default
       }
     },

     organization: {
+      title: 'Organization',
       path() {
         return require('./components/organization/organization.jsx').default
       }

@pllearns
Copy link

Agreed with the idea @simon04, but it appears from what I see (exposing some ignorance) that the vote is not set-up in the paths/section area of the config. It may be a file structure thing too. But again, exposing ignorance. I'll submit two PRs to address through styling and HTML.

@pllearns pllearns mentioned this issue Jan 29, 2017
Merged
@simon04
Copy link
Collaborator

simon04 commented Jan 31, 2017

https://webpack.js.org/vote/ still has no HTML title set:

<!DOCTYPE html>
<html>
  <head>
    <meta charset="UTF-8">
    <title></title>
<!-- ... -->

Help on #720 (comment) is appreciated.

@simon04 simon04 reopened this Jan 31, 2017
@bebraw
Copy link
Contributor

bebraw commented Jan 31, 2017

@simon04 Look into antwar.config.js. It picks up the static title from there. There are sections like vote: {. If you add title: 'foobar' etc., the build should work. It's the same idea for the other sections too.

@simon04
Copy link
Collaborator

simon04 commented Jan 31, 2017

That's what I tried in #720 (comment). Am I missing/overlooking something?

@bebraw
Copy link
Contributor

bebraw commented Jan 31, 2017

@simon04 The titles are taken into account only for the final build.

@simon04
Copy link
Collaborator

simon04 commented Jan 31, 2017

Final build is npm run build? I did that. Afterwards build/vote/index.html does contain an empty <title></title>.

@bebraw
Copy link
Contributor

bebraw commented Jan 31, 2017

@simon04 Ok, it might be a bug in the generator then. It probably applies the template a little differently in this particular case (different path() definition).

@pllearns
Copy link

Agreed, my approaches were cosmetic, but, a different path definition should work. Is there a way that the vote page could be added to the section in antwar.config.js where the other sections live (i.e. concepts, guides, configuration? Apologies I couldn't help more right now. I'll check in later this week.

@skipjack skipjack mentioned this issue Apr 15, 2017
Closed
@skipjack
Copy link
Collaborator

Created an issue over at antwarjs/antwar#127 for this with more details.

@skipjack
Copy link
Collaborator

skipjack commented May 8, 2017 •
edited
Loading

@bebraw seeing as antwarjs/antwar#127 is done, can you test and close this once you release and bump the antwar version over here?

@bebraw
Copy link
Contributor

bebraw commented May 9, 2017

@skipjack This should be fixed when #980 goes in.

@skipjack skipjack mentioned this issue May 28, 2017
Merged
5 tasks
@skipjack skipjack changed the title Title on Vote page Dev - Title Missing on Voting Page Jun 14, 2017
@skipjack skipjack mentioned this issue Jul 6, 2017
Closed
22 tasks
@skipjack
Copy link
Collaborator

skipjack commented Jul 6, 2017

Closing as I added this to the list of TODOs in #1380 -- will either be addressed by #980 or a port.

@skipjack skipjack closed this as completed Jul 6, 2017
@skipjack skipjack mentioned this issue Aug 14, 2017
Open
11 tasks
@pierreneter pierreneter mentioned this issue Aug 25, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bebraw bebraw

Labels
Bug Site Structure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Port to webpack 3 and Upgrade Antwar webpack/webpack.js.org
5 participants
@bebraw @simon04 @johnstew @skipjack @pllearns