Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to webpack 3 and Upgrade Antwar #980

Merged
merged 49 commits into from
Sep 2, 2017
Merged

Port to webpack 3 and Upgrade Antwar #980

merged 49 commits into from
Sep 2, 2017

Conversation

bebraw
Copy link
Contributor

@bebraw bebraw commented Mar 5, 2017

Port site to webpack 3 and a new version of antwar that fixes a variety of bugs. What's left:

  • fix <title> tags, none of which are populated
  • fix introduction sidebar links
  • fix activation of current page in sidebar (i.e. displaying anchors)
  • fix mobile sidebar (pretty much empty for some reason, maybe due to title issue)
  • fix terminated build issue (not sure what's going on there 😕)

Resolves #720 (once titles are fixed, remember to double check vote title)

@skipjack
Copy link
Collaborator

skipjack commented May 28, 2017

Ok so here’s what i’m seeing:

  • <title> doesn’t look like it’s populated on any page
  • introduction sidebar links are broken… clicking those just duplicates the section name (e.g. /concepts/concepts)
  • activation of current page in sidebar is broken

Aside from those I'm not seeing anything else broken but i'll keep poking around. I can look into to the two sidebar issues but I'm not sure what to do about the titles. It would be great if we could put that one to bed and close out #720.

I restarted the build as well to see if anything fails -- the last one got terminated somehow.

@skipjack
Copy link
Collaborator

skipjack commented May 28, 2017

Ok updated the lead-in description with what's left to do... I fixed two issues with the normal sidebar and will now look into the mobile sidebar. Also working on simplifying the webpack config even more.

@skipjack
Copy link
Collaborator

Yeah so the issue with the SidebarMobile component is that the routing data changed and many titles are missing. Once we figure out what the solution is for title and children it should be an easy fix.

@bebraw
Copy link
Contributor Author

bebraw commented Jun 28, 2017

I upgraded the setup to use webpack 3 and fixed titles. Can you check the mobile sidebar bit? Also that termination issue remains most likely (some way to debug is needed).

@bebraw bebraw changed the title chore - Port to webpack 2 chore - Port to webpack 3 Jun 28, 2017
@skipjack
Copy link
Collaborator

@bebraw I'll pull, test, and try to resolve the mobile sidebar issue. I restarted the build just to see if that would help, but honestly I'm not really an expert when it comes to CI. Although I just checked the build and it seems to be moving past the initial stages now.

@skipjack skipjack changed the title chore - Port to webpack 3 Port to webpack 3 and Upgrade Antwar Jun 29, 2017
@skipjack
Copy link
Collaborator

skipjack commented Jul 1, 2017

> webpack.js.org@0.1.2 lint:links /home/travis/build/webpack/webpack.js.org
> hyperlink -r build/index.html | ./scripts/check-links.js
Guessing --root from input files: file:///home/travis/build/webpack/webpack.js.org/build/

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

Not really sure what's failing here, is it hyperlink? @bebraw the output directory is still called /build, right?

@skipjack
Copy link
Collaborator

skipjack commented Jul 1, 2017

@bebraw I'm unable to find the necessary data within section.all(). Only some top level pages come back none of which contain any child pages:

image

I'm also not seeing the titles populated:

image

Please advise... I did wipe my node_modules and re npm install everything after checking out to this branch.

This is still not ideal but at least renders the correct title and anchors
for all index pages. Added a TODO noting how it should probably be
resolved long term.
Now that titles and anchors are displayed these pages are a bit
more prominent.
@skipjack
Copy link
Collaborator

Submitted Banno/polymer-webpack-loader#63 to fix the last remaining issue. @pierreneter I'm going to do another pass over all this and see if there's anything else that needs fixing or can be cleaned up. Expect it to be merged by the end of this week (this weekend at the latest).

@pierreneter
Copy link
Member

4e1beb9 related to: get-alex/alex#175

alex . -q :

alex CLI searches for files with a markdown or text extension when given directories (e.g., $ alex . will find readme.md and foo/bar/baz.txt). To prevent files from being found by alex, add an .alexignore file.

and

node_modules is ignored by default.

@skipjack
Copy link
Collaborator

skipjack commented Sep 1, 2017

Will do a final pass over this tonight and get it merged.

Ignore the "sucks" mention in the npm-install-webpack-plugin file
for now. It isn't used in a derogatory way so I'm not sure we should
change it but I'm also not sure we should `allow` "sucks" globally.
@skipjack
Copy link
Collaborator

skipjack commented Sep 2, 2017

Ok @pierreneter tested this out and everything seems good to go. I did just submit webpack-contrib/install-webpack-plugin#118 to fix a broken remote link but we don't necessarily have to wait on that to merge. Also seeing issues with Travis' network again but I restarted the build so we'll see what happens. Latest this goes in is tomorrow.

@skipjack
Copy link
Collaborator

skipjack commented Sep 2, 2017

Ran all tests locally which only ran fine aside from the broken link from webpack-contrib/install-webpack-plugin#118. Doesn't make sense to hold this merge up just for that though. If anything else comes up we can resolve in a separate PR.

@pierreneter I'll likely start working on #1519 soon, and will talk with @bebraw to try to simplify the antwar configuration even more. Will submit separate PRs for that and cc you.

@skipjack skipjack merged commit 458141f into master Sep 2, 2017
@skipjack skipjack deleted the feat-webpack2 branch September 2, 2017 23:29
@skipjack
Copy link
Collaborator

skipjack commented Sep 2, 2017

@pierreneter it's in 🎉

Thanks again for all of your work on finishing this off. It should definitely make it easier to keep pushing the repo forward in terms of build process and infrustructure. I will try to set up a discussion soon, maybe in slack or something, with those interested in the infrastructure of the site so we can make a solid plan.

rouzbeh84 added a commit that referenced this pull request Sep 5, 2017
extends PR #980:

I'm sure this is already known but the bug is happening because the left side is having its title put in a `p` tag whereas the right side is right _before_ its equivalent `p` tag :(. This seems to resolve the issue for now but the markup should be parsed properly.
@rouzbeh84 rouzbeh84 mentioned this pull request Sep 5, 2017
@skipjack skipjack mentioned this pull request Sep 30, 2017
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dev - Title Missing on Voting Page
3 participants