-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update webassemblyjs to support wasm with exception opcodes #16050
Conversation
|
For maintainers only:
|
This actually looks blocked on xtuc/webassemblyjs#1132 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Anyway you can update deps locally if you don't want to wait for a new release
@xtuc can you look at xtuc/webassemblyjs#1132, thank you |
@sokra Thanks for your update. I labeled the Pull Request so reviewers will review it again. @alexander-akait Please review the new changes. |
Sorry for big delay, already fixed in master |
Today, webpack will fail if
.wasm
files are referenced that are built with support for exceptions in the following way:This was fixed upstream in xtuc/webassemblyjs#1117 and a new release of the
webassemblyjs/*
dependencies cut. This PR updates webpack to use these new dependencies.What kind of change does this PR introduce?
Dependency update
Did you add tests for your changes?
No - "just" a dependency update.
Does this PR introduce a breaking change?
No.
What needs to be documented once your changes are merged?