Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update webassemblyjs to support wasm with exception opcodes #16050

Closed

Conversation

bpowers
Copy link

@bpowers bpowers commented Jul 14, 2022

Today, webpack will fail if .wasm files are referenced that are built with support for exceptions in the following way:

Creating an optimized production build...
Failed to compile.

Module parse failed: Unexpected section: 0xd
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
Error: Unexpected section: 0xd


error Command failed with exit code 1.

This was fixed upstream in xtuc/webassemblyjs#1117 and a new release of the webassemblyjs/* dependencies cut. This PR updates webpack to use these new dependencies.

What kind of change does this PR introduce?

Dependency update

Did you add tests for your changes?

No - "just" a dependency update.

Does this PR introduce a breaking change?

No.

What needs to be documented once your changes are merged?

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 14, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bpowers / name: Bobby Powers (57a6b86)

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@bpowers
Copy link
Author

bpowers commented Jul 14, 2022

This actually looks blocked on xtuc/webassemblyjs#1132

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Anyway you can update deps locally if you don't want to wait for a new release

@alexander-akait
Copy link
Member

alexander-akait commented Jul 14, 2022

@xtuc can you look at xtuc/webassemblyjs#1132, thank you

@webpack-bot
Copy link
Contributor

@sokra Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@alexander-akait Please review the new changes.

@alexander-akait
Copy link
Member

Sorry for big delay, already fixed in master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants