wasm-parser: skip rather than throw on unknown sections #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One new section type is 0xd `exception`, which doesn't need any special processing, and the details aren't useful to e.g. Webpack. It seems most robust to just skip unknown sections by default rather than have to make a change + release to unbreak parsing for spec additions.
|
@bpowers your change as been publish as |
|
amazing, thanks @xtuc ! |
|
@bpowers do you plan to update webassemblyjs in Webpack? |
This was referenced Jul 14, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One new section type is 0xd
exception, which doesn't need any special processing, and the details aren't useful to e.g. Webpack. It seems most robust to just skip unknown sections by default rather than have to make a change + release to unbreak parsing for spec additions.I also added an option
errorOnUnknownSectionto keep the old behavior, in case people want to match the old behavior.I tested this by patching a local project that uses the new exception instructions (
throw,try, etc) in a WebAssembly file that is processed by Webpack and it works well.Finally I bumped the version for
wasm-parser. If this looks good + mergable (happy to make changes, too!), @xtuc could you cut a release?