Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archiveweb replay with local wacz files does not work since last release #178

Closed
dteyssou opened this issue Aug 16, 2023 · 3 comments · Fixed by webrecorder/wabac.js#141
Closed

archiveweb replay with local wacz files does not work since last release #178

dteyssou opened this issue Aug 16, 2023 · 3 comments · Fixed by webrecorder/wabac.js#141

Comments

@dteyssou
Copy link

Since last release (0.11.1), it does not seem possible to replay and check in the extension that the archived page is properly saved. Instead, we get a grey page (FB) or a logo (Instagram) while sending those resulting warcz files to the Wayback machine still work (and the Wayback machine can display them).
@ikreymer
Copy link
Member

Looks like the issue is in replayweb.page due to some updates to wabac.js -- was able to repro with instagram replay.

ikreymer added a commit to webrecorder/wabac.js that referenced this issue Aug 17, 2023
@ikreymer
fix document.close() inject to only be used for JS scripts
70dba22 
fixes webrecorder/archiveweb.page#178
bump to 2.16.9
@ikreymer ikreymer mentioned this issue Aug 17, 2023
Merged
ikreymer added a commit to webrecorder/wabac.js that referenced this issue Aug 17, 2023
@ikreymer
fix document.close() inject to only be used for JS scripts (#141)
bc4f5d2 
fixes webrecorder/archiveweb.page#178
bump to 2.16.9
@ikreymer
Copy link
Member

Will be in upcoming release (0.11.2) and RWP (1.8.8), will close when released.

@ikreymer ikreymer reopened this Aug 17, 2023
ikreymer added a commit that referenced this issue Aug 18, 2023
@ikreymer
deps: bump to wabac.js 2.16.9 to fix regression from 2.16.8, fixing #178
62dc9f4 


also bump to replaywebpage 1.8.8
bump to 0.11.2
ikreymer added a commit that referenced this issue Aug 18, 2023
@ikreymer
deps: bump to wabac.js 2.16.9 to fix regression from 2.16.8, fixing #178
64f8353 
 (#179)

also bump to replaywebpage 1.8.8
bump to 0.11.2
@ikreymer
Copy link
Member

Released in 0.11.2, now out and ReplayWeb.page 1.8.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix document.close() inject to only be used for JS scripts webrecorder/wabac.js
2 participants
@ikreymer @dteyssou