fix document.close() inject to only be used for JS scripts (#141)

fixes webrecorder/archiveweb.page#178 bump to 2.16.9
webrecorder · Aug 17, 2023 · bc4f5d2 · bc4f5d2
1 parent 8a6ca2e
commit bc4f5d2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@webrecorder/wabac",
-  "version": "2.16.8",
+  "version": "2.16.9",
   "main": "index.js",
   "type": "module",
   "license": "AGPL-3.0-or-later",

diff --git a/src/rewrite/html.js b/src/rewrite/html.js
@@ -351,7 +351,7 @@ class HTMLRewriter
           break;
 
         case "script":
-          if (headDone && !isTextEmpty) {
+          if (headDone && !isTextEmpty && (!scriptRw || scriptRw === "js")) {
             rwStream.emitRaw(";document.close();");
           }
           break;

diff --git a/test/rewriteHTML.js b/test/rewriteHTML.js
@@ -316,6 +316,12 @@ test("script", rewriteHtml,
    <script>var foo = x;;document.close();</script>
    </body>`);
 
+// SCRIPT tag in body but json
+test("script", rewriteHtml,
+  "<body><script type=\"application/json\">{\"embed top test\": \"http://example.com/a/b/c.html\"}</script></body>",
+  "<body><script type=\"application/json\">{\"embed top test\": \"http://example.com/a/b/c.html\"}</script></body>"
+);
+
 // SCRIPT tag ensure reset after known type
 test("script", rewriteHtml,
   `<script type="application/javascript">document.location.href = "abc";</script>