Use rtc::ToString instead of std::to_string in SocketAddress::PortAsString()
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtAsString()` Justification for this change is that `std::to_string` should be avoided as it uses the user's locale and calls to it get serialized, which is bad for concurrency. My actual motivation for this is quite bizarre. Before this change, with Zed's use of the LiveKit Rust SDK, I was getting connection strings that were not valid utf-8, instead having a port of `3\u0000\u0000\u001c\u0000`. I have not figured out how that could happen or why this change fixes it.
mgsloan
added a commit
to zed-industries/zed
that referenced
this pull request
Nov 29, 2024
Specifically to pull in webrtc-sdk/webrtc#156
theomonnom
approved these changes
Dec 2, 2024
3 tasks
hiroshihorie
added a commit
that referenced
this pull request
Dec 9, 2024
commit 102940838f859941a41b2f3062d4eb8a61be6414
Author: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>
Date: Thu Dec 5 15:27:34 2024 +0700
audio engine 1
commit d31187b
Author: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>
Date: Thu Dec 5 15:26:38 2024 +0700
Connect voice engine mute to adm
commit 3df68d4
Author: Hiroshi Horie <548776+hiroshihorie@users.noreply.github.com>
Date: Fri Oct 11 20:41:44 2024 +0900
Revert "Stop recording on mute (turn off mic indicator) (#55)"
This reverts commit c0209ef.
commit b99fd2c
Author: Michael Sloan <mgsloan@gmail.com>
Date: Mon Dec 2 18:59:22 2024 -0700
Use `rtc::ToString` instead of `std::to_string` in `SocketAddress::PortAsString()` (#156)
Justification for this change is that `std::to_string` should be avoided
as it uses the user's locale and calls to it get serialized, which is
bad for concurrency.
My actual motivation for this is quite bizarre. Before this change, with
Zed's use of the LiveKit Rust SDK, I was getting connection strings that
were not valid utf-8, instead having a port of
`3\u0000\u0000\u001c\u0000`. I have not figured out how that could
happen or why this change fixes it.
commit 543121b
Author: davidliu <davidliu@deviange.net>
Date: Wed Oct 30 20:33:46 2024 -0700
Custom audio input for Android (#154)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification for this change is that
std::to_stringshould be avoided as it uses the user's locale and calls to it get serialized, which is bad for concurrency.My actual motivation for this is quite bizarre. Before this change, with Zed's use of the LiveKit Rust SDK, I was getting connection strings that were not valid utf-8, instead having a port of
3\u0000\u0000\u001c\u0000. I have not figured out how that could happen or why this change fixes it.