Use livekit's Rust SDK instead of their swift SDK, take 2 #20826

SomeoneToIgnore · 2024-11-18T16:39:35Z

Another take, applying #13343 and whatever fixes on top needed for it to be better

Worse screenhare quality (this is probably an upstream issue)
Incorporate our patches to webrtc: Use rtc::ToString instead of std::to_string in SocketAddress::PortAsString() webrtc-sdk/webrtc#156
Implement screen capture on linux

Release Notes:

Switch from Swift to Rust LiveKit SDK 🦀

…20809) This reverts commit d92166f. # Conflicts: # Cargo.lock

…#21550) Similar to #20826 but keeps the Swift implementation. There were quite a few changes in the `call` crate, and so that code now has two variants. Closes #13714 Release Notes: - Added preliminary Linux support for voice chat and viewing screenshares. --------- Co-authored-by: Kirill Bulatov <mail4score@gmail.com> Co-authored-by: Kirill Bulatov <kirill@zed.dev> Co-authored-by: Mikayla <mikayla@zed.dev>

SomeoneToIgnore added the run-bundling Configures PR to run the bundle step label Nov 18, 2024

cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Nov 18, 2024

SomeoneToIgnore self-assigned this Nov 18, 2024

SomeoneToIgnore force-pushed the livekit-rust-sdk branch 2 times, most recently from 7e17646 to b5b7ad2 Compare November 19, 2024 14:09

SomeoneToIgnore and others added 2 commits November 19, 2024 16:09

Reapply "Use livekit's Rust SDK instead of their swift SDK (#13343)" (#…

46329d6

…20809) This reverts commit d92166f. # Conflicts: # Cargo.lock

Move all cpal-related code into a background thread

0077602

SomeoneToIgnore force-pushed the livekit-rust-sdk branch from b5b7ad2 to 0077602 Compare November 19, 2024 14:09

Stop requiring a WebRTC.framework dir with Info.plist

8b20ce6

SomeoneToIgnore force-pushed the livekit-rust-sdk branch from 2706b15 to 453112d Compare November 19, 2024 16:57

An attempt to fix the sound issues

22d10c2

SomeoneToIgnore force-pushed the livekit-rust-sdk branch from 453112d to 22d10c2 Compare November 20, 2024 03:44

mgsloan added 2 commits November 20, 2024 17:37

Log errors in more places in live_kit_client

88d48f4

WIP improvement to audio quality by doing some buffering during playback

5e192f7

mgsloan force-pushed the livekit-rust-sdk branch from 814d5b5 to 5e192f7 Compare November 26, 2024 00:33

mgsloan and others added 4 commits November 25, 2024 21:24

Merge branch 'main' into livekit-rust-sdk

a487f77

Switch to using livekit's internal re-sampler

f6bfaab

Rework audio playback to use the local device's sample rate

b35e235

Fix some threading in capture_local_audio_track

a1a35a9

mikayla-maki force-pushed the livekit-rust-sdk branch 3 times, most recently from a242c16 to 841262d Compare November 27, 2024 06:11

Fix clippy?

8b6408f

mikayla-maki force-pushed the livekit-rust-sdk branch from 841262d to 8b6408f Compare November 27, 2024 07:13

mikayla-maki and others added 3 commits November 26, 2024 23:32

Don't query the host when running tests

98eddef

remove accidental debug

085325e

Bump the buffer size to 100ms

4b54773

mikayla-maki force-pushed the livekit-rust-sdk branch 2 times, most recently from ac57804 to f980bda Compare November 27, 2024 19:51

Fix microphone not working,,, maybe?

25f2cf9

mgsloan force-pushed the livekit-rust-sdk branch from 5af8e26 to 73e343c Compare December 1, 2024 08:01

Merge branch 'main' into livekit-rust-sdk

458ae9a

mgsloan force-pushed the livekit-rust-sdk branch from 458ae9a to 454f380 Compare December 2, 2024 17:07

mikayla-maki and others added 4 commits December 2, 2024 09:45

Merge branch 'main' into livekit-rust-sdk

7050288

bump livekit version

c6f1ab9

Upgrade to latest livekit

0f5bd9a

Merge branch 'main' into linux-render-screenshare

be967b7

cole-miller mentioned this pull request Dec 3, 2024

Cursor vanishes in some regions on Wayland #21462

Closed

1 task

SomeoneToIgnore and others added 4 commits December 3, 2024 18:43

Merge branch 'main' into livekit-rust-sdk

6174f50

Deallocate images used for rendering screenshares

ddef94a

Merge branch 'linux-render-screenshare' into livekit-rust-sdk

93d8677

Fix build on Mac

3861d07

mgsloan force-pushed the livekit-rust-sdk branch from a07c270 to 3861d07 Compare December 3, 2024 20:23

mikayla-maki and others added 3 commits December 3, 2024 15:00

fix livekit naming

1f1c274

Revert over eager livekit renames

d9b5af2

Fix build on windows

6578604

zed-industries deleted a comment from github-actions bot Dec 3, 2024

mikayla-maki and others added 3 commits December 3, 2024 15:12

fix more rename issues

6367b2d

Revert protobuf name migrations

9c9e1d5

Fix colors in linux screenshare

39069ad

mikayla-maki force-pushed the livekit-rust-sdk branch from 1a0db76 to 39069ad Compare December 4, 2024 00:11

mgsloan added 3 commits December 3, 2024 17:19

Fix resize for linux screenshare rendering

83d6625

Cargo fmt

825c630

Fix Mac clippy

afa01a2

mgsloan force-pushed the livekit-rust-sdk branch from c0a0887 to afa01a2 Compare December 4, 2024 18:40

mgsloan mentioned this pull request Dec 4, 2024

Use LiveKit's Rust SDK on Linux while continue using Swift SDK on Mac #21550

Merged

SomeoneToIgnore force-pushed the livekit-rust-sdk branch from 87018b2 to afa01a2 Compare December 4, 2024 21:34

mikayla-maki closed this Dec 4, 2024

mgsloan deleted the livekit-rust-sdk branch December 7, 2024 21:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use livekit's Rust SDK instead of their swift SDK, take 2 #20826

Use livekit's Rust SDK instead of their swift SDK, take 2 #20826

SomeoneToIgnore commented Nov 18, 2024 •

edited by mikayla-maki

Loading

Use livekit's Rust SDK instead of their swift SDK, take 2 #20826

Use livekit's Rust SDK instead of their swift SDK, take 2 #20826

Conversation

SomeoneToIgnore commented Nov 18, 2024 • edited by mikayla-maki Loading

SomeoneToIgnore commented Nov 18, 2024 •

edited by mikayla-maki

Loading