Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LiveKit's Rust SDK on Linux while continue using Swift SDK on Mac #21550

Merged
merged 57 commits into from
Dec 5, 2024

Conversation

mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Dec 4, 2024

Similar to #20826 but keeps the Swift implementation. There were quite a few changes in the call crate, and so that code now has two variants.

Closes #13714

Release Notes:

  • Added preliminary Linux support for voice chat and viewing screenshares.

SomeoneToIgnore and others added 30 commits November 19, 2024 16:09
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 4, 2024
@mgsloan mgsloan changed the title Use LiveKit's Rust SDK on Linux while continue using Swift SDK on Mac. Use LiveKit's Rust SDK on Linux while continue using Swift SDK on Mac Dec 4, 2024
@WeetHet
Copy link
Contributor

WeetHet commented Dec 5, 2024

Sorry to interfere, before this is merged, could we get a feature to build macOS with the Rust SDK? I understand that it might be difficult to implement, but it would greatly reduce the difficulty in packaging Zed in nixpkgs, as we only have swift 5.8 now. It would be greatly appreciated

…flag

co-authored-by: Michael <michael@zed.dev>
@mikayla-maki
Copy link
Contributor

mikayla-maki commented Dec 5, 2024

@WeetHet We just pushed a commit that adds a livekit-cross-platform feature to the workspace. Once we've fixed CI, you should be able to enable the cross platform livekit code in nixpkgs by adjusting a few lines here: https://github.com/zed-industries/zed/pull/21550/files#diff-315ed179e69e42c0a098166a7faa7899838376c2649c84fa8cb66643f3813a45R129-R134

Unfortunately, due to the way platform dependencies work, I don't know if we can make this configurable by the CLI

@WeetHet
Copy link
Contributor

WeetHet commented Dec 5, 2024

@WeetHet We just pushed a commit that adds a livekit-cross-platform feature to the workspace. Once we've fixed CI, you should be able to enable the cross platform livekit code in nixpkgs by adjusting a few lines here: https://github.com/zed-industries/zed/pull/21550/files#diff-315ed179e69e42c0a098166a7faa7899838376c2649c84fa8cb66643f3813a45R129-R134

Unfortunately, due to the way platform dependencies work, I don't know if we can make this configurable by the CLI

Thank you, that's probably more than enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for LiveKit and mic/screensharing on Linux
5 participants