-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proto 3.15 supports optional
again!
#109
Labels
enhancement
New feature or request
Comments
Merged
huan
changed the title
Proto 3.12 supports
Proto 3.15 supports Mar 17, 2021
optional
again!optional
again!
huan
added a commit
that referenced
this issue
Mar 17, 2021
huan
added a commit
that referenced
this issue
Mar 17, 2021
huan
added a commit
that referenced
this issue
Mar 17, 2021
This was referenced Mar 24, 2021
huan
added a commit
that referenced
this issue
Oct 4, 2021
* require protoc v3.15 (#109) * Upgrade grpc-gateway v2.1 -> v2.3 (#109) * show version when install grpc-gateway (#109) * use `optional` in friendship source (#109) * clean * optional hello * v0.25 for optional * add comment to #130 * add docs for gRPC proto * clean script * add link * add back optional to replace wrappers * improvement * remove unnecessary optional * 0.29.36 * 0.29.37 * 0.29.38 * 0.29.39 * 0.29.40 * clean * 0.29.41 * clean * 0.29.42 * clean * 0.29.43 * re-export google pb classes from cjs * re-export google pb classes from cjs * 0.29.44 * 0.29.45 * add @latest for install * 0.29.46
This was referenced Oct 4, 2021
huan
added
enhancement
New feature or request
and removed
breaking
Breaking changes
labels
Oct 4, 2021
Hi, I stumbled upon this issue while tackling the similar problem: yoheimuta/protolint#234. FWIW, protoc-gen-protolint supports proto3 optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to https://stackoverflow.com/a/62566052/1123955, we can get rid of the wrapper in our protos.
See: https://github.com/protocolbuffers/protobuf/blob/v3.12.0/docs/implementing_proto3_presence.md#background
This change will be a BREAKING CHANGE so it should be discussed later.
Useful Resources
Blockers
More details
The text was updated successfully, but these errors were encountered: