Add room member #122

su-chang · 2021-03-09T11:57:31Z

No description provided.

@deprecated

* fix: correct spell mistakes * 0.13.10 * This is a breaking change! * change python proto package name * update the version of chatie_grpc * try to install request (grpc/grpc-node#922 (comment)) * 0.15.2 * add grpc debug client link * update setup.py to fix pypi bug (wechaty#59) * update setup to fix pypi bug * change chatie-grpc generated dir * 0.15.2 * 0.15.3 (wechaty#60) * keep the package dir name in site-packages as `chatie_grpc` (wechaty#62) * 0.15.3 * keep package name as chatie_grpc not chatie-grpc * 0.15.4 (wechaty#63) * deploy release jar (wechaty#61) * fix maven,deploy jar to center oss * fix maven,deploy jar to center oss * add java to README.md * use better relative path for proto_path (zxh0/vscode-proto3#31 (comment)) * 0.15.5 * update pypi install_requires config (wechaty#64) * 0.15.4 * add install_requires * 0.15.5 * 0.15.6 * add NOTICE * 0.13.10 * 0.16.0 * 0.16.1 * Bump @chatie/tsconfig from 0.8.0 to 0.10.1 (wechaty#70) Bumps [@chatie/tsconfig](https://github.com/Chatie/tsconfig) from 0.8.0 to 0.10.1. - [Release notes](https://github.com/Chatie/tsconfig/releases) - [Commits](https://github.com/Chatie/tsconfig/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump grpc_tools_node_protoc_ts from 2.5.11 to 4.0.0 (wechaty#69) Bumps [grpc_tools_node_protoc_ts](https://github.com/agreatfool/grpc_tools_node_protoc_ts) from 2.5.11 to 4.0.0. - [Release notes](https://github.com/agreatfool/grpc_tools_node_protoc_ts/releases) - [Commits](agreatfool/grpc_tools_node_protoc_ts@v2.5.11...v4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump @chatie/git-scripts from 0.2.5 to 0.6.2 (wechaty#68) Bumps [@chatie/git-scripts](https://github.com/Chatie/git-scripts) from 0.2.5 to 0.6.2. - [Release notes](https://github.com/Chatie/git-scripts/releases) - [Commits](https://github.com/Chatie/git-scripts/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Update betterproto (wechaty#46) * specify python v3 * 0.16.2 * add php rpc (wechaty#76) * add php grpc * update usage * update usage * update usage * update * update usage * add php rpc * add PHP Grpc & maintainers * 0.16.3 * add all codeowners for languages * 0.16.4 * Bump @chatie/eslint-config from 0.8.1 to 0.12.1 (wechaty#75) Bumps [@chatie/eslint-config](https://github.com/Chatie/eslint-config) from 0.8.1 to 0.12.1. - [Release notes](https://github.com/Chatie/eslint-config/releases) - [Commits](https://github.com/Chatie/eslint-config/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * fix eslint * 0.16.5 * add php action (wechaty#78) * add php action * add php action * add php action * add php action * add php action * add php action * add php action * add php action * add php action * add php action * add php action * add php action * tune layout for source code * Update README.md * v0.17 * fix to v0.17 * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * fix github url * 0.16.2 * 0.17.1 * add dirty rpc function definition for sync data (wechaty#79) * add dirty rpc function definition for sync data * try to fix tests * add rpc roomMemberPayloadDirty * add dirty event type * revise code according to comments * modify dirty methods and event * try to fix build * modify code according to review * fix build * hope this is the final build fix * this must be the final final build fix * fix proto naming convention * change property name according to comment * Update package.json * Update package.json Co-authored-by: Huan (李卓桓) <zixia@zixia.net> * add contact phone rpc call definition (wechaty#80) * add more methods related to new wechaty-puppept update (wechaty#81) * add more methods related to new wechaty-puppept update * fix test * fix typo and order * 0.17.3 * fix request structure according to comments * add phone to contact payload (wechaty#82) * bump version to publish new changes (wechaty#83) * add csharp nuget (wechaty#84) * proto add csharp namespace * add csharp solution * update * csharp add build powshell * Create csharp.yml * update csharp.yaml * update copy.ps1 * add test * test * update common.ps1 * test action args key * test powshell args * test github Secrets * update yaml * update nuget package as rohith/publish-nuget@v2 * update version info * github action add nuget VERSION_FILE_PATH * chsarp github action over * recovery github action * clear * update gitgnore * delete .vs folder * update README.md for csharp * README.md update csharp grpc doc * README.md add nuget introduction * add file stream and image stream rpc call (wechaty#88) * add file stream and image stream rpc call * fix test * 0.17.5 * add imageType to MessageImageStreamRequest * add @deprecated to MessageFile and MessageImage rpc * add change history in readme * 0.18.0 * Bump grpc_tools_node_protoc_ts from 4.1.5 to 5.0.0 (wechaty#87) Bumps [grpc_tools_node_protoc_ts](https://github.com/agreatfool/grpc_tools_node_protoc_ts) from 4.1.5 to 5.0.0. - [Release notes](https://github.com/agreatfool/grpc_tools_node_protoc_ts/releases) - [Commits](agreatfool/grpc_tools_node_protoc_ts@v4.1.5...v5.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Bump ts-protoc-gen from 0.12.0 to 0.13.0 (wechaty#86) Bumps [ts-protoc-gen](https://github.com/improbable-eng/ts-protoc-gen) from 0.12.0 to 0.13.0. - [Release notes](https://github.com/improbable-eng/ts-protoc-gen/releases) - [Changelog](https://github.com/improbable-eng/ts-protoc-gen/blob/master/CHANGELOG.md) - [Commits](improbable-eng/ts-protoc-gen@0.12.0...0.13.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> * Send message stream (wechaty#89) * add sendFileStream rpc call * add sendFileStream into puppet server impl * add readme * 0.18.1 * change filebox to data with bytes type * add name attribute into stream request and response * Fix go ci (wechaty#91) * Fix go ci * Update go.yml * add go_package * debug github action * debug github action * debug github action * keep the latest betterproto version (wechaty#92) * Use metadata (wechaty#93) * use metadata send extra info, remove extra attributes in stream message * 0.18.2 * use common message to send FileBox * rename FileBoxMessage to FileBoxChunk * use data instead of chunk * 0.18.3 * Update README.md * Improve stream message (wechaty#95) * improve stream message definition * 0.18.4 * change names * wip... * normalize name * 0.18.5 * normalize name * 0.18.6 * rename request & responses for more robust * clean name * 0.18.7 Co-authored-by: Huan LI (李卓桓) <zixia@zixia.net> * Export file box (wechaty#98) * export filebox from generated ts file * 0.18.8 * add some stream notices comments * 0.18.9 * fix file rename * 0.18.10 * link to wechaty#99 * 0.18.11 * fix go-grpc generate failed (wechaty#101) * 0.18.12 * fix .net grpc for the new file file_box.proto and update TargetFramework to netstandard2.0 (wechaty#104) * init openapi * Rename & Add OpenAPI Specification Generator (wechaty#107) * rename npm name to wechaty-grpc (wechaty#106) * add grpc http annotations (wip) * add grpc gateway image * add swagger info annotation * make payload dirty restful * fix name * add more restful endpoint definitions * fix streaming methods * better protoc tools installer script * clean openapi scripts * rename src/index -> src/mod * generate proto js files with annotation * 0.19.1 * add gRPC Web example * 0.19.2 * wechaty-grpc v0.20 * 0.20.1 * lint * check protoc version to make sure >= 3.5 (wechaty#116) * test ok * upgrade all deps * add more node version for testing * 0.20.2 * use @master version of github actions, enable cache * install 3rd party protos * 0.20.3 * fix npm publish * 0.20.4 * add openApi & proto for export (wechaty#119) * add openApi & proto for export * open-api -> openapi * 0.20.5 * Pypi rename wechaty grpc (wechaty#118) * follow latest grpc proto annotations & rename * deprecate merge-rpoto.sh (wechaty#46) * install third party proto files * 0.20.5 * install proto by github actions * 0.20.6 * add cache for pypi install * 0.20.7 * use abs path for install * 0.20.8 * explicit python3 & pip3 * 0.20.9 * 0.20.10 * 0.20.11 * sync swagger version to gRPC * 0.20.12 * compatible with grpc-dynamic-gateway (konsumer/grpc-dynamic-gateway#50) * cean * fix * 0.20.13 * use proto full path & fix openapi * 0.20.14 * fix python proto path * 0.20.15 * add openapi link * 0.20.16 * a workaround to fix issue wechaty#120 * clean * 0.20.17 * fix name * 0.20.18 * specify beta version for install * 0.20.19 Co-authored-by: Huan (李卓桓) <zixia@zixia.net> Co-authored-by: wj-Mcat <1435130236@qq.com> Co-authored-by: 犀利豆 <diaozxin@163.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: 一路向北 <zhangchunsheng423@gmail.com> Co-authored-by: Yuan Gao <wind.memory.cn@gmail.com> Co-authored-by: Darren <jesn2013@hotmail.com> Co-authored-by: 小雨 <614422099@QQ.com> Co-authored-by: Chao Fei <dchaofei@163.com>

merge master

windmemory

Please fix the comments.

proto/wechaty/puppet/friendship.proto

windmemory · 2021-03-12T03:29:27Z

Seems like we need to fix this before we move forward on this PR:

wechaty/puppet/friendship.proto: is a proto3 file that contains optional fields, but code generator protoc-gen-grpc hasn't been updated to support optional fields in proto3. Please ask the owner of this code generator to support proto3 optional.--grpc_out:

From https://github.com/wechaty/grpc/pull/122/checks?check_run_id=2085158012

huan · 2021-03-12T16:30:33Z

@windmemory It seems that we are running into #109

I hope the grpc ecosystem that we are using can support this new featuree.

We have 2 options now:

Try to upgrade our tools to support optional with proto3, this will be the best choice

If we can not upgrade our tools to support it, then we can use import "google/protobuf/wrappers.proto like other optional fields.

grpc/proto/wechaty/puppet/contact.proto

Lines 104 to 107 in b5e4cc9

    
           message ContactCorporationRemarkRequest { 
        
             string contact_id = 1; 
        
             google.protobuf.StringValue corporation_remark = 2; 
        
           }

windmemory · 2021-03-12T16:47:23Z

Vote for wrapper for now, since using wrapper won't block this feature to be done.

huan · 2021-03-12T16:50:39Z

I'm ok with that, please go ahead with it.

windmemory

Looks good to me, approved!

merge master for forward message

windmemory · 2021-03-17T09:29:46Z

Let's bump the version so we can automatically publish it after we merge this PR.

proto/wechaty/puppet/friendship.proto

…iter_room_id

…to add-room-member

huan

LGTM

huan · 2021-03-17T15:08:35Z

Thank you very much for adding this new feature to our gRPC service!

su-chang and others added 4 commits March 9, 2021 17:57

Merge pull request #2 from wechaty/master

e3515e5

merge master

feat: add options to FriendshipAddRequest

0bd5011

0.20.20

3224517

su-chang requested a review from huan March 9, 2021 11:57

fix: bug

b4b1df0

windmemory requested changes Mar 11, 2021

View reviewed changes

proto/wechaty/puppet/friendship.proto Outdated Show resolved Hide resolved

su-chang added 2 commits March 11, 2021 11:45

fix: add strong type FriendshipAddOptions for FriendshipAddRequest

6bc6dbd

fix: rename attr name

934cbb1

huan reviewed Mar 11, 2021

View reviewed changes

proto/wechaty/puppet/friendship.proto Outdated Show resolved Hide resolved

fix: add optional for FriendshipAddOptions

8b577f5

su-chang requested a review from windmemory March 12, 2021 01:50

windmemory mentioned this pull request Mar 12, 2021

Add room member wechaty/puppet-service#127

Merged

fix: use google.protobuf.StringValue for optional

6a559b1

su-chang requested a review from huan March 15, 2021 06:20

windmemory previously approved these changes Mar 17, 2021

View reviewed changes

Merge branch 'master' into add-room-member

a296d40

su-chang dismissed windmemory’s stale review via a296d40 March 17, 2021 08:46

su-chang added 2 commits March 17, 2021 17:10

Merge pull request #3 from wechaty/master

f268c24

merge master for forward message

Merge branch 'master' into add-room-member

998cc8f

windmemory previously approved these changes Mar 17, 2021

View reviewed changes

huan reviewed Mar 17, 2021

View reviewed changes

proto/wechaty/puppet/friendship.proto Outdated Show resolved Hide resolved

merge: resolve conflict

4e59f74

huan reviewed Mar 17, 2021

View reviewed changes

proto/wechaty/puppet/friendship.proto Outdated Show resolved Hide resolved

fix: keep hello as string type, and rename inviter_contact_id and inv…

2f33a7c

…iter_room_id

su-chang added 2 commits March 17, 2021 18:09

Merge branch 'add-room-member' of https://github.com/su-chang/grpc in…

945ae2f

…to add-room-member

0.21.2

ab72fd8

su-chang dismissed windmemory’s stale review via ab72fd8 March 17, 2021 10:09

windmemory approved these changes Mar 17, 2021

View reviewed changes

huan approved these changes Mar 17, 2021

View reviewed changes

huan merged commit 920bebd into wechaty:master Mar 17, 2021

su-chang deleted the add-room-member branch March 18, 2021 01:45

su-chang added a commit to su-chang/grpc that referenced this pull request Mar 18, 2021

Add room member (wechaty#122) (#4)

ee6c56c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add room member #122

Add room member #122

su-chang commented Mar 9, 2021

windmemory left a comment •

edited

Loading

windmemory commented Mar 12, 2021

huan commented Mar 12, 2021

windmemory commented Mar 12, 2021

huan commented Mar 12, 2021

windmemory left a comment

windmemory commented Mar 17, 2021

huan left a comment

huan commented Mar 17, 2021

Add room member #122

Add room member #122

Conversation

su-chang commented Mar 9, 2021

windmemory left a comment • edited Loading

Choose a reason for hiding this comment

windmemory commented Mar 12, 2021

huan commented Mar 12, 2021

windmemory commented Mar 12, 2021

huan commented Mar 12, 2021

windmemory left a comment

Choose a reason for hiding this comment

windmemory commented Mar 17, 2021

huan left a comment

Choose a reason for hiding this comment

huan commented Mar 17, 2021

windmemory left a comment •

edited

Loading