run tests against MySQL and PostgreSQL DB engines #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 18 18
Lines 329 329
Branches 34 34
=========================================
Hits 329 329 Continue to review full report at Codecov.
|
sobolevn
reviewed
Sep 11, 2020
| @@ -55,3 +91,7 @@ jobs: | |||
| uses: codecov/codecov-action@v1 | |||
| with: | |||
| file: ./coverage.xml | |||
|
|
|||
| - name: Stop docker-compose services | |||
There was a problem hiding this comment.
Do we really need to stop them? Or can we just end the build?
There was a problem hiding this comment.
I am not 100% sure, so I will double-check it, but personally I think it's good practice to clean resources explicitly
skarzi
force-pushed
the
issue-107
branch
2 times, most recently
from
fc35af1
to
93c1272
Compare
sobolevn
approved these changes
Nov 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #107
Things nice to have (now or in future PRs):
.envfile indjango_test_app/django_test_app/settings.py(usually, I'm using django-environ for this), to make local development easier. Alternatively, we can add some service todocker-compose.ymlthat will make local development even easier.network: hostinstead ofportsbinding, so it will be easier to run services locally (this will probably require to usedocker-compose.ci.ymlfor CI anddocker-compose.override.ymlfor local development)wheelto avoid using legacysetup.py installwhen installing additional dependencies