Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable foreign key checks when dropping tables on MySQL #149

Merged
merged 1 commit into from
Nov 29, 2020
Merged

Conversation

skarzi
Copy link
Collaborator

@skarzi skarzi commented Nov 28, 2020

Closes #122

This is a quick solution for problems with MySQL and drop_models_tables. It's not an ideal solution, better one (but also with more time consuming and verbose implementation) is described in #122 (comment)

On branch test-mysql-drop-table-fix you can find this branch merged to branch from #129, where all tests are running against MySQL (started in a container), so we can see this solves #122 - https://github.com/wemake-services/django-test-migrations/actions/runs/389114796

@skarzi skarzi requested a review from sobolevn November 28, 2020 22:00
@skarzi skarzi self-assigned this Nov 28, 2020
@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #149 (8459985) into master (f6958d5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #149   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          327       329    +2     
  Branches        33        34    +1     
=========================================
+ Hits           327       329    +2     
Impacted Files Coverage Δ
django_test_migrations/sql.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6958d5...8459985. Read the comment docs.

@skarzi skarzi merged commit 40f933b into master Nov 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the issue-122 branch November 29, 2020 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apply_initial_migration fails
2 participants