-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: add missing license header, update Makefile (#120)
<!-- 感谢您提交一个 Pull Request! --> #### 自查 PR 结构 <!-- 自查通过后在方框中打一个 x 就可以勾选,如果需要访问关于commit 签名的信息,可以访问 https://docs.github.com/zh/authentication/managing-commit-signature-verification/signing-commits 一个可能的标题示例: `[BREAKING CHANGE] feat(core): add new feature` --> - [x] PR 标题符合这个格式: \<type\>(optional scope): \<description\> - [x] 此 PR 标题的描述以用户为导向,足够清晰,其他人可以理解。 - [x] 我已经对所有 commit 提供了签名(GPG 密钥签名、SSH 密钥签名) - [ ] 这个 PR 属于强制变更/破坏性更改 > 如果是,请在 PR 标题中添加 `BREAKING CHANGE` 前缀,并在 PR 描述中详细说明。 #### 这个 PR 的类型是什么? <!-- 添加以下类型的一种: build: 影响构建系统或外部依赖项的更改 (常用 scope: gulp, broccoli, npm) ci: 更改我们的 CI 配置文件和脚本 (常用 scope: Travis, Circle, BrowserStack, SauceLabs) docs: 只包含文档的更改 feat: 一个新的特性 optimize: 对已有代码的优化 fix: 修正 bug perf: 对代码的性能提升 refactor: 重构,或代码更改既没有修复错误也没有添加功能 style: 不影响代码含义的更改 (空白行/空格, 格式优化, 缺失的分号, etc.) test: 添加缺失的测试或更正现有的测试 chore: 构建过程或辅助工具和库(如文档生成)的变更 --> chore #### 这个 PR 做了什么 / 我们为什么需要这个 PR? <!-- 对于每次的Code Review,我们都需要一个清晰的 PR 描述,以便 Reviewer 能够理解 PR 的目的。 这是对 Reviewer 一个很好的引导,减轻 Review 的难度和压力,同时便于 PR 更快的通过 --> 补充在 #116 中没有添加的 test license header,同时在 Makefile 中的 verify 方法添加 license 检查 #### (可选)这个 PR 解决了哪个/些 issue? <!-- PR 合并时会自动关闭链接问题 用法: `Fixes #<issue number>`, 或者 `Fixes (粘贴 issue 链接)`. --> #### 对 Reviewer 预留的一些提醒
- Loading branch information
Showing
4 changed files
with
50 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters