Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add missing license header, update Makefile #120

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Conversation

ozline
Copy link
Member

@ozline ozline commented Dec 1, 2024

自查 PR 结构

  • PR 标题符合这个格式: <type>(optional scope): <description>

  • 此 PR 标题的描述以用户为导向,足够清晰,其他人可以理解。

  • 我已经对所有 commit 提供了签名(GPG 密钥签名、SSH 密钥签名)

  • 这个 PR 属于强制变更/破坏性更改

如果是,请在 PR 标题中添加 BREAKING CHANGE 前缀,并在 PR 描述中详细说明。

这个 PR 的类型是什么?

chore

这个 PR 做了什么 / 我们为什么需要这个 PR?

补充在 #116 中没有添加的 test license header,同时在 Makefile 中的 verify 方法添加 license 检查

(可选)这个 PR 解决了哪个/些 issue?

对 Reviewer 预留的一些提醒

@ozline ozline requested review from jiuxia211 and a team as code owners December 1, 2024 12:11
@ozline ozline changed the title chore: add missing license header chore: add missing license header, Dec 1, 2024
@ozline ozline changed the title chore: add missing license header, chore: add missing license header, update Makefile Dec 1, 2024
@jiuxia211 jiuxia211 merged commit 1d07a73 into main Dec 1, 2024
8 checks passed
@jiuxia211 jiuxia211 deleted the add-license branch December 1, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants