Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing solution configuration mappings for projects which don't have a platform #25

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

icnocop
Copy link
Contributor

@icnocop icnocop commented Aug 23, 2023

πŸ“« Addressed Issue(s)

Closes #24

πŸ“„ Description

Support parsing solution configuration mappings for projects which don't have a platform

βœ… Checks

  • My PR adheres to the general code-style of this project (look at other code if you're unsure)
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the automated tests have passed

β„Ή Additional Information

This PR requires #22 to be merged first.

@icnocop icnocop requested a review from wgnf as a code owner August 23, 2023 22:36
Copy link
Owner

@wgnf wgnf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Rami,

thank you for these awesome changes! There are just some minor things that i noticed.

Appreciate the help! πŸš€

src/SlnParser.Tests/IntegrationTests.cs Outdated Show resolved Hide resolved
src/SlnParser.Tests/IntegrationTests.cs Outdated Show resolved Hide resolved
src/SlnParser.Tests/IntegrationTests.cs Outdated Show resolved Hide resolved
@wgnf wgnf added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Aug 24, 2023
@wgnf
Copy link
Owner

wgnf commented Aug 25, 2023

#22 has been merged now, can you merge the origin/main-branch into your forked branch?

@icnocop icnocop requested a review from wgnf August 25, 2023 07:55
@icnocop
Copy link
Contributor Author

icnocop commented Aug 25, 2023

I have synchronized the branches and resolved the code review comments.

Thank you.

@wgnf
Copy link
Owner

wgnf commented Aug 25, 2023

Thanks for the changes, they look good! πŸ‘πŸΌ
Just as a general tip: Resolving comments should be done by the reviewer (me in this case), because that person is the one deciding if the changes resolve the comment (except for praises).

@wgnf wgnf merged commit 1f7285f into wgnf:main Aug 25, 2023
1 check passed
@wgnf
Copy link
Owner

wgnf commented Aug 25, 2023

Included in version 3.0.0 that has just been released (also see https://github.com/wgnf/SlnParser/releases/tag/v3.0.0). Thanks a lot @icnocop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Support parsing solution configuration mappings for projects which don't have a platform
2 participants