Skip to content

Commit

Permalink
Meta: add more guidance for how to handle test PRs
Browse files Browse the repository at this point in the history
Prompted by web-platform-tests/wpt#4034.

Part of #1849.
  • Loading branch information
foolip committed Oct 20, 2016
1 parent ad778cb commit d1a5da6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ To preview your changes locally, follow the instructions in the [html-build repo

#### Tests

For normative changes, a corresponding [web-platform-tests](https://github.com/w3c/web-platform-tests) PR is highly appreciated. The author and reviewer can be different from the HTML Standard PR. If testing is not practical, please explain why and if appropriate [file an issue](https://github.com/w3c/web-platform-tests/issues/new) to follow up later.
For normative changes, a corresponding [web-platform-tests](https://github.com/w3c/web-platform-tests) PR is highly appreciated. The author and reviewer can be different from the HTML Standard PR. If current behavior is unclear, writing tests first can help inform the discussion. Typically, both PRs will be merged at the same time.

If testing is not practical, please explain why and if appropriate [file an issue](https://github.com/w3c/web-platform-tests/issues/new) to follow up later.

#### Formatting

Expand Down
4 changes: 3 additions & 1 deletion TEAM.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ This document contains info used by the team maintaining the standard. Mostly bo

Each change needs to result in a single commit on the master branch, with no merge commits. The green squash and merge button is OK to use, but be sure to tidy up the commit message per [guidelines for writing good commit messages](https://github.com/erlang/otp/wiki/Writing-good-commit-messages).

For normative changes, ask for a [web-platform-tests](https://github.com/w3c/web-platform-tests) PR if testing is practical and not overly burdensome. If a follow up issue is filed, add the `html` label.
For normative changes, ask for a [web-platform-tests](https://github.com/w3c/web-platform-tests) PR if testing is practical and not overly burdensome. Aim to merge both PRs at the same time. If one PR is approved but the other needs more work, add the `do not merge yet` label.

If a follow-up issue is filed, add the `html` label.

### Fetching and reviewing pull requests from forks

Expand Down

0 comments on commit d1a5da6

Please sign in to comment.