Manual test for click in progress flag #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See whatwg/html#1925 for context.
|
Reviewers for this pull request are: @Ms2ger, @ayg, @gsnedders, @jdm, @jgraham, @plehegar, @sideshowbarker, @zcorpan, and @zqzhang. |
zcorpan
approved these changes
Oct 20, 2016
|
Yeah maybe, would be good if @foolip wrote down the guidelines for that somewhere. And maybe we should add a WPT label for that kind of thing too. |
foolip
added a commit
to whatwg/html
that referenced
this pull request
Oct 20, 2016
Prompted by web-platform-tests/wpt#4034. Part of #1849.
foolip
added a commit
to whatwg/html
that referenced
this pull request
Oct 20, 2016
Prompted by web-platform-tests/wpt#4034. Part of #1849.
foolip
added a commit
to whatwg/html
that referenced
this pull request
Oct 20, 2016
Prompted by web-platform-tests/wpt#4034. Part of #1849.
zcorpan
pushed a commit
to whatwg/html
that referenced
this pull request
Oct 20, 2016
Prompted by web-platform-tests/wpt#4034. Part of #1849.
annevk
added a commit
to whatwg/html
that referenced
this pull request
Oct 20, 2016
There are two major changes here: * Any click event can cause activation behavior to run. No exceptions. * The "click in progress flag" is now restricted to the click() method, as it already is in Firefox. The other changes are editorial: * "Activation behavior" is now associated with an object at all times (and cannot be conditionally associated) * "Legacy-pre-activation behavior" and "legacy-canceled-activation behavior" are now more clearly only relevant for input elements in either the Checkbox or Radio Button state. * Various concepts such as "run synthetic click activation steps" and "nearest activatable element" are gone as they are obsoleted by the DOM Standard or the aforementioned normative changes. Tests related to this change: * web-platform-tests/wpt#3974 * web-platform-tests/wpt#4034 Changes to the DOM Standard that were necessary for this change: * whatwg/dom#342 * whatwg/dom#346 Fixes #1394.
FirefoxTesting revision 5e74f15 |
ChromeTesting revision 5e74f15 |
|
The spec change has been merged, is this ready now? |
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
Prompted by web-platform-tests/wpt#4034. Part of whatwg#1849.
alice
pushed a commit
to alice/html
that referenced
this pull request
Jan 8, 2019
There are two major changes here: * Any click event can cause activation behavior to run. No exceptions. * The "click in progress flag" is now restricted to the click() method, as it already is in Firefox. The other changes are editorial: * "Activation behavior" is now associated with an object at all times (and cannot be conditionally associated) * "Legacy-pre-activation behavior" and "legacy-canceled-activation behavior" are now more clearly only relevant for input elements in either the Checkbox or Radio Button state. * Various concepts such as "run synthetic click activation steps" and "nearest activatable element" are gone as they are obsoleted by the DOM Standard or the aforementioned normative changes. Tests related to this change: * web-platform-tests/wpt#3974 * web-platform-tests/wpt#4034 Changes to the DOM Standard that were necessary for this change: * whatwg/dom#342 * whatwg/dom#346 Fixes whatwg#1394.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See whatwg/html#1925 for context.