Meta: add more guidance for how to handle test PRs #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,7 +6,7 @@ This document contains info used by the team maintaining the standard. Mostly bo | |||
|
|
|||
| Each change needs to result in a single commit on the master branch, with no merge commits. The green squash and merge button is OK to use, but be sure to tidy up the commit message per [guidelines for writing good commit messages](https://github.com/erlang/otp/wiki/Writing-good-commit-messages). | |||
|
|
|||
| For normative changes, ask for a [web-platform-tests](https://github.com/w3c/web-platform-tests) PR if testing is practical and not overly burdensome. If a follow up issue is filed, add the `html` label. | |||
| For normative changes, ask for a [web-platform-tests](https://github.com/w3c/web-platform-tests) PR if testing is practical and not overly burdensome. Merge both PRs at the same time. If a follow up issue is filed, add the `html` label. | |||
There was a problem hiding this comment.
nit: s/follow up issue/follow-up issue/
foolip
force-pushed
the
more-test-guidance
branch
from
e6ca8b1
to
3292556
Compare
|
This is just my hunch of where we'll naturally end up, in each case doing things in whichever order seems best. Not sure if more can be done to clarify that two PRs belong together, I guess the main risk is someone not in the loop merging a WPT change? |
|
Maybe say to add the "do not merge yet" label (wpt has it also) |
Prompted by web-platform-tests/wpt#4034. Part of #1849.
foolip
force-pushed
the
more-test-guidance
branch
from
3292556
to
d1a5da6
Compare
|
Done. |
zcorpan
approved these changes
Oct 20, 2016
|
Instead of typically, make it an instruction? "Attempt to merge both PRs at the same time." |
|
Never mind, missed TEAM changes. LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by web-platform-tests/wpt#4034.
Part of #1849.