Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COEP reporting "blocked-url" should probably be "blockedURL" #5818

Closed
domenic opened this issue Aug 12, 2020 · 4 comments
Closed

COEP reporting "blocked-url" should probably be "blockedURL" #5818

domenic opened this issue Aug 12, 2020 · 4 comments
Labels
topic: cross-origin-embedder-policy Issues and ideas around the new "require CORP for subresource requests and frames and etc" proposal

Comments

@domenic
Copy link
Member

domenic commented Aug 12, 2020

See related spec discussion in #5518 (comment) where we discovered that all modern reports use camelCase.

@yutakahirano, does this seem like something we can change?
@domenic domenic added the topic: cross-origin-embedder-policy Issues and ideas around the new "require CORP for subresource requests and frames and etc" proposal label Aug 12, 2020
@yutakahirano
Copy link
Member

I think we can, although we've already shipped COEP reporting for months.

If we chose to change the names, I'll have duplicated names (blocked-url and blockedURL) for some time in Chrome.

@annevk
Copy link
Member

annevk commented Aug 18, 2020

I suggest we change then. Thanks for raising this @domenic!

@yutakahirano
Copy link
Member

yutakahirano commented Aug 20, 2020 •
edited
Loading

Do you prefer blockedURL or blockedUrl? I have the impression that the former is more common but COOP reporting uses openerUrl.

yutakahirano added a commit to whatwg/fetch that referenced this issue Aug 20, 2020
@yutakahirano
Augment COEP violation report
cc7b5af 
 - "blocked-url" is renamed to "blockedURL" (whatwg/html#5818).
 - Added "disposition" (whatwg/html#5391).
 - Added "destination" (whatwg/html#5391).

The CORP check now takes "destination" as a parameter.
yutakahirano added a commit to yutakahirano/html that referenced this issue Aug 20, 2020
@yutakahirano
Augment COEP violation report
6d9f99c 
 - "blocked-url" is renamed to "blockedURL" (whatwg#5818).
 - Added "disposition" (whatwg#5391).
 - Added "destination" (whatwg#5391).

The CORP check now takes "destination" as a parameter.

Fixes whatwg#5391 and whatwg#5818.
@yutakahirano yutakahirano mentioned this issue Aug 20, 2020
Merged
3 tasks
yutakahirano added a commit to yutakahirano/html that referenced this issue Aug 20, 2020
@yutakahirano
Augment COEP violation report
ff00128 
 - "blocked-url" is renamed to "blockedURL" (whatwg#5818).
 - Added "disposition" (whatwg#5391).

Fixes whatwg#5391 and whatwg#5818.
@yutakahirano yutakahirano mentioned this issue Aug 20, 2020
Merged
@annevk
Copy link
Member

annevk commented Aug 20, 2020

See https://url.spec.whatwg.org/#url-apis-elsewhere. That should be changed to openerURL.

domenic pushed a commit to whatwg/fetch that referenced this issue Aug 21, 2020
@yutakahirano
Augment COEP violation report
ad9a84a 
* Rename "blocked-url" to "blockedURL" (whatwg/html#5818).
* Add "disposition" (whatwg/html#5391).
* Add "destination" (whatwg/html#5391).
mfreed7 pushed a commit to mfreed7/html that referenced this issue Sep 11, 2020
@yutakahirano @mfreed7
Augment COEP violation report
f21bb0a 
* Rename "blocked-url" to "blockedURL"; fixes whatwg#5818.
* Add "disposition" and "destination"; closes whatwg#5391.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic: cross-origin-embedder-policy Issues and ideas around the new "require CORP for subresource requests and frames and etc" proposal
Milestone
No milestone
Development

No branches or pull requests
3 participants
@domenic @annevk @yutakahirano