Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Augment COEP violation report #5848

Merged
merged 2 commits into from
Aug 21, 2020
Merged

Augment COEP violation report #5848

merged 2 commits into from
Aug 21, 2020

Conversation

yutakahirano
Copy link
Member

@yutakahirano yutakahirano commented Aug 20, 2020 •
edited by pr-preview bot
Loading

Fixes #5391 and #5818.

  • HTML (this PR)
    • Rename "blockd-url" to "blockedURL" in the COEP inheritance violation report.
    • Add "disposition" for the COEP inheritance violation report.
  • fetch: Augment COEP violation report fetch#1079
    • The CORP check now takes destination as a parameter.
    • Rename "blockd-url" to "blockedURL" in the CORP violation report.
    • Add "disposition" for the CORP violation report.
    • Add "destination" for the CORP violation report.
  • service worker: Give the empty destination to the CORP check w3c/ServiceWorker#1531
    • Provide the empty string as destination to the CORP check.

(See WHATWG Working Mode: Changes for more details.)

/browsing-the-web.html ( diff )
/origin.html ( diff )

@yutakahirano
Augment COEP violation report
ff00128 
 - "blocked-url" is renamed to "blockedURL" (whatwg#5818).
 - Added "disposition" (whatwg#5391).

Fixes whatwg#5391 and whatwg#5818.
@yutakahirano yutakahirano force-pushed the yhirano/coep-report-properties branch from 6d9f99c to ff00128 Compare August 20, 2020 06:42
@yutakahirano yutakahirano mentioned this pull request Aug 20, 2020
Merged
domenic
domenic approved these changes Aug 20, 2020
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! @annevk, can you comment on Mozilla's interest in these changes? Then we can merge all the PRs together when tests are ready.

source Show resolved Hide resolved
@domenic domenic added the topic: cross-origin-embedder-policy Issues and ideas around the new "require CORP for subresource requests and frames and etc" proposal label Aug 20, 2020
@annevk
Copy link
Member

annevk commented Aug 21, 2020

Mozilla is okay with these changes. They don't seem to expose more information than would otherwise be exposed, align with naming guidelines, and give developers a bit more information to go on. (I'm not sure when Firefox will prototype/ship reporting.)

yutakahirano added a commit to web-platform-tests/wpt that referenced this pull request Aug 21, 2020
@yutakahirano
Fix COEP reporting tests
34f8136 
This is for whatwg/html#5848.
@yutakahirano yutakahirano mentioned this pull request Aug 21, 2020
Merged
@yutakahirano
Copy link
Member Author

Thanks, tests are available at web-platform-tests/wpt#25177.

@domenic domenic merged commit 8c90eb6 into whatwg:master Aug 21, 2020
yutakahirano added a commit to web-platform-tests/wpt that referenced this pull request Aug 22, 2020
@yutakahirano @domenic
Fix COEP reporting tests (#25177)
8b381a6 
This is for whatwg/html#5848.

Co-authored-by: Domenic Denicola <d@domenic.me>
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 25, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
3d7c89f 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time)
 - Add "disposition".
 - Add "destination".

There were subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Aug 25, 2020
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 25, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
62d7dbe 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 26, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
b117625 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 26, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
0ae3fb1 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 27, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
7362041 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
blueboxd pushed a commit to blueboxd/chromium-legacy that referenced this pull request Aug 27, 2020
@yutakahirano
Augment COEP violation report
ad15c8c 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(web-platform-tests/wpt#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373970
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802161}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 27, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
1a8ba9d 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373970
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802161}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Aug 27, 2020
@yutakahirano @chromium-wpt-export-bot
Augment COEP violation report
792570a 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373970
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802161}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Aug 27, 2020
@yutakahirano @moz-wptsync-bot
Bug 1660447 [wpt PR 25177] - Fix COEP reporting tests, a=testonly
79282d3 
Automatic update from web-platform-tests
Fix COEP reporting tests (#25177)

This is for whatwg/html#5848.

Co-authored-by: Domenic Denicola <d@domenic.me>
--

wpt-commits: 8b381a62df79215dfe620cdec5cd8e18f66e099e
wpt-pr: 25177
@yutakahirano yutakahirano mentioned this pull request Sep 1, 2020
Merged
ambroff pushed a commit to ambroff/gecko that referenced this pull request Nov 4, 2020
@yutakahirano @moz-wptsync-bot
Bug 1660447 [wpt PR 25177] - Fix COEP reporting tests, a=testonly
d96954d 
Automatic update from web-platform-tests
Fix COEP reporting tests (#25177)

This is for whatwg/html#5848.

Co-authored-by: Domenic Denicola <d@domenic.me>
--

wpt-commits: 8b381a62df79215dfe620cdec5cd8e18f66e099e
wpt-pr: 25177
mjfroman pushed a commit to mjfroman/moz-libwebrtc-third-party that referenced this pull request Oct 14, 2022
@yutakahirano @copybara-github
Augment COEP violation report
9d29379 
This implements whatwg/html#5848.

 - Add "blockedURL" (we'll keep "blocked-url" for some time).
 - Add "disposition".
 - Add "destination".

There are subtle bugs in WPTs
(web-platform-tests/wpt#25177). Fix them.

Bug: 1119676
Change-Id: I9b83f18d9881b2742bafd88405b57645a67cac49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373970
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Domenic Denicola <domenic@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802161}
GitOrigin-RevId: ad15c8ce99ced75169e377b7aa88302b98b47d2a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
topic: cross-origin-embedder-policy Issues and ideas around the new "require CORP for subresource requests and frames and etc" proposal
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more information to COEP reporting
3 participants
@yutakahirano @annevk @domenic