usecache to updateviacache #2515

jakearchibald · 2017-04-07T14:37:32Z

jakearchibald · 2017-04-07T14:38:01Z

I suggest @sideshowbarker for review. I've yet to write tests.

sideshowbarker · 2017-04-07T15:05:56Z

source

@@ -3770,7 +3770,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute
     <li><dfn data-x-href="https://w3c.github.io/ServiceWorker/#dfn-serviceworker-link">serviceworker link</dfn></li>
     <li><dfn data-x-href="https://w3c.github.io/ServiceWorker/#serviceworker"><code>ServiceWorker</code></dfn> interface</li>
     <li><dfn data-x-href="https://w3c.github.io/ServiceWorker/#serviceworkercontainer"><code>ServiceWorkerContainer</code></dfn> interface</li>
-     <li><dfn data-x-href="https://w3c.github.io/ServiceWorker/#dfn-use-cache">use cache</dfn></li>
+     <li><dfn data-x-href="https://w3c.github.io/ServiceWorker/#dfn-update-via-cache">update via cache mode</dfn></li>
    </ul>


Should add this:

<li><dfn data-x-href="https://w3c.github.io/ServiceWorker/#enumdef-serviceworkerupdateviacache">ServiceWorkerUpdateViaCache</dfn> enumeration</li>

sideshowbarker · 2017-04-07T15:08:45Z

source

@@ -12847,7 +12847,7 @@ interface <dfn>HTMLLinkElement</dfn> : <span>HTMLElement</span> {
  [<span>CEReactions</span>] attribute DOMString <span data-x="dom-link-referrerPolicy">referrerPolicy</span>;
  [<span>CEReactions</span>] attribute USVString <span data-x="dom-link-scope">scope</span>;
  [<span>CEReactions</span>] attribute <span>WorkerType</span> <span data-x="dom-link-workertype">workerType</span>;
-  [<span>CEReactions</span>] attribute boolean <span data-x="dom-link-useCache">useCache</span>;
+  [<span>CEReactions</span>] attribute boolean <span data-x="dom-link-updateViaCache">updateViaCache</span>;


That should be:

[CEReactions] attribute ServiceWorkerUpdateViaCache updateViaCache

It should actually be a DOMString, not a ServiceWorkerUpdateViaCache, since the latter implies case-sensitivity which is controversial and doesn't fit with any other attribute on the platform (see #1665).

So you're just deciding that new attributes should not be case-sensitive while that argument isn't sorted? That seems flawed.

sideshowbarker · 2017-04-07T15:17:26Z

source

-  data-x="rel-serviceworker">serviceworker</code> keyword.</p>
+  <p>The <dfn><code data-x="attr-link-updateviacache">updateviacache</code></dfn> attribute is an
+  <span>enumerated attribute</span> that specifies the <span>update via cache mode</span> for a
+  <span>service worker registration</span>. The attribute must not be specified on <code>link</code>


Should add the following:

The attribute's keywords are "<code data-x="">imports</code>", "<code data-x="">all</code>", and "<code data-x="">never</code>, which map to the respective states imports, all, and never. The missing value default is the imports state.

domenic · 2017-04-08T01:41:19Z

Another model you could base this on is referrerpolicy="", which takes great pains to not duplicate the states inside HTML, so that it's easier to update the source document. However, that might not be very important here, since in theory this list should not change much (as opposed to referrer policies where new ones seem to get added often).

jakearchibald · 2017-04-10T16:25:47Z

@sideshowbarker thanks for the feedback - I've made the corrections.

@domenic @annevk I don't have any opinion on the "case sensitive or not" thing. I guess this is a recent change, as workerType (which I was copying) appears to be case sensitive.

sideshowbarker · 2017-04-13T04:44:36Z

I think this awaits resolution on #2515 (comment) and I guess also on tests, so added labels for those

wanderview · 2017-04-13T13:42:18Z

I think case-sensitive would be preferable.

domenic · 2017-04-13T13:47:49Z

We're not going to be inconsistent with the rest of HTML here. See discussion in #1665.

wanderview · 2017-04-13T14:22:14Z

I forgot this was a <link> attribute. We haven't implemented that feature yet. I thought we were talking about the js enumeration. Sorry for my confusion.

This is part of w3c/ServiceWorker#1104

jakearchibald · 2017-06-05T16:13:09Z

@domenic so is https://html.spec.whatwg.org/multipage/semantics.html#the-link-element:dom-link-workertype also doing it wrong?

domenic · 2017-06-05T16:26:14Z

@jakearchibald yep, I guess I didn't realize that got merged... will fix...

jakearchibald · 2017-06-06T13:07:21Z

Updated PR. It should now be case insensitive.

domenic · 2017-06-06T13:09:31Z

source


  <p>The <dfn><code data-x="dom-link-workerType">workerType</code></dfn> IDL attribute must
  <span>reflect</span> the <code data-x="attr-link-workertype">workertype</code> content
-  attribute.</p>
+  attribute, <span>limited to only known values</span>.</p>


This change seems superfluous? We need to fix this section anyway so not sure why we'd change it.

Ugh, copy-paste error, sorry. Fixing.

domenic · 2017-06-06T13:10:54Z

source

+     <th> <code data-x="">updateviacache</code>
+     <td> <code data-x="attr-link-updateviacache">link</code>
+     <td> <span>update via cache mode</span> for a <span>service worker registration</span> (for <code data-x="attr-link-rel">rel</code>="<code data-x="rel-serviceworker">serviceworker</code>")
+     <td> "<code data-x="">imports</code>"; "<code data-x="">all</code>"; "<code data-x="">never</code>"


In the interest of not duplicating stuff across specs, let's replace this with Update via cache mode (cf. referrer policy)

domenic · 2017-06-06T14:08:14Z

We're still waiting on tests for this, right?

Be sure to update https://github.com/w3c/web-platform-tests/blob/master/html/dom/elements-metadata.js :)

jakearchibald · 2017-06-06T14:09:23Z

Yep, will do the tests. I wasn't aware of https://github.com/w3c/web-platform-tests/blob/master/html/dom/elements-metadata.js. Cheers!

jakearchibald · 2017-06-06T15:49:59Z

I've rolled the tests into web-platform-tests/wpt#5515. I wasn't sure what to do with elements-metadata.js (I couldn't see how it was used), but I gave it a shot.

domenic · 2017-06-06T19:32:36Z

Looks good. I'll merge the spec change since those tests are still underway.

sideshowbarker requested changes Apr 7, 2017

View reviewed changes

jakearchibald mentioned this pull request Apr 8, 2017

Changing useCache boolean to updateViaCache enum w3c/ServiceWorker#1107

Merged

domenic mentioned this pull request Apr 10, 2017

Case-sensitive as="" for <link> is weird #1665

Closed

sideshowbarker approved these changes Apr 13, 2017

View reviewed changes

sideshowbarker added do not merge yet Pull request must not be merged per rationale in comment needs tests Moving the issue forward requires someone to write tests labels Apr 13, 2017

domenic mentioned this pull request Apr 25, 2017

Make <link>'s as="" attribute case-insensitive #2585

Merged

jakearchibald added 2 commits June 5, 2017 16:49

usecache to updateviacache

ca5b762

This is part of w3c/ServiceWorker#1104

Corrections following feedback

c35a7b5

Making attribute case-insensitive

055ff1b

jakearchibald force-pushed the usecache-to-updateviacache branch from 89690d4 to 055ff1b Compare June 6, 2017 13:03

Removing reference to idl enum

01db2b2

domenic reviewed Jun 6, 2017

View reviewed changes

jakearchibald and others added 2 commits June 6, 2017 14:33

Fixing copy paste error & removing cross-spec duplication

b399212

Capitalization tweak

9781403

domenic removed the do not merge yet Pull request must not be merged per rationale in comment label Jun 6, 2017

domenic added topic: workers normative change and removed needs tests Moving the issue forward requires someone to write tests labels Jun 6, 2017

domenic merged commit b5fcec0 into whatwg:master Jun 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

usecache to updateviacache #2515

usecache to updateviacache #2515

jakearchibald commented Apr 7, 2017

jakearchibald commented Apr 7, 2017 •

edited

Loading

sideshowbarker Apr 7, 2017

sideshowbarker Apr 7, 2017 •

edited

Loading

domenic Apr 8, 2017

annevk Apr 8, 2017

sideshowbarker Apr 7, 2017

domenic commented Apr 8, 2017

jakearchibald commented Apr 10, 2017

sideshowbarker commented Apr 13, 2017

wanderview commented Apr 13, 2017

domenic commented Apr 13, 2017

wanderview commented Apr 13, 2017 •

edited

Loading

jakearchibald commented Jun 5, 2017

domenic commented Jun 5, 2017

jakearchibald commented Jun 6, 2017

domenic Jun 6, 2017

jakearchibald Jun 6, 2017

domenic Jun 6, 2017

domenic commented Jun 6, 2017

jakearchibald commented Jun 6, 2017

jakearchibald commented Jun 6, 2017

domenic commented Jun 6, 2017

usecache to updateviacache #2515

usecache to updateviacache #2515

Conversation

jakearchibald commented Apr 7, 2017

jakearchibald commented Apr 7, 2017 • edited Loading

sideshowbarker Apr 7, 2017

Choose a reason for hiding this comment

sideshowbarker Apr 7, 2017 • edited Loading

Choose a reason for hiding this comment

domenic Apr 8, 2017

Choose a reason for hiding this comment

annevk Apr 8, 2017

Choose a reason for hiding this comment

sideshowbarker Apr 7, 2017

Choose a reason for hiding this comment

domenic commented Apr 8, 2017

jakearchibald commented Apr 10, 2017

sideshowbarker commented Apr 13, 2017

wanderview commented Apr 13, 2017

domenic commented Apr 13, 2017

wanderview commented Apr 13, 2017 • edited Loading

jakearchibald commented Jun 5, 2017

domenic commented Jun 5, 2017

jakearchibald commented Jun 6, 2017

domenic Jun 6, 2017

Choose a reason for hiding this comment

jakearchibald Jun 6, 2017

Choose a reason for hiding this comment

domenic Jun 6, 2017

Choose a reason for hiding this comment

domenic commented Jun 6, 2017

jakearchibald commented Jun 6, 2017

jakearchibald commented Jun 6, 2017

domenic commented Jun 6, 2017

jakearchibald commented Apr 7, 2017 •

edited

Loading

sideshowbarker Apr 7, 2017 •

edited

Loading

wanderview commented Apr 13, 2017 •

edited

Loading