-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
usecache to updateviacache #2515
Merged
domenic
merged 6 commits into
whatwg:master
from
jakearchibald:usecache-to-updateviacache
Jun 6, 2017
+20
−15
Merged
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ca5b762
usecache to updateviacache
jakearchibald c35a7b5
Corrections following feedback
jakearchibald 055ff1b
Making attribute case-insensitive
jakearchibald 01db2b2
Removing reference to idl enum
jakearchibald b399212
Fixing copy paste error & removing cross-spec duplication
jakearchibald 9781403
Capitalization tweak
domenic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3791,6 +3791,7 @@ a.setAttribute('href', 'https://example.com/'); // change the content attribute | |
<li><dfn data-x-href="https://w3c.github.io/ServiceWorker/#serviceworkercontainer"><code>ServiceWorkerContainer</code></dfn> interface</li> | ||
<li><dfn data-x-href="https://w3c.github.io/ServiceWorker/#serviceworkerglobalscope"><code>ServiceWorkerGlobalScope</code></dfn> interface</li> | ||
<li><dfn data-x-href="https://w3c.github.io/ServiceWorker/#dfn-use-cache">use cache</dfn></li> | ||
<li><dfn data-x-href="https://w3c.github.io/ServiceWorker/#dfn-update-via-cache">update via cache mode</dfn></li> | ||
</ul> | ||
|
||
</dd> | ||
|
@@ -12907,7 +12908,7 @@ interface <dfn>HTMLBaseElement</dfn> : <span>HTMLElement</span> { | |
<dd><code data-x="attr-link-sizes">sizes</code></dd> | ||
<dd><code data-x="attr-link-as">as</code></dd> | ||
<dd><code data-x="attr-link-scope">scope</code></dd> | ||
<dd><code data-x="attr-link-usecache">usecache</code></dd> | ||
<dd><code data-x="attr-link-updateviacache">updateviacache</code></dd> | ||
<dd><code data-x="attr-link-workertype">workertype</code></dd> | ||
<dd><code data-x="attr-link-color">color</code></dd> | ||
<dd>Also, the <code data-x="attr-link-title">title</code> attribute <span data-x="attr-link-title">has special semantics</span> on this element.</dd> | ||
|
@@ -12929,7 +12930,7 @@ interface <dfn>HTMLLinkElement</dfn> : <span>HTMLElement</span> { | |
[<span>CEReactions</span>] attribute DOMString <span data-x="dom-link-referrerPolicy">referrerPolicy</span>; | ||
[<span>CEReactions</span>] attribute USVString <span data-x="dom-link-scope">scope</span>; | ||
[<span>CEReactions</span>] attribute <span>WorkerType</span> <span data-x="dom-link-workertype">workerType</span>; | ||
[<span>CEReactions</span>] attribute boolean <span data-x="dom-link-useCache">useCache</span>; | ||
[<span>CEReactions</span>] attribute DOMString <span data-x="dom-link-updateviacache">updateViaCache</span>; | ||
}; | ||
<span>HTMLLinkElement</span> implements <span>LinkStyle</span>;</pre> | ||
</dd> | ||
|
@@ -13136,11 +13137,13 @@ interface <dfn>HTMLLinkElement</dfn> : <span>HTMLElement</span> { | |
specified on <code>link</code> elements that do not have a <code data-x="attr-link-rel">rel</code> | ||
attribute that contains the <code data-x="rel-serviceworker">serviceworker</code> keyword.</p> | ||
|
||
<p>The <dfn><code data-x="attr-link-usecache">usecache</code></dfn> attribute is a <span>boolean | ||
attribute</span> which sets <span>use cache</span> to true for a <span>service worker | ||
registration</span>. The attribute must not be specified on <code>link</code> elements that do not | ||
have a <code data-x="attr-link-rel">rel</code> attribute that contains the <code | ||
data-x="rel-serviceworker">serviceworker</code> keyword.</p> | ||
<p>The <dfn><code data-x="attr-link-updateviacache">updateviacache</code></dfn> attribute | ||
specifies the <span>update via cache mode</span> for a <span>service worker registration</span>. | ||
It is an <span>enumerated attribute</span>. Each <span>update via cache mode</span> is a keyword | ||
for this attribute, mapping to a state of the same name. The <span>missing value default</span> is | ||
the <i>imports</i> state. The attribute must not be specified on <code>link</code> elements that | ||
do not have a <code data-x="attr-link-rel">rel</code> attribute that contains the | ||
<code data-x="rel-serviceworker">serviceworker</code> keyword.</p> | ||
|
||
<p>The <dfn><code data-x="attr-link-workertype">workertype</code></dfn> attribute is an | ||
<span>enumerated attribute</span> that specifies the <span>service worker type</span> for a | ||
|
@@ -13200,12 +13203,13 @@ interface <dfn>HTMLLinkElement</dfn> : <span>HTMLElement</span> { | |
<p>The <dfn><code data-x="dom-link-rellist">relList</code></dfn> IDL attribute must <span | ||
data-x="reflect">reflect</span> the <code data-x="attr-link-rel">rel</code> content attribute.</p> | ||
|
||
<p>The <dfn><code data-x="dom-link-useCache">useCache</code></dfn> IDL attribute must | ||
<span>reflect</span> the <code data-x="attr-link-usecache">usecache</code> content attribute.</p> | ||
<p>The <dfn><code data-x="dom-link-updateViaCache">updateViaCache</code></dfn> IDL attribute must | ||
<span>reflect</span> the <code data-x="attr-link-updateviacache">updateviacache</code> content | ||
attribute.</p> | ||
|
||
<p>The <dfn><code data-x="dom-link-workerType">workerType</code></dfn> IDL attribute must | ||
<span>reflect</span> the <code data-x="attr-link-workertype">workertype</code> content | ||
attribute.</p> | ||
attribute, <span>limited to only known values</span>.</p> | ||
|
||
<h5>Processing the <code data-x="attr-link-media">media</code> attribute</h5> | ||
|
||
|
@@ -24070,13 +24074,14 @@ interface <dfn>HTMLHyperlinkElementUtils</dfn> { | |
<code>link</code> elements. This keyword creates an <span data-x="external resource link">external | ||
resource link</span> that is used to declare a <span>service worker registration</span> and its | ||
<span>script url</span>, <span>scope url</span>, <span data-x="service worker type">type</span>, | ||
and <span>use cache</span> setting.</p> | ||
and <span>update via cache mode</span>.</p> | ||
|
||
<p><span w-nodev>User agents must implement the processing model for <code>link</code>-element | ||
<span data-x="serviceworker link">serviceworker links</span> described in <cite>Service | ||
Workers</cite>, using the <code data-x="attr-link-href">href</code>, <code | ||
data-x="attr-link-scope">scope</code>, <code data-x="attr-link-workertype">workertype</code>, and | ||
<code data-x="attr-link-usecache">usecache</code> attributes.</span> <ref spec="SW"></p> | ||
<code data-x="attr-link-updateviacache">updateviacache</code> attributes.</span> | ||
<ref spec="SW"></p> | ||
|
||
<!--ADD-TOPIC:CSS--> | ||
<h5>Link type "<dfn><code data-x="rel-stylesheet">stylesheet</code></dfn>"</h5> | ||
|
@@ -118492,10 +118497,10 @@ interface <dfn>External</dfn> { | |
<td> Whether the <code data-x="attr-object-type">type</code> attribute and the <span>Content-Type</span> value need to match for the resource to be used | ||
<td> <span>Boolean attribute</span> | ||
<tr> | ||
<th> <code data-x="">usecache</code> | ||
<td> <code data-x="attr-link-usecache">link</code> | ||
<td> Whether to set <span>use cache</span> to true for a <span>service worker registration</span> (for <code data-x="attr-link-rel">rel</code>="<code data-x="rel-serviceworker">serviceworker</code>") | ||
<td> <span>Boolean attribute</span> | ||
<th> <code data-x="">updateviacache</code> | ||
<td> <code data-x="attr-link-updateviacache">link</code> | ||
<td> <span>update via cache mode</span> for a <span>service worker registration</span> (for <code data-x="attr-link-rel">rel</code>="<code data-x="rel-serviceworker">serviceworker</code>") | ||
<td> "<code data-x="">imports</code>"; "<code data-x="">all</code>"; "<code data-x="">never</code>" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the interest of not duplicating stuff across specs, let's replace this with |
||
<tr> | ||
<th> <code data-x="">usemap</code> | ||
<td> <code data-x="attr-hyperlink-usemap">img</code>; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems superfluous? We need to fix this section anyway so not sure why we'd change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, copy-paste error, sorry. Fixing.