Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Export dfn for “serviceworker” rel keyword #2517

Merged
merged 3 commits into from
Apr 11, 2017

Conversation

sideshowbarker
Copy link
Contributor

This is useful for the Service Worker spec, to enable a cross-reference back to
this closely-related part of the HTML spec.

See w3c/ServiceWorker#1073

source Outdated
@@ -23966,7 +23966,8 @@ interface <dfn>HTMLHyperlinkElementUtils</dfn> {
the <code data-x="rel-search">search</code> link type to enable user agents to autodiscover search
interfaces. <ref spec=OPENSEARCH></p>

<h5>Link type "<dfn><code data-x="rel-serviceworker">serviceworker</code></dfn>"</h5>
<h5>Link type "<dfn><code data-x="rel-serviceworker" data-lt="serviceworker keyword"
data-export="">serviceworker</code></dfn>"</h5>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the lt and export be on the <dfn>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<h5>Link type "<dfn><code data-x="rel-serviceworker" data-lt="serviceworker keyword"

Yeah—thanks, now moved to the dfn

@annevk
Copy link
Member

annevk commented Apr 9, 2017

Is this how we expose link relation keywords in general?

@sideshowbarker
Copy link
Contributor Author

Is this how we expose link relation keywords in general?

We've never had need to expose any others that I'm aware of, because I think either we've not yet had other cases of specs that need to refer back to the definition of a link relation type in HTML in the way that we need for the Service Workers spec, or else any specs that have needed to do it have just manually done it with a hardcoded absolute URL the HTML-spec anchor (rather than using the Bikeshed cross-reference machinery to create the link).

@annevk
Copy link
Member

annevk commented Apr 9, 2017

I wonder if they should have some kind of dedicated type in Bikeshed. @tabatkins?

@domenic
Copy link
Member

domenic commented Apr 10, 2017

In IRC @tabatkins says that this should be data-dfn-for="link/rel" data-dfn-type="attr-value" (then the data-lt should not be necessary).

And then in Bikeshed-using specs you can refer to it as <{link/rel/serviceworker}>

@sideshowbarker
Copy link
Contributor Author

In IRC @tabatkins says that this should be data-dfn-for="link/rel" data-dfn-type="attr-value" (then the data-lt should not be necessary).

Thanks—made it so

@annevk annevk merged commit 5aa74a0 into master Apr 11, 2017
@annevk annevk deleted the sideshowbarker/service-worker-keyword-export branch April 11, 2017 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants