Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to reference HTML for link rel=serviceworker #1073

Closed
domenic opened this issue Feb 15, 2017 · 4 comments
Closed

Update to reference HTML for link rel=serviceworker #1073

domenic opened this issue Feb 15, 2017 · 4 comments
Assignees

Comments

@domenic
Copy link
Contributor

domenic commented Feb 15, 2017

@sideshowbarker added formal definitions for link rel=serviceworker to HTML, containing e.g. authoring conformance requirements, in whatwg/html#2356. The processing model of course stays in this spec. But there are some small tweaks that can be done for integration purposes.

@sideshowbarker
Copy link
Contributor

I can put time into creating a PR for this if nobody else has the cycles at the moment.

@jungkees
Copy link
Collaborator

I'm OOO until 1st of March. PR would be appreciated!

@sideshowbarker
Copy link
Contributor

Note that this needs a resolution on the following question from @domenic:

Either step 8 at https://w3c.github.io/ServiceWorker/#link-element-processing should be removed (normative change!), or we should update HTML to have an invalid value default state (say "invalid"), which you can then throw an error on. Let me know what you think is best.

That step 8 is this:

If workerType is not a valid WorkerType value, queue a task to fire an event named error at the link element, and abort these steps.

@sideshowbarker
Copy link
Contributor

I’m creating a patch/PR for this at the moment and am at the point of realizing the spec doesn’t yet actually define what syntax a service-worker Link header value is expected conform to.

So it seems like as part of this PR I also need to add an ABNF for Link header value.

I now wonder what other specs we might have that contain something I could use as a model—I mean an existing spec that defines the syntax of the value of the Link header for some particular link type.

sideshowbarker added a commit that referenced this issue Apr 9, 2017
* Add new section “Declaring a "serviceworker" Link header”
* Drop normative requirement to fire an error and abort if
  link[workertype] value is not a valid worker type.
* Drop the partial interface IDL for the HTMLLinkElement interface (the
  definitions for the IDL attributes have already been merged directly
  into the HTMLLinkElement interface IDL definition in the HTML spec).

Fixes #1073
sideshowbarker added a commit that referenced this issue Apr 11, 2017
* Add new section “Declaring a "serviceworker" Link header”
* Drop normative requirement to fire an error and abort if
  link[workertype] value is not a valid worker type.
* Drop the partial interface IDL for the HTMLLinkElement interface (the
  definitions for the IDL attributes have already been merged directly
  into the HTMLLinkElement interface IDL definition in the HTML spec).

Fixes #1073
sideshowbarker added a commit that referenced this issue Apr 11, 2017
* Add new section “Declaring a "serviceworker" Link header”
* Drop normative requirement to fire an error and abort if
  link[workertype] value is not a valid worker type.
* Drop the partial interface IDL for the HTMLLinkElement interface (the
  definitions for the IDL attributes have already been merged directly
  into the HTMLLinkElement interface IDL definition in the HTML spec).

Fixes #1073
sideshowbarker added a commit that referenced this issue Jun 12, 2017
* Add new section “Declaring a "serviceworker" Link header”
* Drop normative requirement to fire an error if link[workertype] value
  isn’t a valid worker type; instead just abort.
* Drop the partial interface IDL for the HTMLLinkElement interface (the
  definitions for the IDL attributes have already been merged directly
  into the HTMLLinkElement interface IDL definition in the HTML spec).

Fixes #1073
jungkees pushed a commit that referenced this issue Jun 24, 2017
* Add new section “Declaring a "serviceworker" Link header”
* Drop normative requirement to fire an error if link[workertype] value
  isn’t a valid worker type; instead just abort.
* Drop the partial interface IDL for the HTMLLinkElement interface (the
  definitions for the IDL attributes have already been merged directly
  into the HTMLLinkElement interface IDL definition in the HTML spec).

Fixes #1073
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants