Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

object has no attribute 'working_directory' when running cd info #375

Closed
srussel opened this issue Feb 23, 2019 · 2 comments
Closed

object has no attribute 'working_directory' when running cd info #375

srussel opened this issue Feb 23, 2019 · 2 comments
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Priority: high High priority Regression Bug that breaks functionality known to work in previous releases
Milestone

Comments

@srussel
Copy link

srussel commented Feb 23, 2019

When running whipper cd info I get

Traceback (most recent call last):
  File "/usr/bin/whipper", line 11, in <module>
    load_entry_point('whipper==0.7.3', 'console_scripts', 'whipper')()
  File "/usr/lib/python2.7/dist-packages/whipper/command/main.py", line 43, in main
    ret = cmd.do()
  File "/usr/lib/python2.7/dist-packages/whipper/command/basecommand.py", line 139, in do
    return self.cmd.do()
  File "/usr/lib/python2.7/dist-packages/whipper/command/basecommand.py", line 139, in do
    return self.cmd.do()
  File "/usr/lib/python2.7/dist-packages/whipper/command/cd.py", line 137, in do
    if self.options.working_directory is not None:
AttributeError: 'Namespace' object has no attribute 'working_directory'

The problem appears to be the Info class in cd.py is missing some of the options. I tried copying the arguments from the RIp class into Info.add_arguments and it works. I needed -O, -W, --disc-template, and -o to make it work.

@srussel
Copy link
Author

srussel commented Feb 23, 2019

I also noticed once I got cd info to run it always ejects the CD. I see the Info class has eject = false but it still ejects.

@Freso Freso added Bug Generic bug: can be used together with more specific labels Priority: high High priority Regression Bug that breaks functionality known to work in previous releases labels Feb 23, 2019
@Freso Freso modified the milestones: 1.0, 0.8.0 Feb 23, 2019
@JoeLametta JoeLametta added the Accepted Accepted issue on our roadmap label Mar 18, 2019
@JoeLametta JoeLametta pinned this issue Apr 2, 2019
JoeLametta added a commit that referenced this issue Aug 8, 2019
The attributes `working_directory`, `disc_template`, `output_directory` and `offset` are not defined during `whipper cd info` and they are only needed for ripping, and `self.program.getTable` doesn't need `output_path` to gather the tocfile.

Therefore, this part is excluded, if the attributes don't exist and an offset of 0 is used.

(Not tested yet. But I expect that it will work.)

Fixes issue #375.

Co-authored-by: gorgobacka <tho.b.j@gmx.de>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Signed-off-by: gorgobacka <tho.b.j@gmx.de>
@JoeLametta JoeLametta added the Status: in progress Issue/pull request which is currently being worked on label Aug 8, 2019
JoeLametta added a commit that referenced this issue Oct 26, 2019
The attributes working_directory, disc_template, output_directory and offset are not defined during whipper cd info and they are only needed for ripping. self.program.getTable doesn't need output_path to gather the tocfile.

Therefore, this part is excluded, if the attributes don't exist and an offset of 0 is used.

Fixes issue #375.

Co-authored-by: gorgobacka <tho.b.j@gmx.de>
Signed-off-by: JoeLametta <JoeLametta@users.noreply.github.com>
Signed-off-by: gorgobacka <tho.b.j@gmx.de>
@JoeLametta JoeLametta removed the Status: in progress Issue/pull request which is currently being worked on label Oct 26, 2019
@JoeLametta
Copy link
Collaborator

Fixed with #410.

@JoeLametta JoeLametta unpinned this issue Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Bug Generic bug: can be used together with more specific labels Priority: high High priority Regression Bug that breaks functionality known to work in previous releases
Projects
None yet
3 participants