Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Ignore working_directory, output_directory and disc_template during whipper cd info #390

Closed
wants to merge 1 commit into from
Closed

WIP: Ignore working_directory, output_directory and disc_template during whipper cd info #390

wants to merge 1 commit into from

Conversation

gorgobacka
Copy link
Contributor

The attributes working_directory, disc_template and output_directory are not defined during whipper cd info and they are only needed for ripping, and self.program.getTable doesn't need output_path to gather the tocfile.

Therefore, this part is excluded, if the attributes don't exist. (Fixes: #375)

(Not tested yet. But I expect that it will work.)

@gorgobacka
check self.options for working_directory and output_directory
0602c15 
Signed-off-by: gorgobacka <tho.b.j@gmx.de>
@Freso
Copy link
Member

Freso commented Mar 28, 2019

Thanks for the PR! I'll try and remember to test it out later tonight. :) No comments on the code right now at a glance.

(Well, a test that shows the breakage before this PR and is fixed after this PR would be amazing! ❤️)

@Freso
Copy link
Member

Freso commented Apr 2, 2019

Ripping a disc with this PR, I’m getting errors saying "ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track X". I’m fairly confident I didn’t get those before.

whipper cd info without a CD drive does raise an IOError ("No CD-DA drives found!") rather than "AttributeError: 'Namespace' object has no attribute 'working_directory'", but so does "vanilla" whipper as of commit 752b485. Which version was #375 an issue for?

Full commandline output (I’ll use a CD with a shorter TOC next time! 😅):

> whipper cd rip -O "~/tmp/" -W "~/tmp/"
INFO:whipper.command.cd:using configured read offset 6
INFO:whipper.command.cd:checking device /dev/sr0
eject: Cd-rom-kommandoen luk skuffen mislykkedes: Inddata/uddata-fejl
Track 1 finished, found 4 Q sub-channels with CRC errors
Track 2 finished, found 8 Q sub-channels with CRC errors
Track 3 finished, found 12 Q sub-channels with CRC errors
Track 4 finished, found 9 Q sub-channels with CRC errors
Track 5 finished, found 5 Q sub-channels with CRC errors
Track 6 finished, found 11 Q sub-channels with CRC errors
Track 7 finished, found 8 Q sub-channels with CRC errors
Track 8 finished, found 7 Q sub-channels with CRC errors
Track 9 finished, found 1 Q sub-channels with CRC errors
Track 10 finished, found 5 Q sub-channels with CRC errors
Track 11 finished, found 9 Q sub-channels with CRC errors
Track 12 finished, found 9 Q sub-channels with CRC errors
Track 13 finished, found 7 Q sub-channels with CRC errors
Track 14 finished, found 2 Q sub-channels with CRC errors
Track 15 finished, found 2 Q sub-channels with CRC errors
Track 16 finished, found 3 Q sub-channels with CRC errors
Track 18 finished, found 7 Q sub-channels with CRC errors
Track 19 finished, found 9 Q sub-channels with CRC errors
Track 20 finished, found 4 Q sub-channels with CRC errors
Track 21 finished, found 4 Q sub-channels with CRC errors
Track 22 finished, found 2 Q sub-channels with CRC errors
Track 23 finished, found 12 Q sub-channels with CRC errors
Track 24 finished, found 7 Q sub-channels with CRC errors
Track 25 finished, found 5 Q sub-channels with CRC errors
Track 26 finished, found 4 Q sub-channels with CRC errors
Track 27 finished, found 4 Q sub-channels with CRC errors
Track 28 finished, found 10 Q sub-channels with CRC errors
Track 29 finished, found 6 Q sub-channels with CRC errors
Track 30 finished, found 3 Q sub-channels with CRC errors
Track 31 finished, found 1 Q sub-channels with CRC errors
Track 32 finished, found 6 Q sub-channels with CRC errors
Track 33 finished, found 10 Q sub-channels with CRC errors
CDDB disc id: 05115621
MusicBrainz disc id oMn12.kTqWGtAfZXp2tIGXP.ET8-
MusicBrainz lookup URL https://musicbrainz.org/cdtoc/attach?toc=1+33+333017+150+7077+17364+28721+41579+54123+67041+79243+91997+100704+111181+118776+126972+141329+149199+156475+162595+168618+180971+194747+201643+210723+218075+235400+246478+258350+265979+273996+288072+294836+305924+314225+323445&tracks=33&id=oMn12.kTqWGtAfZXp2tIGXP.ET8-
Disc duration: 01:13:58.226, 33 audio tracks

Matching releases:

Artist  : Decó
Title   : BreakS, LoopS & EditS: Eastside Europe BBoy Sounds
Duration: 01:13:58.216
URL     : https://musicbrainz.org/release/cf01b8e6-8fe0-4938-b79a-b3b53e6f64fc
Release : cf01b8e6-8fe0-4938-b79a-b3b53e6f64fc
Type    : Album
Cat no  : [none]

Track 1 finished, found 3 Q sub-channels with CRC errors
Track 2 finished, found 8 Q sub-channels with CRC errors
Track 3 finished, found 11 Q sub-channels with CRC errors
Track 4 finished, found 9 Q sub-channels with CRC errors
Track 5 finished, found 4 Q sub-channels with CRC errors
Track 6 finished, found 11 Q sub-channels with CRC errors
Track 7 finished, found 9 Q sub-channels with CRC errors
Track 8 finished, found 8 Q sub-channels with CRC errors
Track 9 finished, found 3 Q sub-channels with CRC errors
Track 10 finished, found 5 Q sub-channels with CRC errors
Track 11 finished, found 7 Q sub-channels with CRC errors
Track 12 finished, found 8 Q sub-channels with CRC errors
Track 13 finished, found 7 Q sub-channels with CRC errors
Track 14 finished, found 2 Q sub-channels with CRC errors
Track 15 finished, found 2 Q sub-channels with CRC errors
Track 16 finished, found 4 Q sub-channels with CRC errors
Track 18 finished, found 6 Q sub-channels with CRC errors
Track 19 finished, found 9 Q sub-channels with CRC errors
Track 20 finished, found 4 Q sub-channels with CRC errors
Track 21 finished, found 3 Q sub-channels with CRC errors
Track 22 finished, found 2 Q sub-channels with CRC errors
Track 23 finished, found 13 Q sub-channels with CRC errors
Track 24 finished, found 6 Q sub-channels with CRC errors
Track 25 finished, found 5 Q sub-channels with CRC errors
Track 26 finished, found 3 Q sub-channels with CRC errors
Track 27 finished, found 3 Q sub-channels with CRC errors
Track 28 finished, found 11 Q sub-channels with CRC errors
Track 29 finished, found 4 Q sub-channels with CRC errors
Track 30 finished, found 2 Q sub-channels with CRC errors
Track 31 finished, found 1 Q sub-channels with CRC errors
Track 32 finished, found 7 Q sub-channels with CRC errors
Track 33 finished, found 8 Q sub-channels with CRC errors
INFO:whipper.common.program:changing to working directory /home/freso/tmp/
INFO:whipper.command.cd:ripping track 1 of 33: 01. Decó - Intro.flac
INFO:whipper.program.cdparanoia:checksums match, e401b03f
INFO:whipper.command.cd:CRCs match for track 1
Peak level: 0.998474                      
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 2 of 33: 02. Decó - Spotkanie w Dżungli.flac
INFO:whipper.program.cdparanoia:checksums match, 81014bfd
INFO:whipper.command.cd:CRCs match for track 2
Peak level: 0.998474                      
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 3 of 33: 03. Decó - Stan Pandy.flac
INFO:whipper.program.cdparanoia:checksums match, 8dfd6606
INFO:whipper.command.cd:CRCs match for track 3
Peak level: 0.998474                      
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 4 of 33: 04. Decó - Ladybug.flac
INFO:whipper.program.cdparanoia:checksums match, 4bf935fa
INFO:whipper.command.cd:CRCs match for track 4
Peak level: 0.998474                      
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 5 of 33: 05. Decó - High Fidelity Anthem.flac
INFO:whipper.program.cdparanoia:checksums match, 63f10578
INFO:whipper.command.cd:CRCs match for track 5
Peak level: 0.998474                      
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 6 of 33: 06. Decó - Smolki Tribute.flac
INFO:whipper.program.cdparanoia:checksums match, fb27f6d5
INFO:whipper.command.cd:CRCs match for track 6
Peak level: 0.998474                      
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 7 of 33: 07. Decó - Rezerwat Winyli RiP.flac
INFO:whipper.program.cdparanoia:checksums match, 7ae1b4a1
INFO:whipper.command.cd:CRCs match for track 7
Peak level: 0.998474                      
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 8 of 33: 08. Decó - Heavy Walk.flac
INFO:whipper.program.cdparanoia:checksums match, 734ed681
INFO:whipper.command.cd:CRCs match for track 8
Peak level: 0.998474                      
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 9 of 33: 09. Decó - Totalny Przełom.flac
INFO:whipper.program.cdparanoia:checksums match, 9261050f
INFO:whipper.command.cd:CRCs match for track 9
Peak level: 0.998474                      
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 10 of 33: 10. Decó - Stan Gotowości.flac
INFO:whipper.program.cdparanoia:checksums match, 89edc347
INFO:whipper.command.cd:CRCs match for track 10
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 11 of 33: 11. Decó - The Illest Akai.flac
INFO:whipper.program.cdparanoia:checksums match, 897fe05e
INFO:whipper.command.cd:CRCs match for track 11
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 12 of 33: 12. Decó - Ciekły Potwór.flac
INFO:whipper.program.cdparanoia:checksums match, aa3a0535
INFO:whipper.command.cd:CRCs match for track 12
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 13 of 33: 13. Decó - Loopolubny.flac
INFO:whipper.program.cdparanoia:checksums match, b09d3594
INFO:whipper.command.cd:CRCs match for track 13
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 14 of 33: 14. Decó - Rock Ryba.flac
INFO:whipper.program.cdparanoia:checksums match, a5993763
INFO:whipper.command.cd:CRCs match for track 14
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 15 of 33: 15. Decó - Antyk Wariat.flac
INFO:whipper.program.cdparanoia:checksums match, 79e86f66
INFO:whipper.command.cd:CRCs match for track 15
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 16 of 33: 16. Decó - Sound Break Bazy.flac
INFO:whipper.program.cdparanoia:checksums match, 757ac8bf
INFO:whipper.command.cd:CRCs match for track 16
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 17 of 33: 17. Decó - Lock o Boogie.flac
INFO:whipper.program.cdparanoia:checksums match, 66857326
INFO:whipper.command.cd:CRCs match for track 17
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 18 of 33: 18. Decó - Cegiełka.flac
INFO:whipper.program.cdparanoia:checksums match, 483266f3
INFO:whipper.command.cd:CRCs match for track 18
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 19 of 33: 19. Decó - 4 Sailas.flac
INFO:whipper.program.cdparanoia:checksums match, 8e0b088d
INFO:whipper.command.cd:CRCs match for track 19
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 20 of 33: 20. Decó - Szybki Rak.flac
INFO:whipper.program.cdparanoia:checksums match, 737882ec
INFO:whipper.command.cd:CRCs match for track 20
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 21 of 33: 21. Decó - Dąb Step.flac
INFO:whipper.program.cdparanoia:checksums match, 69f799fb
INFO:whipper.command.cd:CRCs match for track 21
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 22 of 33: 22. Decó - Hiphopheadz pl.flac
INFO:whipper.program.cdparanoia:checksums match, 20adcb8c
INFO:whipper.command.cd:CRCs match for track 22
Peak level: 0.998413                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 23 of 33: 23. Decó - 4 Plash.flac
INFO:whipper.program.cdparanoia:checksums match, 20b3a74d
INFO:whipper.command.cd:CRCs match for track 23
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 24 of 33: 24. Decó - Record Dillaz Anthem.flac
INFO:whipper.program.cdparanoia:checksums match, 44d528fc
INFO:whipper.command.cd:CRCs match for track 24
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 25 of 33: 25. Decó - DEF.flac
INFO:whipper.program.cdparanoia:checksums match, 52f0afc6
INFO:whipper.command.cd:CRCs match for track 25
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 26 of 33: 26. Decó - Small Key.flac
INFO:whipper.program.cdparanoia:checksums match, 90f39140
INFO:whipper.command.cd:CRCs match for track 26
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 27 of 33: 27. Decó - Stare Gary.flac
INFO:whipper.program.cdparanoia:checksums match, 218b5ff4
INFO:whipper.command.cd:CRCs match for track 27
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 28 of 33: 28. Decó - Hala Targowa Breaks.flac
INFO:whipper.program.cdparanoia:checksums match, d155db04
INFO:whipper.command.cd:CRCs match for track 28
Peak level: 0.997864                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 29 of 33: 29. Decó - To Był Błąd.flac
INFO:whipper.program.cdparanoia:checksums match, 42870c16
INFO:whipper.command.cd:CRCs match for track 29
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 30 of 33: 30. Decó - Propozycja.flac
INFO:whipper.program.cdparanoia:checksums match, acd59482
INFO:whipper.command.cd:CRCs match for track 30
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 31 of 33: 31. Decó - XYZ.flac
INFO:whipper.program.cdparanoia:checksums match, b800f247
INFO:whipper.command.cd:CRCs match for track 31
Peak level: 0.991364                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 32 of 33: 32. Decó - Nie Ma Lipy.flac
INFO:whipper.program.cdparanoia:checksums match, 9b2672d3
INFO:whipper.command.cd:CRCs match for track 32
Peak level: 0.998474                       
Rip quality: 100.00%
INFO:whipper.command.cd:ripping track 33 of 33: 33. Decó - Power Outro.flac
INFO:whipper.program.cdparanoia:checksums match, 12e75ae3
INFO:whipper.command.cd:CRCs match for track 33
Peak level: 0.998230                       
Rip quality: 100.00%
INFO:whipper.image.cue:parsing .cue file u'/home/freso/tmp/Dec\xf3 - BreakS, LoopS _ EditS - Eastside Europe BBoy Sounds (2012) [FLAC]/Dec\xf3 - BreakS, LoopS _ EditS - Eastside Europe BBoy Sounds.cue'
ERROR:whipper.common.accurip:error retrieving AccurateRip entry: 404 Not Found <Response [404]>
WARNING:whipper.common.accurip:entry not found in AccurateRip database
WARNING:whipper.command.cd:AccurateRip entry not found
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 1
track  1: unknown          (error)                
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 2
track  2: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 3
track  3: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 4
track  4: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 5
track  5: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 6
track  6: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 7
track  7: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 8
track  8: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 9
track  9: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 10
track 10: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 11
track 11: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 12
track 12: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 13
track 13: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 14
track 14: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 15
track 15: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 16
track 16: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 17
track 17: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 18
track 18: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 19
track 19: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 20
track 20: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 21
track 21: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 22
track 22: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 23
track 23: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 24
track 24: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 25
track 25: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 26
track 26: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 27
track 27: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 28
track 28: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 29
track 29: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 30
track 30: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 31
track 31: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 32
track 32: unknown          (error)
ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track 33
track 33: unknown          (error)

@gorgobacka gorgobacka changed the title Ignore working_directory, output_directory and disc_template during whipper cd info WIP: Ignore working_directory, output_directory and disc_template during whipper cd info Apr 9, 2019
@gorgobacka
Copy link
Contributor Author

TODO: The "offset" parameter is also needed in the context of: whipper cd info.

But I don't get this error message: "ERROR:whipper.common.accurip:no track AR CRC on non-HTOA track X". And I don't think that this PR is related to it in any way.

I will try to finalize this PR soon.

@JoeLametta
Copy link
Collaborator

@gorgobacka Ping. 😉

@gorgobacka
Copy link
Contributor Author

gorgobacka commented May 8, 2019 •
edited
Loading

@gorgobacka Ping. wink

Sorry for the long delay. I will work on this PR on the weekend.

@JoeLametta
Copy link
Collaborator

Sorry for the long delay. I will work on this PR on the weekend.

Thanks. No hurry, take your time.

@JoeLametta
Copy link
Collaborator

@gorgobacka Ping. 😉

1 similar comment
@JoeLametta
Copy link
Collaborator

@gorgobacka Ping. 😉

@JoeLametta
Copy link
Collaborator

Fully implemented in #410.

@JoeLametta JoeLametta closed this Oct 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

object has no attribute 'working_directory' when running cd info
3 participants
@gorgobacka @Freso @JoeLametta